mirror of
https://github.com/MiyooCFW/buildroot.git
synced 2025-09-27 22:24:19 +03:00
Merge from bittboy/buildroot@26c91a9
This commit is contained in:
@@ -0,0 +1,35 @@
|
||||
From 510d0ad0ce1b51c072309ba12dfb024fc2c3dbac Mon Sep 17 00:00:00 2001
|
||||
From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
|
||||
Date: Wed, 26 Aug 2020 10:15:22 +0200
|
||||
Subject: [PATCH 1/5] drm/bridge_connector: Set default status connected for
|
||||
eDP connectors
|
||||
|
||||
In an eDP application, HPD is not required and on most bridge chips
|
||||
useless. If HPD is not used, we need to set initial status as connected,
|
||||
otherwise the connector created by the drm_bridge_connector API remains
|
||||
in an unknown state.
|
||||
|
||||
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
|
||||
Acked-by: Sam Ravnborg <sam@ravnborg.org>
|
||||
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
|
||||
Reviewed-by: Bilal Wasim <bwasim.lkml@gmail.com>
|
||||
Tested-by: Bilal Wasim <bwasim.lkml@gmail.com>
|
||||
---
|
||||
drivers/gpu/drm/drm_bridge_connector.c | 1 +
|
||||
1 file changed, 1 insertion(+)
|
||||
|
||||
diff --git a/drivers/gpu/drm/drm_bridge_connector.c b/drivers/gpu/drm/drm_bridge_connector.c
|
||||
index c6994fe673f3..a58cbde59c34 100644
|
||||
--- a/drivers/gpu/drm/drm_bridge_connector.c
|
||||
+++ b/drivers/gpu/drm/drm_bridge_connector.c
|
||||
@@ -187,6 +187,7 @@ drm_bridge_connector_detect(struct drm_connector *connector, bool force)
|
||||
case DRM_MODE_CONNECTOR_DPI:
|
||||
case DRM_MODE_CONNECTOR_LVDS:
|
||||
case DRM_MODE_CONNECTOR_DSI:
|
||||
+ case DRM_MODE_CONNECTOR_eDP:
|
||||
status = connector_status_connected;
|
||||
break;
|
||||
default:
|
||||
--
|
||||
2.25.1
|
||||
|
||||
@@ -0,0 +1,50 @@
|
||||
From cc0f2fea61fb34ca84e4812a615e0035d812aa8b Mon Sep 17 00:00:00 2001
|
||||
From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
|
||||
Date: Wed, 26 Aug 2020 10:15:23 +0200
|
||||
Subject: [PATCH 2/5] drm/bridge: ps8640: Get the EDID from eDP control
|
||||
|
||||
The PS8640 DSI-to-eDP bridge can retrieve the EDID, so implement the
|
||||
.get_edid callback and set the flag to indicate the core to use it.
|
||||
|
||||
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
|
||||
Acked-by: Sam Ravnborg <sam@ravnborg.org>
|
||||
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
|
||||
---
|
||||
drivers/gpu/drm/bridge/parade-ps8640.c | 12 ++++++++++++
|
||||
1 file changed, 12 insertions(+)
|
||||
|
||||
diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c
|
||||
index 4b099196afeb..13755d278db6 100644
|
||||
--- a/drivers/gpu/drm/bridge/parade-ps8640.c
|
||||
+++ b/drivers/gpu/drm/bridge/parade-ps8640.c
|
||||
@@ -242,8 +242,18 @@ static int ps8640_bridge_attach(struct drm_bridge *bridge,
|
||||
return ret;
|
||||
}
|
||||
|
||||
+static struct edid *ps8640_bridge_get_edid(struct drm_bridge *bridge,
|
||||
+ struct drm_connector *connector)
|
||||
+{
|
||||
+ struct ps8640 *ps_bridge = bridge_to_ps8640(bridge);
|
||||
+
|
||||
+ return drm_get_edid(connector,
|
||||
+ ps_bridge->page[PAGE0_DP_CNTL]->adapter);
|
||||
+}
|
||||
+
|
||||
static const struct drm_bridge_funcs ps8640_bridge_funcs = {
|
||||
.attach = ps8640_bridge_attach,
|
||||
+ .get_edid = ps8640_bridge_get_edid,
|
||||
.post_disable = ps8640_post_disable,
|
||||
.pre_enable = ps8640_pre_enable,
|
||||
};
|
||||
@@ -294,6 +304,8 @@ static int ps8640_probe(struct i2c_client *client)
|
||||
|
||||
ps_bridge->bridge.funcs = &ps8640_bridge_funcs;
|
||||
ps_bridge->bridge.of_node = dev->of_node;
|
||||
+ ps_bridge->bridge.ops = DRM_BRIDGE_OP_EDID;
|
||||
+ ps_bridge->bridge.type = DRM_MODE_CONNECTOR_eDP;
|
||||
|
||||
ps_bridge->page[PAGE0_DP_CNTL] = client;
|
||||
|
||||
--
|
||||
2.25.1
|
||||
|
||||
@@ -0,0 +1,35 @@
|
||||
From 62afc499fc46c8018f40733c31a675b28f0717d8 Mon Sep 17 00:00:00 2001
|
||||
From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
|
||||
Date: Wed, 26 Aug 2020 10:15:24 +0200
|
||||
Subject: [PATCH 3/5] drm/bridge: ps8640: Return an error for incorrect attach
|
||||
flags
|
||||
|
||||
Bridge drivers that implement the new model only shall return an error
|
||||
from their attach() handler when the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag
|
||||
is not set. So make sure we return an error because only the new
|
||||
drm_bridge model is supported.
|
||||
|
||||
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
|
||||
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
|
||||
---
|
||||
drivers/gpu/drm/bridge/parade-ps8640.c | 4 ++++
|
||||
1 file changed, 4 insertions(+)
|
||||
|
||||
diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c
|
||||
index 13755d278db6..ce3e8b2da8c9 100644
|
||||
--- a/drivers/gpu/drm/bridge/parade-ps8640.c
|
||||
+++ b/drivers/gpu/drm/bridge/parade-ps8640.c
|
||||
@@ -200,6 +200,10 @@ static int ps8640_bridge_attach(struct drm_bridge *bridge,
|
||||
.channel = 0,
|
||||
.node = NULL,
|
||||
};
|
||||
+
|
||||
+ if (!(flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR))
|
||||
+ return -EINVAL;
|
||||
+
|
||||
/* port@0 is ps8640 dsi input port */
|
||||
in_ep = of_graph_get_endpoint_by_regs(dev->of_node, 0, -1);
|
||||
if (!in_ep)
|
||||
--
|
||||
2.25.1
|
||||
|
||||
@@ -0,0 +1,58 @@
|
||||
From 4897262a71cbf55d726d9174f5f646897dc13704 Mon Sep 17 00:00:00 2001
|
||||
From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
|
||||
Date: Wed, 26 Aug 2020 10:15:25 +0200
|
||||
Subject: [PATCH 4/5] drm/bridge: ps8640: Print an error if VDO control fails
|
||||
|
||||
Print an error message inside ps8640_bridge_vdo_control() function when
|
||||
it fails so we can simplify a bit the callers, they will only need to
|
||||
check the error code.
|
||||
|
||||
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
|
||||
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
|
||||
---
|
||||
drivers/gpu/drm/bridge/parade-ps8640.c | 13 ++++++-------
|
||||
1 file changed, 6 insertions(+), 7 deletions(-)
|
||||
|
||||
diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c
|
||||
index ce3e8b2da8c9..9f7b7a9c53c5 100644
|
||||
--- a/drivers/gpu/drm/bridge/parade-ps8640.c
|
||||
+++ b/drivers/gpu/drm/bridge/parade-ps8640.c
|
||||
@@ -82,8 +82,11 @@ static int ps8640_bridge_vdo_control(struct ps8640 *ps_bridge,
|
||||
ret = i2c_smbus_write_i2c_block_data(client, PAGE3_SET_ADD,
|
||||
sizeof(vdo_ctrl_buf),
|
||||
vdo_ctrl_buf);
|
||||
- if (ret < 0)
|
||||
+ if (ret < 0) {
|
||||
+ DRM_ERROR("failed to %sable VDO: %d\n",
|
||||
+ ctrl == ENABLE ? "en" : "dis", ret);
|
||||
return ret;
|
||||
+ }
|
||||
|
||||
return 0;
|
||||
}
|
||||
@@ -150,10 +153,8 @@ static void ps8640_pre_enable(struct drm_bridge *bridge)
|
||||
}
|
||||
|
||||
ret = ps8640_bridge_vdo_control(ps_bridge, ENABLE);
|
||||
- if (ret) {
|
||||
- DRM_ERROR("failed to enable VDO: %d\n", ret);
|
||||
+ if (ret)
|
||||
goto err_regulators_disable;
|
||||
- }
|
||||
|
||||
/* Switch access edp panel's edid through i2c */
|
||||
ret = i2c_smbus_write_byte_data(client, PAGE2_I2C_BYPASS,
|
||||
@@ -175,9 +176,7 @@ static void ps8640_post_disable(struct drm_bridge *bridge)
|
||||
struct ps8640 *ps_bridge = bridge_to_ps8640(bridge);
|
||||
int ret;
|
||||
|
||||
- ret = ps8640_bridge_vdo_control(ps_bridge, DISABLE);
|
||||
- if (ret < 0)
|
||||
- DRM_ERROR("failed to disable VDO: %d\n", ret);
|
||||
+ ps8640_bridge_vdo_control(ps_bridge, DISABLE);
|
||||
|
||||
gpiod_set_value(ps_bridge->gpio_reset, 1);
|
||||
gpiod_set_value(ps_bridge->gpio_powerdown, 1);
|
||||
--
|
||||
2.25.1
|
||||
|
||||
@@ -0,0 +1,162 @@
|
||||
From 5bb60fe7c748a0aae2bdbab10e73b2dc48c09dda Mon Sep 17 00:00:00 2001
|
||||
From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
|
||||
Date: Wed, 26 Aug 2020 10:15:26 +0200
|
||||
Subject: [PATCH 5/5] drm/bridge: ps8640: Rework power state handling
|
||||
|
||||
The get_edid() callback can be triggered anytime by an ioctl, i.e
|
||||
|
||||
drm_mode_getconnector (ioctl)
|
||||
-> drm_helper_probe_single_connector_modes
|
||||
-> drm_bridge_connector_get_modes
|
||||
-> ps8640_bridge_get_edid
|
||||
|
||||
Actually if the bridge pre_enable() function was not called before
|
||||
get_edid(), the driver will not be able to get the EDID properly and
|
||||
display will not work until a second get_edid() call is issued and if
|
||||
pre_enable() is called before. The side effect of this, for example, is
|
||||
that you see anything when `Frecon` starts, neither the splash screen,
|
||||
until the graphical session manager starts.
|
||||
|
||||
To fix this we need to make sure that all we need is enabled before
|
||||
reading the EDID. This means the following:
|
||||
|
||||
1. If get_edid() is called before having the device powered we need to
|
||||
power on the device. In such case, the driver will power off again the
|
||||
device.
|
||||
|
||||
2. If get_edid() is called after having the device powered, all should
|
||||
just work. We added a powered flag in order to avoid recurrent calls
|
||||
to ps8640_bridge_poweron() and unneeded delays.
|
||||
|
||||
3. This seems to be specific for this device, but we need to make sure
|
||||
the panel is powered on before do a power on cycle on this device.
|
||||
Otherwise the device fails to retrieve the EDID.
|
||||
|
||||
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
|
||||
---
|
||||
drivers/gpu/drm/bridge/parade-ps8640.c | 64 +++++++++++++++++++++++---
|
||||
1 file changed, 58 insertions(+), 6 deletions(-)
|
||||
|
||||
diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c
|
||||
index 9f7b7a9c53c5..c5d76e209bda 100644
|
||||
--- a/drivers/gpu/drm/bridge/parade-ps8640.c
|
||||
+++ b/drivers/gpu/drm/bridge/parade-ps8640.c
|
||||
@@ -65,6 +65,7 @@ struct ps8640 {
|
||||
struct regulator_bulk_data supplies[2];
|
||||
struct gpio_desc *gpio_reset;
|
||||
struct gpio_desc *gpio_powerdown;
|
||||
+ bool powered;
|
||||
};
|
||||
|
||||
static inline struct ps8640 *bridge_to_ps8640(struct drm_bridge *e)
|
||||
@@ -91,13 +92,15 @@ static int ps8640_bridge_vdo_control(struct ps8640 *ps_bridge,
|
||||
return 0;
|
||||
}
|
||||
|
||||
-static void ps8640_pre_enable(struct drm_bridge *bridge)
|
||||
+static void ps8640_bridge_poweron(struct ps8640 *ps_bridge)
|
||||
{
|
||||
- struct ps8640 *ps_bridge = bridge_to_ps8640(bridge);
|
||||
struct i2c_client *client = ps_bridge->page[PAGE2_TOP_CNTL];
|
||||
unsigned long timeout;
|
||||
int ret, status;
|
||||
|
||||
+ if (ps_bridge->powered)
|
||||
+ return;
|
||||
+
|
||||
ret = regulator_bulk_enable(ARRAY_SIZE(ps_bridge->supplies),
|
||||
ps_bridge->supplies);
|
||||
if (ret < 0) {
|
||||
@@ -164,6 +167,8 @@ static void ps8640_pre_enable(struct drm_bridge *bridge)
|
||||
goto err_regulators_disable;
|
||||
}
|
||||
|
||||
+ ps_bridge->powered = true;
|
||||
+
|
||||
return;
|
||||
|
||||
err_regulators_disable:
|
||||
@@ -171,12 +176,12 @@ static void ps8640_pre_enable(struct drm_bridge *bridge)
|
||||
ps_bridge->supplies);
|
||||
}
|
||||
|
||||
-static void ps8640_post_disable(struct drm_bridge *bridge)
|
||||
+static void ps8640_bridge_poweroff(struct ps8640 *ps_bridge)
|
||||
{
|
||||
- struct ps8640 *ps_bridge = bridge_to_ps8640(bridge);
|
||||
int ret;
|
||||
|
||||
- ps8640_bridge_vdo_control(ps_bridge, DISABLE);
|
||||
+ if (!ps_bridge->powered)
|
||||
+ return;
|
||||
|
||||
gpiod_set_value(ps_bridge->gpio_reset, 1);
|
||||
gpiod_set_value(ps_bridge->gpio_powerdown, 1);
|
||||
@@ -184,6 +189,28 @@ static void ps8640_post_disable(struct drm_bridge *bridge)
|
||||
ps_bridge->supplies);
|
||||
if (ret < 0)
|
||||
DRM_ERROR("cannot disable regulators %d\n", ret);
|
||||
+
|
||||
+ ps_bridge->powered = false;
|
||||
+}
|
||||
+
|
||||
+static void ps8640_pre_enable(struct drm_bridge *bridge)
|
||||
+{
|
||||
+ struct ps8640 *ps_bridge = bridge_to_ps8640(bridge);
|
||||
+ int ret;
|
||||
+
|
||||
+ ps8640_bridge_poweron(ps_bridge);
|
||||
+
|
||||
+ ret = ps8640_bridge_vdo_control(ps_bridge, DISABLE);
|
||||
+ if (ret < 0)
|
||||
+ ps8640_bridge_poweroff(ps_bridge);
|
||||
+}
|
||||
+
|
||||
+static void ps8640_post_disable(struct drm_bridge *bridge)
|
||||
+{
|
||||
+ struct ps8640 *ps_bridge = bridge_to_ps8640(bridge);
|
||||
+
|
||||
+ ps8640_bridge_vdo_control(ps_bridge, DISABLE);
|
||||
+ ps8640_bridge_poweroff(ps_bridge);
|
||||
}
|
||||
|
||||
static int ps8640_bridge_attach(struct drm_bridge *bridge,
|
||||
@@ -249,9 +276,34 @@ static struct edid *ps8640_bridge_get_edid(struct drm_bridge *bridge,
|
||||
struct drm_connector *connector)
|
||||
{
|
||||
struct ps8640 *ps_bridge = bridge_to_ps8640(bridge);
|
||||
+ bool poweroff = !ps_bridge->powered;
|
||||
+ struct edid *edid;
|
||||
+
|
||||
+ /*
|
||||
+ * When we end calling get_edid() triggered by an ioctl, i.e
|
||||
+ *
|
||||
+ * drm_mode_getconnector (ioctl)
|
||||
+ * -> drm_helper_probe_single_connector_modes
|
||||
+ * -> drm_bridge_connector_get_modes
|
||||
+ * -> ps8640_bridge_get_edid
|
||||
+ *
|
||||
+ * We need to make sure that what we need is enabled before reading
|
||||
+ * EDID, for this chip, we need to do a full poweron, otherwise it will
|
||||
+ * fail.
|
||||
+ */
|
||||
+ drm_bridge_chain_pre_enable(bridge);
|
||||
|
||||
- return drm_get_edid(connector,
|
||||
+ edid = drm_get_edid(connector,
|
||||
ps_bridge->page[PAGE0_DP_CNTL]->adapter);
|
||||
+
|
||||
+ /*
|
||||
+ * If we call the get_edid() function without having enabled the chip
|
||||
+ * before, return the chip to its original power state.
|
||||
+ */
|
||||
+ if (poweroff)
|
||||
+ drm_bridge_chain_post_disable(bridge);
|
||||
+
|
||||
+ return edid;
|
||||
}
|
||||
|
||||
static const struct drm_bridge_funcs ps8640_bridge_funcs = {
|
||||
--
|
||||
2.25.1
|
||||
|
||||
@@ -0,0 +1,41 @@
|
||||
From 51109530891c981b681816152bd205724deabcca Mon Sep 17 00:00:00 2001
|
||||
From: Jitao Shi <jitao.shi@mediatek.com>
|
||||
Date: Sat, 10 Oct 2020 15:09:09 +0800
|
||||
Subject: [PATCH] Revert "drm/mediatek: dsi: Fix scrolling of panel with small
|
||||
hfp or hbp"
|
||||
|
||||
This reverts commit 35bf948f1edbf507f6e57e0879fa6ea36d2d2930.
|
||||
|
||||
Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
|
||||
Reviewed-by: Bilal Wasim <bilal.wasim@imgtec.com>
|
||||
Tested-by: Bilal Wasim <bilal.wasim@imgtec.com>
|
||||
---
|
||||
drivers/gpu/drm/mediatek/mtk_dsi.c | 9 +++++----
|
||||
1 file changed, 5 insertions(+), 4 deletions(-)
|
||||
|
||||
diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
|
||||
index 80b7a082e874..16fd99dcdacf 100644
|
||||
--- a/drivers/gpu/drm/mediatek/mtk_dsi.c
|
||||
+++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
|
||||
@@ -466,13 +466,14 @@ static void mtk_dsi_config_vdo_timing(struct mtk_dsi *dsi)
|
||||
horizontal_sync_active_byte = (vm->hsync_len * dsi_tmp_buf_bpp - 10);
|
||||
|
||||
if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_SYNC_PULSE)
|
||||
- horizontal_backporch_byte = vm->hback_porch * dsi_tmp_buf_bpp;
|
||||
+ horizontal_backporch_byte =
|
||||
+ (vm->hback_porch * dsi_tmp_buf_bpp - 10);
|
||||
else
|
||||
- horizontal_backporch_byte = (vm->hback_porch + vm->hsync_len) *
|
||||
- dsi_tmp_buf_bpp;
|
||||
+ horizontal_backporch_byte = ((vm->hback_porch + vm->hsync_len) *
|
||||
+ dsi_tmp_buf_bpp - 10);
|
||||
|
||||
data_phy_cycles = timing->lpx + timing->da_hs_prepare +
|
||||
- timing->da_hs_zero + timing->da_hs_exit;
|
||||
+ timing->da_hs_zero + timing->da_hs_exit + 3;
|
||||
|
||||
if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_BURST) {
|
||||
if ((vm->hfront_porch + vm->hback_porch) * dsi_tmp_buf_bpp >
|
||||
--
|
||||
2.25.1
|
||||
|
||||
Reference in New Issue
Block a user