iiiypuk/cantata
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
7,590 Commits 1 Branch 12 Tags
master
Commit Graph

1878 Commits

Author SHA1 Message Date
Craig Drummond
b2d740d0e9 Don't write empty genres to tags. 
Issue #1765
 2022-02-06 12:41:55 +00:00
Craig Drummond
680a4a8398 Stop user MPD instance from GUI thread when terminating, to ensure state can be saved. 
Closes #1761
 2022-01-11 12:08:14 +00:00
Craig Drummond
cb1d890e05 If using table-style play queue, then only sort one column at a time. 
Issue #1749
 2021-12-27 20:49:14 +00:00
Craig Drummond
dbdc211da2 Use QCollator to compare strings. 2021-12-27 20:39:51 +00:00
Craig Drummond
f4e4a6ed33 Add Grouping tag support to playlists and queue. 2021-12-27 19:58:47 +00:00
Craig Drummond
dbfc8d92ed Merge branch 'master' of github.com:CDrummond/cantata 2021-12-23 13:47:55 +00:00
Craig Drummond
e68c4011af Fix looking for cover-art with MPD's new cue track file listing. 
Issue #1759
 2021-12-23 13:46:09 +00:00
Philip Sequeira
26f6a40b0e Remove superfluous line break from cover tooltip 
The line break appears to have originally separated textual information
in the tooltip from the cover image. All the textual information was
removed in 2d8566d743, so the image is now
the only thing in the tooltip and the line break was just creating an
empty space above it.
 2021-11-17 03:15:22 -05:00
Craig Drummond
cb8cbb6002 Add "Refresh" action to hover actions for podcasts. 
Issue #1753
 2021-11-12 21:34:52 +00:00
Craig Drummond
630d3c5c6e When searching for lyrics, if fail and artist starts with "The " then try again without "The " 
Closes #1752
 2021-11-11 23:11:08 +00:00
Craig Drummond
62fe336a01 Update 2021-11-10 12:24:07 +00:00
Craig Drummond
980227806f Remove SoundCloud support, no longer works due to API changes. 
Closes #1745
 2021-10-06 18:19:21 +01:00
Craig Drummond
2a6dd2d83a Handle case where IceCast list is not GZipped. 
Closes #1744
 2021-09-28 16:29:22 +01:00
Craig Drummond
f9e7637468 Don't save queue if string entered in dave dialog but cancel button 
pressed.

Closes #1739
 2021-09-03 19:55:19 +01:00
Craig Drummond
f29a9f8d91 Fix crash when trying to copy songs to MTP device but libMTP has failed to get storage list. 
Closes #1731
 2021-08-11 18:39:01 +01:00
Craig Drummond
059aceb95d Fix build issues due to previous change. #1727 2021-07-29 12:13:42 +01:00
CraigD
b296cf7113 Update ChangeLog 
Update
 2021-07-09 07:08:23 +01:00
Craig Drummond
4539377701 Partitions requires MPD>=0.22 2021-05-11 12:06:35 +01:00
Craig Drummond
d61ca87408 Change version to 2.5.0, as new feature added 2021-05-11 12:05:19 +01:00
Craig Drummond
e5bbcc6d32 When stopping Cantata controlled MPD instance, wait up to 2 seconds for MPD to gracefully terminate (so config can be saved) before killing process. 
Issue #1710
 2021-05-07 12:03:49 +01:00
Craig Drummond
23f2c510e6 Fix updating now-plying metadata for radio streams that transmit track 
numbers.
Issue #1707
 2021-05-04 18:18:45 +01:00
Craig Drummond
6b15303f17 HTML escape values before fixing new lines, not after! 
Closes #1698
 2021-03-19 17:50:02 +00:00
Craig Drummond
664077100a Update 2021-03-19 17:49:31 +00:00
Craig Drummond
efe380f9c2 Remove Spotify image search, also broken 
Issue #1694
 2021-03-16 12:06:52 +00:00
Craig Drummond
6df030b41a Remvoe google image searc - broken 
Issue #1694
 2021-03-16 12:06:26 +00:00
Craig Drummond
8bec9dd1f8 Remove option to select cover image providers, always use all. 
Issue #1694
 2021-03-16 12:05:28 +00:00
Craig Drummond
848dc5a6b3 Fix decoding URLs when playing local files via in-built HTTP server. 
Closes #1664
 2021-01-14 19:33:40 +00:00
Craig Drummond
e4e529fb9e Enable scrobbling, auth works? #1661 2021-01-12 12:00:59 +00:00
CraigD
3256602b12 Update ChangeLog 2021-01-11 08:47:18 +00:00
Craig Drummond
9df2a54761 Disable scrollbing support, as auth changed. 
Closes #1661
 2021-01-03 10:15:42 +00:00
Craig Drummond
eb352aed88 Remove stream providers, as many broken. 
Closes #1656
 2020-12-05 17:26:04 +00:00
Craig Drummond
18236999a7 Disable categorized view, as its been reported to crash 
Issue #1530
 2020-11-29 13:22:41 +00:00
Craig Drummond
2598cea8c0 Update 2020-11-24 12:18:00 +00:00
Craig Drummond
07838308fd Remember, and restore, main window position. 
Closes #1653
 2020-11-22 14:57:35 +00:00
Craig Drummond
82a6798c83 - Better handling of CUE tracks when MPD is set to list as directory. 
- Disable CUE parsing in cantata by default, as MPD handles this better now.

Issues #1650 and #1652
 2020-11-17 12:06:04 +00:00
Craig Drummond
4d9bb761e6 Remove dirble from radio section, as its no longer active. 2020-11-08 10:46:17 +00:00
Craig Drummond
549e9b6fd6 Fix Community Radio Browser search. 
Closes #1649
 2020-11-08 10:37:12 +00:00
Craig Drummond
388d28d326 Update 2020-11-07 09:52:04 +00:00
Thomas Uhle
ae50e15bce Update bitrate settings for encoders 
- Fix average bitrates for FAAC encoding according to documentation. See for
  reference, e.g., `faac --help-qual` in the console and information from
  * https://wiki.hydrogenaud.io/index.php/FAAC
  * https://en.wikipedia.org/wiki/Codec_listening_test
- Fix average bitrates for LAME MP3 encoding according to documentation.
  See for reference, e.g.,
  * https://wiki.hydrogenaud.io/index.php/LAME#Technical_information
  * https://trac.ffmpeg.org/wiki/Encode/MP3#VBREncoding
- Fix average bitrate for Ogg Vorbis and Opus encoding with quality level 10;
  it should be 384kb/s according to documentation. See for reference, e.g.,
  * https://trac.ffmpeg.org/wiki/TheoraVorbisEncodingGuide#VariableBitrateVBR
  * https://wiki.xiph.org/index.php/Opus_Recommended_Settings
- Add popular 256kb/s CBR to AAC encoding settings and change the rather
  unusual 360kb/s into 384kb/s.
- Update default bitrate selection for AAC and Opus so that it matches the
  recommendation in the corresponding tooltip.
- Change bitrates in the tooltip that are not listed to a reasonable bitrate
  from the list that is nearby the former bitrate.
 2020-07-07 15:55:37 +02:00
Craig Drummond
a223acb336 Update 2020-06-29 21:44:33 +01:00
Thomas Uhle
4ca9943e1e Change SongView::update() to always update and show metadata 
Also show metadata of the current track in the context view if 'title' or
'artist' are missing, but keep not to fetch information nor lyrics. Also
update metadata if other tags different from 'title' or 'artist' change.
 2020-06-10 14:30:15 +02:00
Thomas Uhle
b797e225d4 Fix MainWindow::moveSelectionAfterCurrentSong() 
Ignore current song in selection when moving selected songs within the play
queue to play them next.
 2020-06-10 12:44:33 +02:00
Thomas Uhle
b43c93655a Avoid prepending song's file path with MPD's music directory 
if it is empty, a stream URL or an absolute path.
 2020-06-09 22:55:43 +02:00
Thomas Uhle
34a8be6b6e Fix loading cover images with wrong file extension in context view 
TextBrowser::loadResource() would fall back to QTextBrowser::loadResource()
if images do not have the right file extentsion. This may most certainly be
prevented if we try to load the image from plain data without the hint from
its file name.
 2020-06-08 14:25:47 +02:00
Thomas Uhle
66bad2a256 Fix writing 'descr' attribute in PodcastService::Podcast::save() 2020-06-08 14:00:01 +02:00
Thomas Uhle
c89d3f76b3 Query Qt whether system tray is available if not (Unity flavored) GNOME 
- Since 2017, Unity is yet a special Ubuntu flavor of GNOME. That is why
  system tray support with QSystemTrayIcon is only provided if the Ayatana
  Indicator application or the GNOME Shell extension AppIndicator or
  something similar that implements org.kde.StatusNotifierWatcher is
  installed and running. Hence, Unity should be treated the same as plain
  GNOME.
- Although Qt prefers to internally use QDBusTrayIcon for QSystemTrayIcon,
  there is also a fallback implementation using XCB if Qt has X11 support
  and org.kde.StatusNotifierWatcher is not registered on D-Bus. There are
  settings with some desktop environments where none of these mechanisms
  are available. So it is not safe to assume QSystemTrayIcon is working if
  Utils::currentDe() returns Utils::Other. Perhaps the only way then is to
  simply rely on QSystemTrayIcon::isSystemTrayAvailable().
 2020-06-08 12:00:09 +02:00
Thomas Uhle
9f5e3bfa33 Additionally call Inhibit() from org.freedesktop.login1.Manager 
to also support desktop environments that do not provide
org.freedesktop.PowerManagement.Inhibit (newer GNOME releases for instance).
 2020-06-06 18:30:05 +02:00
Thomas Uhle
4599a49484 Fix bus name of freedesktop.org's power management 
While the interface name truely is 'org.freedesktop.PowerManagement.Inhibit',
its bus name is yet just 'org.freedesktop.PowerManagement'.
 2020-06-06 18:00:16 +02:00
Thomas Uhle
0df2710b9e Fix enabling of play queue navigation actions 'next' and 'previous' 
To enable or disable 'next' action, just rely on MPD's status value
'nextSongId'. Enable 'previous' action when there is more than one item in
the play queue or one item for which its duration is known and this is more
than 5 seconds. That is to also support the feature to go to the start of a
track if already played 5 seconds of it at least (which was introduced in
version 2.4.0). Corresponding implementation of Mpris and ThumbnailToolBar
updated accordingly.
 2020-05-30 17:00:12 +02:00
Craig Drummond
8a7910ca6c Set default lyrics providers to azlyrics.com, chartlyrics.com, and lyrics.wikia.com 
Issue #1604
 2020-05-23 07:51:38 +01:00