Commit Graph

218 Commits

Author SHA1 Message Date
Thomas Uhle
f346016a58 Guard MPD command 'next' to prevent it from reporting errors
if there is no next song in the play queue that can be played.
2020-05-30 15:30:42 +02:00
Thomas Uhle
4263744926 Avoid unknown song durations and duplicate updates of MPRIS' song details
- Move call to Mpris::updateCurrentSong() downwards to pick up the potential
  update of current song's duration from MPD's total time value (introduced
  by commit 1a38e468b7) and to avoid duplicate
  notifications (cf. commit bba9cfd880).
- Update MPRIS status value CanSeek when MPD's total time changes.
- Set MPDStatusValues::timeElapsed and MPDStatusValues::timeTotal to 0
  instead of -1 by default because the latter yields 65535 as these
  variables are 16 bit unsigned integer.
2020-05-15 12:44:55 +02:00
Thomas Uhle
99113880c0 When checking if songs are different, compare track and disc numbers too 2020-05-15 12:12:07 +02:00
Thomas Uhle
d406c01694 Fix getting song details from Cantata stream URLs
- always get song.time from decoded stream URL
- always set song.file to local file path from decoded stream URL to have
  song.decodedPath() return the correct path
- move song.setLocalPath() out of if branch to always have song.localPath()
  return the correct path
- only update mod.priority if all song detailss are taken from decoded
  stream URL
2020-05-05 18:05:33 +02:00
Craig Drummond
72729bb424 - Correctly handle changing 'Basic' mode music folder.
- When stopping 'Basic' mode MPD instance, send SIGKILL.
Closes #1575
2020-02-29 08:26:57 +00:00
Craig Drummond
b8645d1358 Fix most, but not all, deprecation warnings. 2020-02-16 09:51:37 +00:00
Craig Drummond
d7b3965b9b Update (c) year 2020-01-01 11:51:13 +00:00
Craig Drummond
2d8566d743 - Show podcast coves in toolbar, queue, and info view.
- Show podcast description in info view.
- Only show cover in toolbar cover tooltip.
Issue #1556
2019-12-05 16:01:39 +00:00
Craig Drummond
1d0ee7cf98 Sanitise hash usage
Closes #1549
2019-11-04 16:05:32 +00:00
Craig Drummond
b283429fa1 Use &<Name> or &StreamName:<Name> if URL already has #
Issue #1548
2019-11-03 17:35:40 +00:00
Craig Drummond
a05d81fb03 When adding a stream to the play queue, encode name using #StreamName:name and not just #name - as MPD 0.22 uses this for #icy-metadata
Closes #1547
2019-11-02 10:29:08 +00:00
Craig Drummond
cb9efe205f Update (c) year 2019-09-15 15:56:58 +01:00
Craig Drummond
8c28cadc26 Add 'albumartistsort,artistsort,albumsort" to Cantata local mpd config.
Issue #1529
2019-09-02 12:08:59 +01:00
Craig Drummond
599ea8e542 Add a checkbox controlling whether Cantata should apply its replaygain
setting each time it connects to MPD.

Issue #1531
2019-09-01 09:26:32 +01:00
Craig Drummond
e0752a81d5 Alter behavour of 'previous' button; if played 5 seconds or more, then go to start of track, else go to previous track.
Closes #1509
2019-07-03 13:43:19 +01:00
Craig Drummond
d1411da71b AlumbumKey should use albumArtistOrComposer
Issue #1496
2019-05-25 15:41:57 +01:00
Craig Drummond
238b2b38ad Fix some metadata inconsistencies
Issue #1496
2019-05-25 15:26:57 +01:00
Craig Drummond
7e8c0ab29b Use 'small bullet' unicode character to separate fields
Closes #1494
2019-05-23 17:42:32 +01:00
Craig Drummond
a688c9291c Revert attempt to support abstract sockets - can't seem to get these to
work.
Closes #1486
2019-05-19 21:55:26 +01:00
Craig Drummond
55bf8f5c6c Add "originaldate" to Cantata local mpd config.
Closes #1492
2019-05-19 21:54:00 +01:00
Craig Drummond
d949a15f08 If local socket name starts with @, replace with \0 for abstract socket
Issue #1486
2019-05-18 22:02:59 +01:00
Craig Drummond
6dac1a480a Support multiple genres in CUE files.
Issue #1487
2019-05-16 17:10:57 +01:00
Craig Drummond
986bdf4f10 Another check for @ 2019-05-16 17:10:27 +01:00
Craig Drummond
4ce3bd72d2 If hostname starts with a at (@) treat as local socket.
Issue #1486
2019-05-15 16:47:34 +01:00
Craig Drummond
aaa3c87e8e Apply CueFile changes
Issue #1461
2019-05-12 10:18:19 +01:00
Craig Drummond
1de35af55b Revert some changes
Issue #1461
2019-04-27 09:26:18 +01:00
Craig Drummond
22de6a05b3 Fix compile
Issue #1461
2019-03-29 17:58:33 +00:00
Craig Drummond
001f434905 Parse more fields from CUE files.
Issue #1461
2019-03-29 17:52:23 +00:00
Craig Drummond
48fd4942d7 Apply 'Single Tracks' tweak to play queue items
Issue #1471
2019-03-20 17:01:18 +00:00
Clément Pit-Claudel
e1e15a1d2d Disable zeroconf for local MPD instances
Instances of MPD started by Cantata do not need to register with Avahi, but
zeroconf_enabled defaults to "yes".
2019-03-07 15:34:56 -05:00
Craig Drummond
0690393854 In toolbar, disaply "Composer - Artist - Album" (for composer genres)
Issue #1460
2019-03-01 21:50:45 +00:00
Craig Drummond
ddd46cde1a For genres listed in "Composer Support" tweak, shown composer instead of
artist in context view and toolbar.
Issue #1460
2019-03-01 21:36:57 +00:00
Craig Drummond
5a0260cbd7 Add missing else
Issue #1433
2019-01-05 14:14:49 +00:00
Craig Drummond
af6a825ad3 Merge branch 'master' into 2.4 2018-12-30 10:48:34 +00:00
Craig Drummond
9d9089c67f MPRIS seeks command specifies an offset from current position.
Closes #1417
2018-12-09 20:38:21 +00:00
Craig Drummond
a21827b102 Fix MPD cover art retreival 2018-11-12 19:38:53 +00:00
Craig Drummond
31a561284c Fix MPD albumart reading 2018-11-11 09:17:16 +00:00
Craig Drummond
06cf4c4e3d For MPD>=21, use its albumart protocol to fetch covers. 2018-11-10 18:37:37 +00:00
Matthieu Bouron
36183d7678 HttpStream: cosmetics 2018-10-22 10:41:54 +02:00
Matthieu Bouron
63b574ae67 HttpStream: stop the vlc player if MPD is paused 2018-10-22 10:31:27 +02:00
Matthieu Bouron
dc899a15c9 HttpStream: simplify start player condition 2018-10-22 10:31:27 +02:00
Craig Drummond
3e7a0132a9 Don't stop library scan just because of failure in 1 directory.
Closes #1389
2018-10-18 19:29:22 +01:00
Matthieu Bouron
7b4c47118c HttpStream: remove unneeded check on player media url
This check is already performed in streamUrl().
2018-10-18 17:36:29 +02:00
Matthieu Bouron
25ae4308b5 HttpStream: fix reorder warning 2018-10-18 17:36:29 +02:00
Matthieu Bouron
c7a453283f HttpStream: properly detect stream url changes
Media url property has been removed in a previous commit.
2018-10-18 17:36:29 +02:00
Matthieu Bouron
8d0f826318 HttpStream: remove unused variable 2018-10-18 17:36:29 +02:00
Matthieu Bouron
5bf93d025e Fix build with libvlc
Fixes regression introduced by f8a8a5bb2d.
2018-10-01 16:29:02 +02:00
Craig Drummond
2a80f73609 Don't try to reduce brackets when showing album name and year.
Issue #1373
2018-09-30 09:12:02 +01:00
Matthieu Bouron
286a3fdc94 Wait QMediaPlayer buffering before entering playing state
QMediaPlayer needs to fill its internal buffer before it can play the
stream otherwise it can end up in a stalled state.

This commit also simplifies the logic for when the player needs to be
restarted and remove the need of an internal timer to poll the player
state.

Fixes choppy http playback.
2018-09-28 13:51:21 +02:00
Craig Drummond
9842346e06 If HTTP stream is not enabled, return -1 for volume 2018-09-19 17:16:53 +01:00