iiiypuk/hexchat
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix handling invalid ports.

Browse Source 
Instead of wrapping around, which is not behaviour any reasonable
user would expect, just use the default port if above 65535.

Disallow connecting on port 0. This port has special meaning and
servers can not listen on it. It is more likely the user just
gave an invalid value to the port field as atoi("invalid") == 0.
This commit is contained in:
Sadie Powell 2022-01-17 12:08:16 +00:00 committed by Patrick
parent 9c7109b578
commit 91adfb5917
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/common/server.c
View File

@ -1559,7 +1559,7 @@ server_connect (server *serv, char *hostname, int port, int no_login)
if (!hostname[0])
return;
if (port < 0)
if (port < 1 || port > 65535)
{
/* use default port for this server type */
port = 6667;
@ -1568,7 +1568,6 @@ server_connect (server *serv, char *hostname, int port, int no_login)
port = 6697;
#endif
}
port &= 0xffff; /* wrap around */
if (serv->connected || serv->connecting || serv->recondelay_tag)
server_disconnect (sess, TRUE, -1);