Commit Graph

1617 Commits

Author SHA1 Message Date
TingPing
2a28289314 Don't return 0 in place of NULL 2014-12-31 11:31:17 -05:00
TingPing
112632bb4e Fix some possible null-deref warnings 2014-12-31 11:12:43 -05:00
TingPing
c5016e390f Show correct number of channels/dialogs when closing server tab 2014-12-31 10:50:13 -05:00
TingPing
63bb87fc93 Don't select join #hexchat by default in join dialog
Have to go even one step further removed so users don't
accidentally join
2014-12-31 10:44:36 -05:00
TingPing
1fa4a000e7 Fix some unused warnings 2014-12-31 10:24:51 -05:00
TingPing
6ef7298870 Remove unnecessary use of void* 2014-12-31 03:56:36 -05:00
TingPing
9f7444baa2 Move userlist sorting to frontend
This Fixes possible crashes when the two
usertrees get out of sync and a double free occurs.

Also now requires restart to change sort orders.

Fixes #1252
Fixes #818 (probably)
2014-12-31 03:56:36 -05:00
TingPing
fef580ed7f Rewrite identd
- Use gio (which is cross platform)
- Properly support multiple users
- Allow configuring port
- Allow other plugins overriding
2014-12-30 06:35:42 -05:00
TingPing
3bb717a3b5 Fix windows build
Introduced 1b2bee37e
2014-12-29 02:08:42 -05:00
TingPing
5beaf15f21 Remove option to use socks5 library
This was always disabled by default and is not required
for the current socks support. I am not even sure this
library is packaged by any distro?
2014-12-28 22:29:06 -05:00
TingPing
1b2bee37e4 Remove option to disable ipv6
It has been default for a while, is the only tested option,
and will only get more common.
2014-12-28 22:29:06 -05:00
TingPing
9cb73f839f Remove MSProxy support
It's not enabled anywhere, certainly not maintained
2014-12-28 13:28:19 -05:00
TingPing
330e31c70f Fix overflow 2014-12-28 12:43:53 -05:00
TingPing
cbaa04905f Fix warning 2014-12-28 12:38:19 -05:00
TingPing
14d3a03f41 Fix leak in make-te
This doesn't really matter but it shuts up AddressSanitizer
2014-12-28 08:14:05 -05:00
TingPing
95febd978c Fix building as c89 2014-12-28 06:47:23 -05:00
TingPing
83032b1aa3 Use glib for all allocations
- Removes need to check for malloc failure
- Removes need for NULL checks on free
- Adds checks for integer overflows
- Removes some extra memset calls
- Removes chance of mixing libc and glib malloc/free
2014-12-28 06:44:44 -05:00
TingPing
c4cb1b25ec Fixup: Detect urls with unicode symbols
missed one in 77ecaa6093
2014-12-28 00:40:51 -05:00
TingPing
77ecaa6093 Detect urls with unicode symbols
Fixes #1250
2014-12-28 00:29:58 -05:00
TingPing
aeb5d15871 More consistently include config.h 2014-12-17 18:21:10 -05:00
TingPing
46061f4f3c Remove some unnecessary if statements 2014-12-15 14:51:07 -05:00
Arnavion
ec7a0d6e13 Fixed some more signed-unsigned-comparison warnings. 2014-12-15 10:25:28 -08:00
TingPing
a86b03e939 Remove unused header 2014-12-15 11:07:47 -05:00
TingPing
35fd47da55 Add patch from cygwin 2014-12-15 11:07:47 -05:00
TingPing
226d54c90d Fix use after free 2014-12-14 19:35:27 -05:00
TingPing
f614a3c311 Fix possible overflow when using /menu 2014-12-11 13:49:37 -05:00
TingPing
d6e3f740bc Fix some leaks 2014-12-11 12:13:57 -05:00
md_5
74ff67acd3 Create configuration option to control middle click tab close.
Some might argue that this shouldn't be able to be configured as it is "common" behaviour
in other programs such as web browsers, but for me it is an annoyance because for 15
years this has not been the behaviour of X-Chat.
Quite simply, this creates a configuration option for 537fb856, as unobtrusively as
possible, under the channel switcher preferences tab.

Closes #1232
2014-12-10 15:09:04 -05:00
leeter
6aafc8e51d Fix chanopts not saving if /quit before exit
This is the C fix, unfortunately a proper fix, e.g.
 removing the dependency on session_name all together is a much vaster
 refactor outside the scope of this bugfix.

Closes #1111
2014-12-10 14:40:42 -05:00
TingPing
10246f121a Fix unsafe string handling in configs
Also fixes 2 leaks
2014-12-10 09:32:16 -05:00
TingPing
025152ee53 Fix unused warning 2014-12-10 09:00:29 -05:00
TingPing
58e871696b Fix typo 2014-12-10 09:00:04 -05:00
TingPing
0ba8b922a2 Fix tab completing with no completion char 2014-12-09 23:03:44 -05:00
TingPing
b296839538 Respect servers chantypes and nickprefixes when tab completing
Closes #441
2014-12-09 05:45:50 -05:00
TingPing
5fb21a04ad Use gboolean for bools 2014-12-09 05:45:01 -05:00
TingPing
fda692d250 Fix various unsafe string handling in fkeys
Also removes the 2048 input byte limit
And fixes utf8 completion chars in some cases
2014-12-09 05:30:35 -05:00
Arnavion
99a1fff590 Removed unused hexchat_filename_*_utf8 macros. 2014-12-08 21:30:02 -08:00
Arnavion
65c8494698 Removed some unnecessary casts. 2014-12-08 21:25:00 -08:00
Arnavion
2b94011fdc Removed some commented-out code. 2014-12-08 21:25:00 -08:00
Arnavion
2da5308fd2 Fixed leak of filename string. 2014-12-08 21:25:00 -08:00
Arnavion
c1831cb19d Minor tidying up 2014-12-08 21:24:59 -08:00
Arnavion
65da34f19e Removed some unnecessary null-checks for calls to g_free and g_strfreev 2014-12-08 21:24:59 -08:00
Arnavion
b7afcc3632 Don't leak filename_fs on errors. 2014-12-08 21:24:58 -08:00
Arnavion
5152040c17 Always use 64-bit filesize and file offsets in DCC.
Based on LRN's commit for replacing stat with GFileInfo https://github.com/hexchat/hexchat/commit/32008bb

Fixes #382
2014-12-06 14:02:45 -08:00
Arnavion
985ea610e6 Store timer hook's timeout as milliseconds. 2014-12-04 04:06:38 -08:00
Arnavion
8062bce835 Fix some obvious type warnings. 2014-12-04 04:06:38 -08:00
TingPing
e38f00775f configure: Add option to run clang static analysis 2014-12-02 01:06:25 -05:00
TingPing
05a6097dc6 Fix copying timestamp with server-time and indent nicks off 2014-11-30 22:33:30 -05:00
TingPing
85557f2416 Fix duplicate timestamps on selection
Fixes #1226
2014-11-30 22:27:00 -05:00
tomek
0019af675a Fix compilation on Windows 2014-11-30 20:41:13 +01:00
TingPing
f03023297b Fix handling --cfgdir
Fixes #1225
2014-11-29 08:31:35 -05:00
TingPing
c92b247878 Fix building against openssl 0.9.8
Closes #1221
2014-11-26 08:15:34 -05:00
TingPing
c0769397d5 Fix possible crash in SASL Blowfish mech 2014-11-22 20:56:15 -05:00
TingPing
c9b63f7f9b ssl: Validate hostnames
Closes #524
2014-11-21 23:19:30 -05:00
TingPing
ebaaf466bf ssl: Use more secure options
This disables ssl 2/3
2014-11-05 02:17:34 -05:00
TingPing
4b6215051f ssl: Don't use global openssl context
Fixes #789
2014-11-05 01:27:39 -05:00
Campbell Barton
f83d78dd28 Warning cleanup
- ignoring const
- declarations after statements
- some C files didnt include own headers (risking them getting out of sync)

Closes #1064
2014-11-02 14:41:20 -05:00
TingPing
3c89de48a8 Remove old config migration
Fixes #1194
2014-10-25 06:50:02 -04:00
RichardHitt
6653582f0a Fix textbox not scrolling to to bottom on resize
Set buf->scrollbar_down conditionally when vertically resizing text window
If resize to enlarge appears to go to last line, set buf->scrollbar_down to be sure.

Fixes #1151
Closes #1171
2014-10-10 13:35:00 -04:00
TingPing
abaed2bda4 Fix parsing of MONITOR responses
Fixes #1157
2014-09-27 13:11:21 -04:00
TingPing
ce4e129849 Take two at fixing out of source builds 2014-09-21 03:53:30 -04:00
TingPing
ecd1aa226a Fix attempting to toggle visibility when tray disabled 2014-09-21 03:37:03 -04:00
TingPing
760d18b6e7 Fix missing header
And just use g_snprintf() while at it..
2014-09-20 14:09:38 -04:00
TingPing
f389257403 Increase max len of chiper names
For example ECDHE-ECRSA-AES256-GCM-SHA384
2014-09-20 13:56:09 -04:00
TingPing
84df81f336 Replace some unsafe usage of strncpy
Ensure everything is null terminated
2014-09-20 13:52:31 -04:00
Arnavion
a9a6cbda4e win32: Fixed build break due to 7a4a024 2014-09-17 13:00:11 -07:00
TingPing
7a4a0243bd Fix out of source builds
Fixes #1018
2014-09-14 17:43:44 -04:00
Arnavion
e209e55e59 Use PlaySoundW to play sounds on Windows.
Fixes #1133
2014-09-13 00:23:44 -07:00
Arnavion
ad2300f236 Correctly open URLs with non-ASCII characters on Windows.
Fixes #1023
2014-09-13 00:22:48 -07:00
TingPing
80bdd9ce11 Detect utf8 urls
They might not be valid, but like many things they are still used
2014-09-07 19:51:59 -04:00
TingPing
5f99d34c3b Fix opening utf8 urls on OSX
- Escape hostnames with punycode
- Use proper encoding when launching open
2014-09-07 19:45:44 -04:00
TingPing
2aa3eb8cfb Escape values set via pluginpref
Fixes #790
2014-09-01 18:17:26 -04:00
LightningW
d1b9118056 Fix DOMAIN and EMAIL patterns.
Closes #1107
2014-09-01 17:55:22 -04:00
Farow
fd95c729d5 xtext: Add word and line selection modes
Similar to a GtkTextView if you double click you enter word selection mode
and if you triple click you enter line selection mode.
Allowing you to drag and select more than a single character.

Closes #1108
2014-09-01 17:53:03 -04:00
TingPing
d1c40196e3 Fix using negative index 2014-08-23 14:13:34 -04:00
TingPing
9716185edf Use glib to get portable mode dir
This should fix any non-ascii paths
2014-08-23 12:45:02 -04:00
Arnavion
a38892ff3b Use GFile API in gtkutil_check_file instead of stat/access.
The latter functions expect codepage-encoded filenames on Windows but GLib's API returns filesystem-encoded paths, which on Windows are UTF-8. GLib API should be used to deal with GLib API results.

Also fixed leaks in two of the callers of gtkutil_check_file()

Fixes #968
2014-08-20 12:50:08 -07:00
TingPing
a854234c1f Fix warning 2014-07-28 16:18:27 -04:00
Arnavion
7c2c8b1403 Fixed expand_homedir to handle paths like "~user" correctly. 2014-07-28 14:49:14 -04:00
TingPing
c2ecb4c68c Fix various crashes with pluginpref 2014-07-28 14:47:19 -04:00
siniStar7boy
ea9dafcd43 Add GeeksIRC and IRC4Fun to network list
Closes #1057
Closes #1058
2014-07-21 15:37:03 -04:00
RichardHitt
7a7b9c682d Fix apostrophe related spell check issues 2014-07-21 15:10:21 -04:00
RichardHitt
0d3706e2ee Fix possible crash in spell check
Closes #1048
2014-07-19 15:51:06 -04:00
TingPing
121cb8b88d Fix formatting warnings
Found by #1059
2014-07-18 07:16:43 -04:00
Campbell Barton
93caf4c7b4 Use GNUC format attribute on print functions
Closes #1059
2014-07-18 07:09:07 -04:00
TingPing
f1e853c1cb Disable tray support on Elementary
They followed Ubuntu in breaking any gtk trays..
2014-07-05 13:08:48 -04:00
laurinkus
3de79bca10 Update server list
Closes #1013
2014-06-27 19:19:13 -04:00
TingPing
c3c6b46230 Clean up includes for gettext
It is always enabled.
2014-06-21 23:10:18 -04:00
TingPing
47b4b0da8a Remove unused defines 2014-06-21 22:45:21 -04:00
TingPing
45526205ab Remove broken debug code 2014-06-21 22:21:12 -04:00
TingPing
3342af4185 Make plugin-timer translatable 2014-06-21 22:11:37 -04:00
RichardHitt
7374637d34 Some problems in banlist.c are fixed 2014-06-17 17:16:45 -07:00
Berke Viktor
73c914cca9 Enable logging by default 2014-06-13 18:21:41 +02:00
TingPing
77d9d421fb Partial fix for out of source builds
Patch from LRN

Perl's makefile needs fixed and the relative include
of config.h needs removed from hexchat.h

Mentioned in #1018
2014-06-09 13:54:16 -04:00
TingPing
59f3a65911 Fix sending notify list to correct networks
Fixes #1015
2014-06-08 01:41:50 -04:00
TingPing
9181ea068a Fix dcc dir warning showing when not auto-accept 2014-06-04 20:55:34 -04:00
TingPing
3cd8556c54 Use GDir instead of dirent 2014-06-04 13:56:33 -04:00
TingPing
9c981cfc6b Fix warning 2014-06-04 13:47:09 -04:00
TingPing
11e3ecc739 Stop hardcoding plugin extensions everywhere 2014-06-04 11:15:35 -04:00
TingPing
5849a0588e Use glib to parse and launch commands for util_exec
Fixes #958
2014-06-04 10:38:23 -04:00
TingPing
b8c02f71d9 win32: Use config.h instead of config-win32.h 2014-06-04 10:30:18 -04:00
TingPing
806b98dfc2 Update server list
Removed any server that could not be connected to atm

Closes #666
2014-06-03 17:20:01 -04:00
TingPing
518669de80 Remove random ifndef WIN32
I never found a reason for it existing, but it also never affected much anyway.
2014-06-03 10:02:19 -04:00
TingPing
8538dd1a49 win32: Don't auto-generate version.txt 2014-06-03 09:43:14 -04:00
TingPing
a918ec2236 Fix scrolling the chanview on Unix
Fixes #948
2014-06-03 08:39:37 -04:00
TingPing
8578a9d52d Always use GModule for plugin support
Also cleans up some dead code
2014-06-02 05:38:13 -04:00
TingPing
6187b35fa6 Remove dead network 2014-06-01 11:52:09 -04:00
TingPing
9344373e0b Sensitize open dialog button in friends list when selected
Fixes #1001
2014-05-31 14:18:48 -04:00
Lee Watson
3d1d9e1716 Add SeionIRC to serverlist
Closes #982
2014-05-31 13:29:45 -04:00
Yoeri Beumer
e18a086ccf Add StormBit to network list
Closes #873
2014-05-31 13:29:19 -04:00
RichardHitt
5706550cc1 Rework gtk_xtext_selection_draw(), simplify calls to _selection_render()
Fixes #992.
2014-05-31 02:40:28 -07:00
TingPing
e13e0f4314 win32: Fix exiting fullscreen to a maximized window 2014-05-30 04:26:34 -04:00
Berke Viktor
31843017d4 Make lawyers happy 2014-05-29 18:04:28 +02:00
TingPing
637c153de3 Use newer format for default keybindings
This uses the proper bindings on OS X
2014-05-28 01:39:45 -04:00
TingPing
0f6434986f osx: Properly handle quitting 2014-05-27 03:07:03 -04:00
TingPing
f43b7524e0 osx: Properly use app menu
Mentioned in #994
2014-05-27 02:58:44 -04:00
TingPing
4320d88b90 Fix crash with invalid dnd to userlist 2014-05-26 05:11:47 -04:00
TingPing
30de7a1377 Update default settings
- Enable server-time
- Disable tree dots
2014-05-23 18:57:44 -04:00
TingPing
011514e1ad Enable drag and drop on Windows
The issues around it no longer seem to exist in current GTK
2014-05-23 18:47:27 -04:00
RichardHitt
6fb8cf40e1 Fixes #959. In xtext.c:find_x() return offset to hidden text if appropriate. 2014-05-22 07:06:51 -07:00
TingPing
015cecf724 Fix drag and drop 2014-05-21 10:18:37 -04:00
TingPing
904493b24f Show notifications for private actions
Fixes #990
2014-05-20 22:03:45 -04:00
TingPing
95f9ca917e Default completion to last spoke 2014-05-12 05:10:26 -04:00
Berke Viktor
0dccf692d4 Add global option to suppress nick change events
Might as well add a per-channel option, too but for me that seems a bit unnecessary.
Closes #971
2014-05-12 05:01:24 -04:00
Derp Derpingston
7435572282 Properly support notices to prefix'd users on a channel
Instead of hardcoding this behavior for @, +, and %, fetch the list of
mode prefixes from the server's state and look for one of those instead.

Closes #977
2014-05-12 04:55:45 -04:00
Derp Derpingston
17671ec694 Fixed truncation of the reason when receiving a KILL message.
The KILL handler thought the message started one word later than it did, and
would cut off the first word.  This change starts the reason in the correct
place, and shaves off a leading : if one is present.

Closes #977
Closes #774
2014-05-12 04:52:42 -04:00
cortexcorepl
187c04f7e2 Add missing NULL check in cmd_lastlog
Closes #961
2014-05-12 02:33:02 -04:00
TheTechman
5af678d2b9 Default Techman's World IRC to SASL
Closes #963
2014-05-12 02:30:27 -04:00
TingPing
1265eee9e5 Fix spell check on OSX 2014-05-11 06:46:12 -04:00
Riamse
e5f7441bae Fix sorting problem when using tabs
Fixes #949
2014-05-11 05:02:20 -04:00
Riamse
6ef41f7d4f Fix logging incorrect timestamp with server-time
Fixes #972
2014-05-11 05:02:19 -04:00
TingPing
fea144dd19 Add option to bounce dock icon on OSX 2014-05-11 04:50:35 -04:00
TingPing
fea528c39d Don't ignore command key in keybindings on OSX 2014-05-11 04:48:44 -04:00
TingPing
9599c29c46 Use filesize format based on OS
Adds gui_filesize_iec option on Unix

Closes #966
2014-05-03 23:57:45 -04:00
TingPing
fe71af15a7 Fix warning 2014-04-29 22:59:04 -04:00
Berke Viktor
b049757302 Replace deprecated GetVersionEx calls with version helpers
Only compiles with 8.1 SDK but runs everywhere

Closes #957
2014-04-24 06:55:16 -04:00
Arnavion
5fee31b1f0 Use the right API to get the path to Roaming AppData and Downloads directories, and actually convert it to utf-8 instead of using it directly. 2014-04-21 09:58:04 -07:00
Arnavion
e4413e0178 Don't convert the result of g_get_user_name / g_get_real_name from locale to utf-8 on Windows. They return utf-8 already. 2014-04-21 09:16:13 -07:00
Arnavion
dc27640265 Use utf-8 variant of strftime to format log file paths.
strftime assumes the format string is in locale encoding, which mangles log file paths that are in utf-8.

Fixes #767
Fixes #945
2014-04-21 01:39:28 -07:00
TingPing
41c209bf45 Reset all nick entry errors in servlist when fixed 2014-04-19 22:52:30 -04:00
TingPing
8bdde3a2df Fix warnings like usual 2014-04-18 23:50:27 -04:00
TingPing
c8b3eef351 Improve displaying errors in servlist 2014-04-18 23:45:27 -04:00
TingPing
5f297950a2 Fix issues removing autojoin channels
- Makes remove case insensitive
- Fixes crashing when channel not found
2014-04-18 20:40:33 -04:00
RichardHitt
ccf49aa48d Fix #928. Fix memory leak, mea culpa. 2014-04-17 15:07:50 -07:00
RichardHitt
b66edd372e Fixes #928 again. In scrollback replay, skip every line that starts 0x0d. 2014-04-17 09:53:09 -07:00
TingPing
8a0f2b1d21 Use glib to format filesize in dccgui 2014-04-15 04:05:18 -04:00
TingPing
660b860ddd Fix whitespace... 2014-04-10 23:05:04 -04:00
TingPing
f27b2e82fa Add Xertion to network list
Closes #939
2014-04-10 22:59:04 -04:00
TingPing
b41bd594b0 Add account to Join event
Also reorganizes some logic. The account will usually be NULL unless
extended-join capability enabled.

Closes #934
2014-04-06 15:33:22 -04:00
RichardHitt
0f828dd74f Add marker-line functionality for scrollback, instant seek.
Fixes #662.
2014-04-02 16:14:45 -07:00