From 0b20df9ecf06319aca645876bdb6cdec78b340f2 Mon Sep 17 00:00:00 2001
From: Max Bruckner <max@maxbruckner.de>
Date: Fri, 3 Aug 2018 07:39:17 +0200
Subject: [PATCH] Replace strcpy with memcpy and remove magic numbers for
 string sizes

---
 cJSON.c | 26 ++++++++++++++++++--------
 1 file changed, 18 insertions(+), 8 deletions(-)

diff --git a/cJSON.c b/cJSON.c
index 412a250..0428451 100644
--- a/cJSON.c
+++ b/cJSON.c
@@ -836,12 +836,13 @@ static cJSON_bool print_string_ptr(const unsigned char * const input, printbuffe
     /* empty string */
     if (input == NULL)
     {
-        output = ensure(output_buffer, sizeof("\"\""));
+        const char quotes[] = "\"\"";
+        output = ensure(output_buffer, sizeof(quotes));
         if (output == NULL)
         {
             return false;
         }
-        strcpy((char*)output, "\"\"");
+        memcpy(output, quotes, sizeof(quotes));
 
         return true;
     }
@@ -1297,31 +1298,40 @@ static cJSON_bool print_value(const cJSON * const item, printbuffer * const outp
     switch ((item->type) & 0xFF)
     {
         case cJSON_NULL:
-            output = ensure(output_buffer, 5);
+        {
+            const char null_string[] = "null";
+            output = ensure(output_buffer, sizeof(null_string));
             if (output == NULL)
             {
                 return false;
             }
-            strcpy((char*)output, "null");
+            memcpy(output, null_string, sizeof(null_string));
             return true;
+        }
 
         case cJSON_False:
-            output = ensure(output_buffer, 6);
+        {
+            const char false_string[] = "false";
+            output = ensure(output_buffer, sizeof(false_string));
             if (output == NULL)
             {
                 return false;
             }
-            strcpy((char*)output, "false");
+            memcpy(output, false_string, sizeof(false_string));
             return true;
+        }
 
         case cJSON_True:
-            output = ensure(output_buffer, 5);
+        {
+            const char true_string[] = "true";
+            output = ensure(output_buffer, sizeof(true_string));
             if (output == NULL)
             {
                 return false;
             }
-            strcpy((char*)output, "true");
+            memcpy(output, true_string, sizeof(true_string));
             return true;
+        }
 
         case cJSON_Number:
             return print_number(item, output_buffer);