From 5c402536fa7dfe6805ab1cb9e1cd96feaaf69c41 Mon Sep 17 00:00:00 2001 From: oga Date: Sun, 18 May 2008 19:38:18 +0000 Subject: [PATCH] group_ctx->name is only used in this one function, and for now it corresponds directly to the static list of group names. Just use the static list and stop strdup()ing a new version for the context struct. Since that never got freed this also fixes a small memleak. Kill some unused variables while i'm here. ok okan@ --- calmwm.h | 1 - group.c | 9 ++------- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/calmwm.h b/calmwm.h index 06ba4ba..4f67369 100644 --- a/calmwm.h +++ b/calmwm.h @@ -171,7 +171,6 @@ static char *shortcut_to_name[] = { struct group_ctx { TAILQ_ENTRY(group_ctx) entry; struct client_ctx_q clients; - char *name; int shortcut; int hidden; int nhidden; diff --git a/group.c b/group.c index 5d6175a..5fc01be 100644 --- a/group.c +++ b/group.c @@ -24,10 +24,8 @@ #define CALMWM_NGROUPS 9 -int Groupnamemode = 0; struct group_ctx *Group_active = NULL; struct group_ctx Groups[CALMWM_NGROUPS]; -char Group_name[256]; int Grouphideall = 0; struct group_ctx_q Groupq; @@ -266,16 +264,13 @@ group_menu(XButtonEvent *e) if (TAILQ_EMPTY(&gc->clients)) continue; - if (gc->name == NULL) - gc->name = xstrdup(shortcut_to_name[gc->shortcut]); - XCALLOC(mi, struct menu); if (gc->hidden) snprintf(mi->text, sizeof(mi->text), "%d: [%s]", - gc->shortcut, gc->name); + gc->shortcut, shortcut_to_name[gc->shortcut]); else snprintf(mi->text, sizeof(mi->text), "%d: %s", - gc->shortcut, gc->name); + gc->shortcut, shortcut_to_name[gc->shortcut]); mi->ctx = gc; TAILQ_INSERT_TAIL(&menuq, mi, entry); }