add, then use, xvasprintf, checking for appropriate return.

This commit is contained in:
okan 2020-01-22 19:58:35 +00:00
parent 2fc191f978
commit 83de84b7f8
3 changed files with 16 additions and 8 deletions

View File

@ -598,5 +598,7 @@ char *xstrdup(const char *);
int xasprintf(char **, const char *, ...) int xasprintf(char **, const char *, ...)
__attribute__((__format__ (printf, 2, 3))) __attribute__((__format__ (printf, 2, 3)))
__attribute__((__nonnull__ (2))); __attribute__((__nonnull__ (2)));
int xvasprintf(char **, const char *, va_list)
__attribute__((__nonnull__ (2)));
#endif /* _CALMWM_H_ */ #endif /* _CALMWM_H_ */

View File

@ -275,15 +275,12 @@ void
screen_prop_win_draw(struct screen_ctx *sc, const char *fmt, ...) screen_prop_win_draw(struct screen_ctx *sc, const char *fmt, ...)
{ {
va_list ap; va_list ap;
int i;
char *text; char *text;
XGlyphInfo extents; XGlyphInfo extents;
va_start(ap, fmt); va_start(ap, fmt);
i = vasprintf(&text, fmt, ap); xvasprintf(&text, fmt, ap);
va_end(ap); va_end(ap);
if (i < 0 || text == NULL)
err(1, "vasprintf");
XftTextExtentsUtf8(X_Dpy, sc->xftfont, (const FcChar8*)text, XftTextExtentsUtf8(X_Dpy, sc->xftfont, (const FcChar8*)text,
strlen(text), &extents); strlen(text), &extents);

View File

@ -91,11 +91,20 @@ xasprintf(char **ret, const char *fmt, ...)
int i; int i;
va_start(ap, fmt); va_start(ap, fmt);
i = vasprintf(ret, fmt, ap); i = xvasprintf(ret, fmt, ap);
va_end(ap); va_end(ap);
if (i < 0 || *ret == NULL) return(i);
err(1, "asprintf"); }
int
xvasprintf(char **ret, const char *fmt, va_list ap)
{
int i;
i = vasprintf(ret, fmt, ap);
if (i == -1)
err(1, "vasprintf");
return(i); return(i);
} }