* refs/heads/master:
Stop asking for events (NoEventMask) from menu window once done with the menu (we don't destroy it, only unmap).
Allow 'transientfor' clients to inherit group and bwidth either during init or via property notify events. Previously only the flags were set but nothing was in the path to apply said flags and/or bwidth. Required slight of re-orgnaization of client_init.
merge from base, from sashan@:
Use the original client border width to adjust initial placement of clients containing {P,US}Position requests where they are explicitly set to 'ignore' in cwmrc(5); clients are unaware that their border will be altered (removed in this case) when calcuating position and thus end up a factor of their original border width off once mapped by cwm(1). cwm(1) will essentially shift the client to the edge if the original request's position and border match.
> - odd condition/test in PF lexer
> (and other lexers too)
>
> This commit rectifies earlier change:
>
> in the lex... even inside quotes, a \ followed by space or tab should
> expand to space or tab, and a \ followed by newline should be ignored
> (as a line continuation). compatible with the needs of hoststated
> (which has the most strict quoted string requirements), and ifstated
> (where one commonly does line continuations in strings).
>
> OK deraadt@, OK millert@
* refs/heads/master:
Do not print any parse errors when ~/.cwmrc is missing. Regression introduced in revision 1.109 of calmwm.c.
Store the screen's visual type and colormap.
Consolidate region 'view' and 'area'.
limit scope of screen_apply_gap()
Clean up conf_file/homedir and conf_init() bits.
* refs/heads/master: (28 commits)
Use screen's saved view instead of re-querying the server.
Slightly expand and expose verbose debugging.
add debugging for x events
Add a simple debug logging mechanism.
Simplification; use asprintf where appropriate now.
Use func attributes where appropriate.
Fix wins comparison declaration since it's unsigned from XQueryTree().
Generate name_to_func[] in a clean and readable fashion.
Shrink tier[] by one after removing matchname in r1.55.
If the requested group number is invalid, bail but don't kill cwm.
Quick fix: exit after a failed execvp in u_spawn instead; previously we did in u_exec, but the introduction of re-exec'ing the previous invocation of cwm if 'exec_wm' failed missed the 'exec' failing path. Will likely split out as a proper fix.
Only exec the fallback when in CWM_EXEC_WM state.
Typo, from Julien Steinhauser.
Convert menu-exec-wm from an abritrary exec menu, into a config-based menu from which one may configure (wm <name> <path_and_args>) (and choose) specific window managers to replace the running one. 'wm cwm cwm' is included by default.
As done for buttonrelease, work specific un-cycling and un-highlighting actions into the keyrelease event, only performing what's actually needed for each; should result in much fewer events against keyreleases. No intended behaviour change.
Merge group_toggle_membership_leave into the buttonrelease event and only do border work for a group/ungroup action.
add helper function client_show to bring together like actions for unhide/raise
Add support for re-exec'ing with SIGHUP; equivalent to the already built-in 'restart' function.
Use poll and XNextEvent to replace XNextEvent blocking inside the x11 event handler.
zap stray that snuck in
...
which one may configure (wm <name> <path_and_args>) (and choose) specific
window managers to replace the running one. 'wm cwm cwm' is included by
default.
No objections and seems sensible to sthen.
* refs/heads/master:
drop obsolete comment
Alter callbacks to take a struct instead of a growing number of arguments; greatly simplifies upcoming work.
Ensure clients stay within the viewable bounds on placement, even with empty borders; based on a patch from Vadim Vygonets.
Clean up, unify and accurately calculate edge distance with client move/resize actions, so as to not lose windows off the edge.
Switch bwidth type; unfortunately X11 is inconsistent.
* refs/heads/master:
stray newlines
Add search_print_text(), a default callback for mi->print in menu_filter(). While here, normalize the remaining search_print_* argument paramters.
Consistent use of menuq_add for ssh menu.
Now that dim.{x,y} are available early, use them before requiring a MotionNotify event.
Set dim.{x,y} during client_init and update on resize, instead of (re)calculating only when applying hints.
'window-search' is spelled 'menu-window'; the former snuck in during the conversion('menu-window' already existed and was properlly documented); found the hard way by sthen@ while trying to convert.
Fold unbinding functions into one for each, key and mouse; plugs a leak when unbinding a mouse button bound to a command.
use the correct type
Tame the number of 'exec' and 'path' search_match wrappers. No functional change now, though more can likely go later, losing the (paritally complete or incomplete/broken) argument completion bits.
Switch ssh menu to search_match_text; like group/window/cmd menus, use only a substring match. The previous matching is only intended for the exec menus.
Change 'menu-window' to display all windows; then add 'menu-window-hidden' for the previous behaviour of 'menu-window'. 'menu-window' becomes the default binding; use 'bind-mouse "1" menu-window-hidden' to restore old behaviour for those who prefer.
Normalize bind function names, based on a few categories: window, group, menu and pointer.
Use an additional check with lstat(2) when d_type is unknown.
revert previous; upcoming changes will hopefully deal with these more naturally.
Add a wrapper based upon xevent handlers around client move/resize for key and mouse bindings.
Define callbacks, then default bindings.
Reorganize for upcoming changes.
Remove the (8) default bindings for pointer move since they conflict with default bindings for emacs, which wins; the feature remains and can be bound to whatever users wish with cwmrc(5).
and pointer.
Replace 'bind' and 'mousebind' options with 'bind-key' and 'bind-mouse',
respectively, replace special 'unmap' keyword with 'unbind-key' and
'unbind-mouse', and additionally allow unbinding all with 'all' keyword.
* refs/heads/master: (34 commits)
Make it clear these are flags.
Remove duplicate check that strsubmatch() already does; while here, fix a comment.
Sprinkle __func__ in appropriate error messages.
Get rid of 'matchname'; it's too surprising to have the menu change during client search as different potential str matches are cycled through. If there's interest, the only string that doesn't exist in the listing is the window's class - that can be added of course, but it makes the line too long imho.
clean up search_match_client(); no behaviour change
Refactor callbacks to take a void * so as to not try and generalize into client_ctx in keypress and buttonpress event handlers; pass appropriate *ctx's based on context.
remove another unused proto
Rename 2 kbfunc to match closer to what they do
Add an argument to the callbacks to pass the xevent context, button or key press. This allows to remove a few hacks to duplicate functions only for behaviour changes; now differing behaviours are pushed down to the callback. Also will allow for previously unavailable actions to be bind-able down the road.
Check the ptr bounds in the new client during cycling, since not all actions do ptrsave, such as restoring client geometry; adapted from a diff by Vadim Vygonets.
More accurate to say 'toggle', rather than 'select', for group[n]/nogroup.
Add CM-a for 'nogroup' (CM-0 stays for now); update manpage to reflect.
Stash wmname into conf.
When removing xrandr regions, ensure clients are within the bounds of the screen; adapted from an ancient diff from Sviatoslav Chagaev. Things in this area will likely change, but put this in so it works now and serves as a reminder.
Calculate client nameqlen in client_setname(), the only place it's needed/used.
Turn CALMWM_NGROUPS define into variable, ngroups.
Start simplifying menu code; and in turn, remove a cursor no longer needed.
Defaults are split between defines and conf_init(); normalize these, as well as give 'sticky' groups its own variable.
For both kb and mouse move, it is possible to grab a client and move it completely off the screen/region; instead, if the pointer is outside of the client bounds, warp the pointer to the closest edge before moving.
client_ptrwarp should not deal with unhiding or raising clients (non ptr requests); most callers do this already - deal with the few that do not. client_ptrwarp becomes a simple wrapper (setpos) but it will be expanded.
...
Don't allow embedded nul characters in strings.
Fixes a pfctl crash with an anchor name containing
an embedded nul found with the afl fuzzer.
pfctl parse.y patch from and ok deraadt@
config parse (and use conf_cmd_add to populate defaults); based on a
discussion with Tiago Cunha. While this looks ugly, there are likely
some other changes here to come.
- make conf_bind_kbd return error on non-matches to match what
conf_bind_mouse does.
- rename some variables while here for clarity.
- constify bind and cmd.
from Tiago Cunha.
ewmh hint; urgencyborder is configurable. The urgency flag will stick,
even while on a client in a non-viewable group, until the client
receives focus (where the border is reset). Initial diff from Thomas
Adam with some changes/enhancements from me.
This reverts commit 03b19f1487.
This merely generates pointer signedness warnings for strtonum() and
lookup() and problems with the const char * prototype of xstrdup().
