From aad45741631a2d7bc52e8d57c187e50c939c3d06 Mon Sep 17 00:00:00 2001 From: Emil Mikulic Date: Wed, 22 Aug 2018 01:14:17 +1000 Subject: [PATCH] Bounds check first. Found with: cppcheck --- darkhttpd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/darkhttpd.c b/darkhttpd.c index 1c5eff5..951d689 100644 --- a/darkhttpd.c +++ b/darkhttpd.c @@ -1575,7 +1575,7 @@ static void parse_range_field(struct connection *conn) { /* parse number up to hyphen */ bound1 = 0; for (bound2=0; - isdigit((int)range[bound2]) && (bound2 < len); + (bound2 < len) && isdigit((int)range[bound2]); bound2++) ; @@ -1590,7 +1590,7 @@ static void parse_range_field(struct connection *conn) { /* parse number after hyphen */ bound2++; for (bound1=bound2; - isdigit((int)range[bound2]) && (bound2 < len); + (bound2 < len) && isdigit((int)range[bound2]); bound2++) ;