From 1d1c74a74edcef60d909e28d735b720c7e406ee8 Mon Sep 17 00:00:00 2001 From: Niklas von Hertzen Date: Thu, 7 Dec 2017 17:30:13 +0800 Subject: [PATCH] Add Github issue templates --- .github/ISSUE_TEMPLATE.md | 19 ++++++++++++++++ .github/PULL_REQUEST_TEMPLATE.md | 37 ++++++++++++++++++++++++++++++++ .npmignore | 5 +++-- CHANGELOG.md | 4 +++- package.json | 2 +- 5 files changed, 63 insertions(+), 4 deletions(-) create mode 100644 .github/ISSUE_TEMPLATE.md create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md new file mode 100644 index 0000000..9749920 --- /dev/null +++ b/.github/ISSUE_TEMPLATE.md @@ -0,0 +1,19 @@ +Please make sure you are testing with the latest [release of html2canvas](https://github.com/niklasvh/html2canvas/releases). +Old versions are not supported and issues reported for them will be closed. + +# Please follow the general troubleshooting steps first: + +- [ ] You are using the latest [version](https://github.com/niklasvh/html2canvas/releases) +- [ ] You are testing using the non-minified version of html2canvas and checked any potential issues reported in the console + + + +### Bug reports: + +Please replace this line with a brief summary of your issue **AND** if possible an example on [jsfiddle](https://jsfiddle.net/). + +### Specifications: + + * html2canvas version tested with: + * Browser & version: + * Operating system: diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 0000000..1566fb8 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,37 @@ +A similar PR may already be submitted! +Please search among the [Pull request](https://github.com/niklasvh/html2canvas/pulls) before creating one. + +Thanks for submitting a pull request! Please provide enough information so that others can review your pull request: + +Before opening a pull request, please make sure all the tests pass locally by running `npm test`. + +**Summary** + + + +This PR fixes/implements the following **bugs/features** + +* [ ] Bug 1 +* [ ] Bug 2 +* [ ] Feature 1 +* [ ] Feature 2 +* [ ] Breaking changes + + + +Explain the **motivation** for making this change. What existing problem does the pull request solve? + + + +**Test plan (required)** + +Demonstrate how the issue/feature can be replicated. For most cases, simply adding an appropriate html/css template into the [reftests](https://github.com/niklasvh/html2canvas/tree/master/tests/reftests) should be sufficient. Please see other tests there for reference. + +**Code formatting** + +Please make sure that code adheres to the project code formatting. Running `npm run format` will automatically format your code correctly. + +**Closing issues** + + +Fixes # diff --git a/.npmignore b/.npmignore index 9d35537..c32fc8c 100644 --- a/.npmignore +++ b/.npmignore @@ -3,12 +3,13 @@ examples/ scripts/ src/ tests/ +.github/ *.iml .babelrc .idea/ .npmignore -.jshintrc +.eslintrc .travis.yml karma.js -karma.config.js +karma.conf.js webpack.config.js diff --git a/CHANGELOG.md b/CHANGELOG.md index 465cbbc..718dfe5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,8 @@ ### Changelog ### -#### v1.0.0-alpha2 - TBD #### +#### v1.0.0-alpha3 - TBD #### + +#### v1.0.0-alpha2 - 7.12.2017 #### * Fix scroll positions for CanvasRenderer (#1259) * Fix `data-html2canvas-ignore` attribute (#1253) * Fix decimal `letter-spacing` values (#1293) diff --git a/package.json b/package.json index 6a439d5..6a6d1ec 100644 --- a/package.json +++ b/package.json @@ -3,7 +3,7 @@ "name": "html2canvas", "description": "Screenshots with JavaScript", "main": "dist/npm/index.js", - "version": "1.0.0-alpha.2", + "version": "1.0.0-alpha.3", "author": { "name": "Niklas von Hertzen", "email": "niklasvh@gmail.com",