From b8371347b7269f6ddc328dcc89a2cf5ecd6c86de Mon Sep 17 00:00:00 2001 From: FoxxMD Date: Thu, 16 Mar 2023 15:21:02 -0400 Subject: [PATCH] Add configuration boolean for rendering album/artist icons If a user has a slow internet connection or is using a low-power device they may wish to not render icons at all to prevent additional cpu/network load. Defaults to `true` to preserve existing behavior. --- maloja/pkg_global/conf.py | 1 + maloja/web/jinja/snippets/entityrow.jinja | 6 +++++- settings.md | 1 + 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/maloja/pkg_global/conf.py b/maloja/pkg_global/conf.py index fa2e981..ea6a8c0 100644 --- a/maloja/pkg_global/conf.py +++ b/maloja/pkg_global/conf.py @@ -190,6 +190,7 @@ malojaconfig = Configuration( "default_range_charts_tracks":(tp.Choice({'alltime':'All Time','year':'Year','month':"Month",'week':'Week'}), "Default Range Track Charts", "year"), "default_step_pulse":(tp.Choice({'year':'Year','month':"Month",'week':'Week','day':'Day'}), "Default Pulse Step", "month"), "charts_display_tiles":(tp.Boolean(), "Display Chart Tiles", False), + "display_art_icons":(tp.Boolean(), "Display Album/Artist Icons", True), "discourage_cpu_heavy_stats":(tp.Boolean(), "Discourage CPU-heavy stats", False, "Prevent visitors from mindlessly clicking on CPU-heavy options. Does not actually disable them for malicious actors!"), "use_local_images":(tp.Boolean(), "Use Local Images", True), #"local_image_rotate":(tp.Integer(), "Local Image Rotate", 3600), diff --git a/maloja/web/jinja/snippets/entityrow.jinja b/maloja/web/jinja/snippets/entityrow.jinja index cabacb0..7601fea 100644 --- a/maloja/web/jinja/snippets/entityrow.jinja +++ b/maloja/web/jinja/snippets/entityrow.jinja @@ -8,7 +8,11 @@ {% set img = images.get_artist_image(entity) %} {% endif %} -
+ +{% if settings['DISPLAY_ART_ICONS'] %} +
+{% endif %} + {% if entity is mapping and 'artists' in entity %} {% if settings['TRACK_SEARCH_PROVIDER'] %} {{ links.link_search(entity) }} diff --git a/settings.md b/settings.md index 991377d..7ec74fc 100644 --- a/settings.md +++ b/settings.md @@ -51,6 +51,7 @@ Settings File | Environment Variable | Type | Description `default_range_charts_tracks` | `MALOJA_DEFAULT_RANGE_CHARTS_TRACKS` | Choice | Default Range Track Charts `default_step_pulse` | `MALOJA_DEFAULT_STEP_PULSE` | Choice | Default Pulse Step `charts_display_tiles` | `MALOJA_CHARTS_DISPLAY_TILES` | Boolean | Display Chart Tiles +`display_art_icons` | `MALOJA_DISPLAY_ART_ICONS` | Boolean | Display Album/Artist Icons `discourage_cpu_heavy_stats` | `MALOJA_DISCOURAGE_CPU_HEAVY_STATS` | Boolean | Prevent visitors from mindlessly clicking on CPU-heavy options. Does not actually disable them for malicious actors! `use_local_images` | `MALOJA_USE_LOCAL_IMAGES` | Boolean | Use Local Images `local_image_rotate` | `MALOJA_LOCAL_IMAGE_ROTATE` | Integer | Local Image Rotate