mirror/mpdevil
1
0
Fork 0
mirror of https://github.com/SoongNoonien/mpdevil.git synced 2023-08-10 21:12:44 +03:00
Code Issues Projects Releases Wiki Activity

small settings dialog code review

Browse Source
This commit is contained in:
Martin Wagner 2020-03-06 11:27:05 +01:00
parent f5b911f2cf
commit 67ec5ad695
1 changed files with 34 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

80
bin/mpdevil.py
View File

@ -1288,46 +1288,45 @@ class GeneralSettings(Gtk.Grid):
icon_size_combo.append_text(str(i)) icon_size_combo.append_text(str(i))
icon_size_combo.set_active(sizes.index(self.settings.get_int("icon-size"))) icon_size_combo.set_active(sizes.index(self.settings.get_int("icon-size")))
alt_layout=Gtk.CheckButton(label=_("Use alternative Layout")) #Store
alt_layout.set_active(self.settings.get_boolean("alt-layout")) #(toggle, display-text, key)
self.store = Gtk.ListStore(bool, str, str)
show_stop=Gtk.CheckButton(label=_("Show stop button")) #TreeView
show_stop.set_active(self.settings.get_boolean("show-stop")) self.treeview = Gtk.TreeView(model=self.store)
self.treeview.set_search_column(-1)
self.treeview.set_property("activate-on-single-click", True)
self.treeview.set_headers_visible(False)
show_genre_filter=Gtk.CheckButton(label=_("Show genre filter")) #selection
show_genre_filter.set_active(self.settings.get_boolean("show-genre-filter")) self.selection = self.treeview.get_selection()
self.selection.set_mode(Gtk.SelectionMode.NONE)
show_album_view_tooltips=Gtk.CheckButton(label=_("Show tooltips in album view")) #Column
show_album_view_tooltips.set_active(self.settings.get_boolean("show-album-view-tooltips")) renderer_text = Gtk.CellRendererText()
renderer_toggle = Gtk.CellRendererToggle()
sort_albums_by_year=Gtk.CheckButton(label=_("Sort albums by year")) column_toggle=Gtk.TreeViewColumn("", renderer_toggle, active=0)
sort_albums_by_year.set_active(self.settings.get_boolean("sort-albums-by-year")) self.treeview.append_column(column_toggle)
show_all_artists=Gtk.CheckButton(label=_("Show all artists")) column_text=Gtk.TreeViewColumn("", renderer_text, text=1)
show_all_artists.set_active(self.settings.get_boolean("show-all-artists")) self.treeview.append_column(column_text)
send_notify=Gtk.CheckButton(label=_("Send notification on title change")) #fill store
send_notify.set_active(self.settings.get_boolean("send-notify")) settings_list=[(_("Use alternative Layout"), "alt-layout"), (_("Show stop button"), "show-stop"), \
(_("Show genre filter"), "show-genre-filter"), (_("Show tooltips in album view"), "show-album-view-tooltips"), \
(_("Sort albums by year"), "sort-albums-by-year"), (_("Show all artists"), "show-all-artists"), \
(_("Send notification on title change"), "send-notify"), (_("Stop playback on quit"), "stop-on-quit"), \
(_("Play selected album after current title"), "add-album")]
stop_on_quit=Gtk.CheckButton(label=_("Stop playback on quit")) for data in settings_list:
stop_on_quit.set_active(self.settings.get_boolean("stop-on-quit")) self.store.append([self.settings.get_boolean(data[1]), data[0], data[1]])
add_album=Gtk.CheckButton(label=_("Play selected album after current title"))
add_album.set_active(self.settings.get_boolean("add-album"))
#connect #connect
track_cover_size.connect("value-changed", self.on_int_changed, "track-cover") track_cover_size.connect("value-changed", self.on_int_changed, "track-cover")
album_cover_size.connect("value-changed", self.on_int_changed, "album-cover") album_cover_size.connect("value-changed", self.on_int_changed, "album-cover")
icon_size_combo.connect("changed", self.on_icon_size_changed) icon_size_combo.connect("changed", self.on_icon_size_changed)
alt_layout.connect("toggled", self.on_toggled, "alt-layout") self.treeview.connect("row-activated", self.on_row_activated)
show_stop.connect("toggled", self.on_toggled, "show-stop")
show_genre_filter.connect("toggled", self.on_toggled, "show-genre-filter")
show_album_view_tooltips.connect("toggled", self.on_toggled, "show-album-view-tooltips")
sort_albums_by_year.connect("toggled", self.on_toggled, "sort-albums-by-year")
show_all_artists.connect("toggled", self.on_toggled, "show-all-artists")
send_notify.connect("toggled", self.on_toggled, "send-notify")
stop_on_quit.connect("toggled", self.on_toggled, "stop-on-quit")
add_album.connect("toggled", self.on_toggled, "add-album")
#packing #packing
self.add(track_cover_label) self.add(track_cover_label)
@ -1336,26 +1335,19 @@ class GeneralSettings(Gtk.Grid):
self.attach_next_to(track_cover_size, track_cover_label, Gtk.PositionType.RIGHT, 1, 1) self.attach_next_to(track_cover_size, track_cover_label, Gtk.PositionType.RIGHT, 1, 1)
self.attach_next_to(album_cover_size, album_cover_label, Gtk.PositionType.RIGHT, 1, 1) self.attach_next_to(album_cover_size, album_cover_label, Gtk.PositionType.RIGHT, 1, 1)
self.attach_next_to(icon_size_combo, icon_size_label, Gtk.PositionType.RIGHT, 1, 1) self.attach_next_to(icon_size_combo, icon_size_label, Gtk.PositionType.RIGHT, 1, 1)
self.attach_next_to(alt_layout, icon_size_label, Gtk.PositionType.BOTTOM, 2, 1) self.attach_next_to(self.treeview, icon_size_label, Gtk.PositionType.BOTTOM, 2, 2)
self.attach_next_to(show_stop, alt_layout, Gtk.PositionType.BOTTOM, 2, 1)
self.attach_next_to(show_genre_filter, show_stop, Gtk.PositionType.BOTTOM, 2, 1)
self.attach_next_to(show_album_view_tooltips, show_genre_filter, Gtk.PositionType.BOTTOM, 2, 1)
self.attach_next_to(sort_albums_by_year, show_album_view_tooltips, Gtk.PositionType.BOTTOM, 2, 1)
self.attach_next_to(show_all_artists, sort_albums_by_year, Gtk.PositionType.BOTTOM, 2, 1)
self.attach_next_to(send_notify, show_all_artists, Gtk.PositionType.BOTTOM, 2, 1)
self.attach_next_to(add_album, send_notify, Gtk.PositionType.BOTTOM, 2, 1)
self.attach_next_to(stop_on_quit, add_album, Gtk.PositionType.BOTTOM, 2, 1)
def on_int_changed(self, widget, key): def on_int_changed(self, widget, key):
self.settings.set_int(key, widget.get_int()) self.settings.set_int(key, widget.get_int())
def on_toggled(self, widget, key):
self.settings.set_boolean(key, widget.get_active())
def on_icon_size_changed(self, box): def on_icon_size_changed(self, box):
active_size=int(box.get_active_text()) active_size=int(box.get_active_text())
self.settings.set_int("icon-size", active_size) self.settings.set_int("icon-size", active_size)
def on_row_activated(self, widget, path, view_column): #TODO
self.store[path][0] = not self.store[path][0]
self.settings.set_boolean(self.store[path][2], self.store[path][0])
class PlaylistSettings(Gtk.Box): class PlaylistSettings(Gtk.Box):
def __init__(self, settings): def __init__(self, settings):
Gtk.Box.__init__(self, orientation=Gtk.Orientation.VERTICAL, spacing=4) Gtk.Box.__init__(self, orientation=Gtk.Orientation.VERTICAL, spacing=4)
@ -1375,17 +1367,11 @@ class PlaylistSettings(Gtk.Box):
#TreeView #TreeView
self.treeview = Gtk.TreeView(model=self.store) self.treeview = Gtk.TreeView(model=self.store)
self.treeview.set_search_column(-1) self.treeview.set_search_column(-1)
self.treeview.set_property("activate-on-single-click", True)
self.treeview.set_reorderable(True) self.treeview.set_reorderable(True)
#selection
self.selection = self.treeview.get_selection()
self.selection.set_mode(Gtk.SelectionMode.SINGLE)
#Column #Column
renderer_text = Gtk.CellRendererText() renderer_text = Gtk.CellRendererText()
renderer_toggle = Gtk.CellRendererToggle() renderer_toggle = Gtk.CellRendererToggle()
renderer_toggle.connect("toggled", self.on_cell_toggled)
column_toggle=Gtk.TreeViewColumn("", renderer_toggle, active=0) column_toggle=Gtk.TreeViewColumn("", renderer_toggle, active=0)
self.treeview.append_column(column_toggle) self.treeview.append_column(column_toggle)
@ -1393,6 +1379,7 @@ class PlaylistSettings(Gtk.Box):
column_text=Gtk.TreeViewColumn(_("Column"), renderer_text, text=1) column_text=Gtk.TreeViewColumn(_("Column"), renderer_text, text=1)
self.treeview.append_column(column_text) self.treeview.append_column(column_text)
#fill store
self.headers=[_("No"), _("Disc"), _("Title"), _("Artist"), _("Album"), _("Length"), _("Year"), _("Genre")] self.headers=[_("No"), _("Disc"), _("Title"), _("Artist"), _("Album"), _("Length"), _("Year"), _("Genre")]
visibilities=self.settings.get_value("column-visibilities").unpack() visibilities=self.settings.get_value("column-visibilities").unpack()
@ -1401,6 +1388,7 @@ class PlaylistSettings(Gtk.Box):
#connect #connect
self.store.connect("row-deleted", self.on_row_inserted) self.store.connect("row-deleted", self.on_row_inserted)
renderer_toggle.connect("toggled", self.on_cell_toggled)
#scroll #scroll
scroll=Gtk.ScrolledWindow() scroll=Gtk.ScrolledWindow()