mirror/mpdevil
1
0
Fork 0
mirror of https://github.com/SoongNoonien/mpdevil.git synced 2023-08-10 21:12:44 +03:00
Code Issues Projects Releases Wiki Activity

fixed unintended revealing of back_button in PlaylistWindow

Browse Source
This commit is contained in:
Martin Wagner 2022-10-22 12:31:27 +02:00
parent d745ba0981
commit 79183dc422
1 changed files with 15 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/mpdevil.py
View File

@ -2429,27 +2429,28 @@ class PlaylistWindow(Gtk.Overlay):
self.add_overlay(self._back_button_revealer) self.add_overlay(self._back_button_revealer)
def _on_show_hide_back_button(self, *args): def _on_show_hide_back_button(self, *args):
visible_range=self._treeview.get_visible_range() # not always accurate possibly due to a bug in Gtk def callback():
if visible_range is None or self._treeview.get_property("selected-path") is None: visible_range=self._treeview.get_visible_range() # not always accurate possibly due to a bug in Gtk
self._back_button_revealer.set_reveal_child(False) if visible_range is None or self._treeview.get_property("selected-path") is None:
else:
if visible_range[0] > self._treeview.get_property("selected-path"): # current song is above upper edge
self._back_button_icon.set_property("icon-name", "go-up-symbolic")
self._back_button_revealer.set_valign(Gtk.Align.START)
self._back_button_revealer.set_reveal_child(True)
elif self._treeview.get_property("selected-path") > visible_range[1]: # current song is below lower edge
self._back_button_icon.set_property("icon-name", "go-down-symbolic")
self._back_button_revealer.set_valign(Gtk.Align.END)
self._back_button_revealer.set_reveal_child(True)
else: # current song is visible
self._back_button_revealer.set_reveal_child(False) self._back_button_revealer.set_reveal_child(False)
else:
if visible_range[0] > self._treeview.get_property("selected-path"): # current song is above upper edge
self._back_button_icon.set_property("icon-name", "go-up-symbolic")
self._back_button_revealer.set_valign(Gtk.Align.START)
self._back_button_revealer.set_reveal_child(True)
elif self._treeview.get_property("selected-path") > visible_range[1]: # current song is below lower edge
self._back_button_icon.set_property("icon-name", "go-down-symbolic")
self._back_button_revealer.set_valign(Gtk.Align.END)
self._back_button_revealer.set_reveal_child(True)
else: # current song is visible
self._back_button_revealer.set_reveal_child(False)
GLib.idle_add(callback) # workaround for the Gtk bug from above
def _on_back_to_current_song_button_clicked(self, *args): def _on_back_to_current_song_button_clicked(self, *args):
self._treeview.set_cursor(Gtk.TreePath(len(self._treeview.get_model())), None, False) # unset cursor self._treeview.set_cursor(Gtk.TreePath(len(self._treeview.get_model())), None, False) # unset cursor
if self._treeview.get_property("selected-path") is not None: if self._treeview.get_property("selected-path") is not None:
self._treeview.get_selection().select_path(self._treeview.get_property("selected-path")) self._treeview.get_selection().select_path(self._treeview.get_property("selected-path"))
self._treeview.scroll_to_selected_title() self._treeview.scroll_to_selected_title()
self._back_button_revealer.set_reveal_child(False) # workaround for Gtk bug in _on_show_hide_back_button
#################### ####################
# cover and lyrics # # cover and lyrics #