version 1.5.3

Merge pull request #312 from garoevans/patch-1
Fix check against $matches
2023-08-10 21:13:06 +03:00 · 2015-04-29 23:22:24 +03:00 · 2015-04-24 08:24:06 +03:00 · 2015-04-24 01:44:07 +03:00 · 2015-04-20 16:24:11 +01:00 · 2015-03-18 20:44:57 +02:00
7 changed files with 28 additions and 10 deletions
--- a/.travis.yml
+++ b/.travis.yml
@ -1,10 +1,16 @@
 language: php

 php:
+  - 7.0
  - 5.6
  - 5.5
  - 5.4
  - 5.3
-  - 5.2
  - hhvm
+  - hhvm-nightly

+matrix:
+  fast_finish: true
+  allow_failures:
+    - php: 7.0
+    - php: hhvm-nightly
--- a/Parsedown.php
+++ b/Parsedown.php
@ -17,7 +17,7 @@ class Parsedown
 {
    # ~

-    const version = '1.5.1';
+    const version = '1.5.3';

    # ~

@ -1197,7 +1197,7 @@ class Parsedown
            return;
        }

-        if (preg_match('/^[(]((?:[^ ()]|[(][^ )]+[)])+)(?:[ ]+("[^"]+"|\'[^\']+\'))?[)]/', $remainder, $matches))
+        if (preg_match('/^[(]((?:[^ ()]|[(][^ )]+[)])+)(?:[ ]+("[^"]*"|\'[^\']*\'))?[)]/', $remainder, $matches))
        {
            $Element['attributes']['href'] = $matches[1];

@ -1212,7 +1212,7 @@ class Parsedown
        {
            if (preg_match('/^\s*\[(.*?)\]/', $remainder, $matches))
            {
-                $definition = $matches[1] ? $matches[1] : $Element['text'];
+                $definition = strlen($matches[1]) ? $matches[1] : $Element['text'];
                $definition = strtolower($definition);

                $extent += strlen($matches[0]);
@ -1402,7 +1402,7 @@ class Parsedown

            if (isset($Element['handler']))
            {
-                $markup .= $this->$Element['handler']($Element['text']);
+                $markup .= $this->{$Element['handler']}($Element['text']);
            }
            else
            {
--- a/README.md
+++ b/README.md
@ -1,15 +1,18 @@
 ## Parsedown

+[![Build Status](https://img.shields.io/travis/erusev/parsedown/master.svg?style=flat-square)](https://travis-ci.org/erusev/parsedown)
+<!--[![Total Downloads](http://img.shields.io/packagist/dt/erusev/parsedown.svg?style=flat-square)](https://packagist.org/packages/erusev/parsedown)-->
+
 Better Markdown Parser in PHP

-[[ demo ]](http://parsedown.org/demo)
+[See Demo](http://parsedown.org/demo)

 ### Features

 * [Fast](http://parsedown.org/speed)
 * [Consistent](http://parsedown.org/consistency)
 * [GitHub flavored](https://help.github.com/articles/github-flavored-markdown)
-* [Tested](http://parsedown.org/tests/) in PHP 5.2, 5.3, 5.4, 5.5, 5.6 and [hhvm](http://www.hhvm.com/)
+* [Tested](http://parsedown.org/tests/) in PHP 5.3, 5.4, 5.5, 5.6 and [HHVM](http://www.hhvm.com/)
 * [Extensible](https://github.com/erusev/parsedown/wiki/Writing-Extensions)
 * [Markdown Extra extension](https://github.com/erusev/parsedown-extra)

--- a/test/data/image_title.html
+++ b/test/data/image_title.html
@ -1 +1,2 @@
 <p><img src="/md.png" alt="alt" title="title" /></p>
+<p><img src="/md.png" alt="blank title" title="" /></p>
--- a/test/data/image_title.md
+++ b/test/data/image_title.md
@ -1 +1,3 @@
 ![alt](/md.png "title")
+
+![blank title](/md.png "")
--- a/test/data/inline_link_title.html
+++ b/test/data/inline_link_title.html
@ -1,4 +1,6 @@
 <p><a href="http://example.com" title="Title">single quotes</a></p>
 <p><a href="http://example.com" title="Title">double quotes</a></p>
+<p><a href="http://example.com" title="">single quotes blank</a></p>
+<p><a href="http://example.com" title="">double quotes blank</a></p>
 <p><a href="http://example.com" title="2 Words">space</a></p>
 <p><a href="http://example.com/url-(parentheses)" title="Title">parentheses</a></p>
--- a/test/data/inline_link_title.md
+++ b/test/data/inline_link_title.md
@ -2,6 +2,10 @@

 [double quotes](http://example.com "Title")

+[single quotes blank](http://example.com '')
+
+[double quotes blank](http://example.com "")
+
 [space](http://example.com "2 Words")

 [parentheses](http://example.com/url-(parentheses) "Title")
Author	SHA1	Message	Date
Emanuil Rusev	b9e5228e92	version 1.5.3	2015-04-29 23:22:24 +03:00
Emanuil Rusev	31c8856f53	Merge pull request #312 from garoevans/patch-1 Fix check against $matches	2015-04-24 08:24:06 +03:00
Emanuil Rusev	d5823ad622	Merge pull request #295 from hkdobrev/nightly Test on nightly releases of PHP (7.0) and HHVM	2015-04-24 01:44:07 +03:00
Gareth Evans	6736ba9a04	Fix check against $matches Fixes inline reference links with int 0 as reference The link [link][0] where [0] is set at the bottom of the md file current breaks and it's truthy value is false.	2015-04-20 16:24:11 +01:00
Emanuil Rusev	468d1e3da8	improve readme	2015-03-18 20:44:57 +02:00
Emanuil Rusev	7aa1d97bba	improve readme	2015-03-18 20:43:30 +02:00
Emanuil Rusev	f768f9c63f	improve readme	2015-03-18 20:42:44 +02:00
Emanuil Rusev	aa83968534	improve readme	2015-03-18 20:41:23 +02:00
Emanuil Rusev	85eadccc05	Merge pull request #297 from hkdobrev/patch-1 Remove "tested in PHP 5.2"	2015-03-18 20:39:40 +02:00
Haralan Dobrev	c94fa12d67	Remove "tested on PHP 5.2" It is no longer tested on PHP 5.2 in Travis CI. See https://github.com/erusev/parsedown/pull/286	2015-03-18 17:15:00 +02:00
Emanuil Rusev	11e02d45fa	improve readme	2015-03-18 16:20:28 +02:00
Emanuil Rusev	ecd53f9add	improve readme	2015-03-18 16:16:51 +02:00
Emanuil Rusev	844b2f49ea	Merge pull request #249 from HelpingHand1/patch-1 Updated readme to display travis-ci.org build test	2015-03-18 16:08:13 +02:00
Haralan Dobrev	b2ad712644	Test on nightly releases of PHP (7.0) and HHVM See https://github.com/erusev/parsedown/issues/294 See `12bf1c6d05 (commitcomment-10090016)` Nightly releases are allowed to fail since they are not stable and could fail in unpredictable ways. New versions of PHP could be added as they are released. I think they should not be in the allowed to fail part of the matrix then.	2015-03-09 10:14:57 +02:00
Emanuil Rusev	65116c3cb0	Merge pull request #286 from henriquemoody/travis Remove PHP version 5.2 from Travis builds	2015-02-09 01:04:08 +02:00
Henrique Moody	147003107a	Remove PHP version 5.2 from Travis builds	2015-02-08 21:00:50 -02:00
Emanuil Rusev	618b26056c	Merge pull request #284 from jstanden/master Fixes #283	2015-02-04 00:39:05 +02:00
Jeff Standen	b828fe7c8d	Fixes #283	2015-02-03 13:58:47 -08:00
Emanuil Rusev	6c9df528aa	Merge pull request #280 from kelunik/master Fixes PHP 7 compatibility	2015-02-02 02:33:38 +02:00
Niklas Keller	cb8cc57742	Fixes #279	2015-02-02 00:58:24 +01:00
HelpingHand1	4b7d7cdef2	updated readme.md per comment by cebe	2014-12-13 13:01:40 -05:00
HelpingHand1	97e667ab30	Updated readme to display travis-ci.org build test	2014-12-10 18:13:48 -05:00