mirror/piskel
1
0
Fork 0
mirror of https://github.com/piskelapp/piskel.git synced 2023-08-10 21:12:52 +03:00
Code Issues Projects Releases Wiki Activity

Enhancement : performance : event delegation for previewfilmcontroller

Browse Source
This commit is contained in:
jdescottes 2014-04-12 14:15:45 +02:00
parent b217f8f005
commit 23f1e8908e
1 changed files with 11 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
src/js/controller/PreviewFilmController.js
View File

@ -71,9 +71,10 @@
return; return;
} }
var action = target.dataset.tileAction; var action = target.dataset.tileAction;
var index = target.dataset.tileNumber; var index = parseInt(target.dataset.tileNumber, 10);
if (action === ACTION.CLONE) { if (action === ACTION.CLONE) {
this.piskelController.duplicateFrameAt(index);
this.piskelController.setCurrentFrameIndex(index + 1); this.piskelController.setCurrentFrameIndex(index + 1);
this.updateScrollerOverflows(); this.updateScrollerOverflows();
} else if (action === ACTION.DELETE) { } else if (action === ACTION.DELETE) {
@ -148,17 +149,16 @@
var currentFrame = this.piskelController.getCurrentLayer().getFrameAt(tileNumber); var currentFrame = this.piskelController.getCurrentLayer().getFrameAt(tileNumber);
var previewTileRoot = document.createElement("li"); var previewTileRoot = document.createElement("li");
var classname = "preview-tile";
previewTileRoot.setAttribute("data-tile-number", tileNumber); previewTileRoot.setAttribute("data-tile-number", tileNumber);
previewTileRoot.setAttribute('data-tile-action', ACTION.SELECT); previewTileRoot.setAttribute('data-tile-action', ACTION.SELECT);
previewTileRoot.classList.add("preview-tile");
if (this.piskelController.getCurrentFrame() == currentFrame) { if (this.piskelController.getCurrentFrame() == currentFrame) {
classname += " selected"; previewTileRoot.classList.add("selected");
} }
previewTileRoot.className = classname;
var canvasContainer = document.createElement("div"); var canvasContainer = document.createElement("div");
canvasContainer.className = "canvas-container"; canvasContainer.classList.add("canvas-container", pskl.UserSettings.get(pskl.UserSettings.CANVAS_BACKGROUND));
var canvasBackground = document.createElement("div"); var canvasBackground = document.createElement("div");
canvasBackground.className = "canvas-background"; canvasBackground.className = "canvas-background";
@ -173,16 +173,11 @@
cloneFrameButton.className = "tile-overlay duplicate-frame-action"; cloneFrameButton.className = "tile-overlay duplicate-frame-action";
previewTileRoot.appendChild(cloneFrameButton); previewTileRoot.appendChild(cloneFrameButton);
// TODO(vincz): Eventually optimize this part by not recreating a FrameRenderer. Note that the real optim var canvasRenderer = new pskl.rendering.CanvasRenderer(currentFrame, this.zoom);
// is to make this update function (#createPreviewTile) less aggressive. canvasRenderer.drawTransparentAs(Constants.TRANSPARENT_COLOR);
var renderingOptions = { var canvas = canvasRenderer.render();
"zoom" : this.zoom, canvas.classList.add('tile-view', 'canvas');
"height" : this.piskelController.getCurrentFrame().getHeight() * this.zoom, canvasContainer.appendChild(canvas);
"width" : this.piskelController.getCurrentFrame().getWidth() * this.zoom
};
var currentFrameRenderer = new pskl.rendering.frame.FrameRenderer($(canvasContainer), renderingOptions, ["tile-view"]);
currentFrameRenderer.render(currentFrame);
previewTileRoot.appendChild(canvasContainer); previewTileRoot.appendChild(canvasContainer);
if(tileNumber > 0 || this.piskelController.getFrameCount() > 1) { if(tileNumber > 0 || this.piskelController.getFrameCount() > 1) {