mirror of
https://github.com/piskelapp/piskel.git
synced 2023-08-10 21:12:52 +03:00
Clean grid code: semantic names and tiny refactor using UserSettings
This commit is contained in:
parent
2691b23c09
commit
9eac3414a3
|
@ -19,7 +19,7 @@
|
||||||
// TODO(vincz): Store user prefs in a localstorage string ?
|
// TODO(vincz): Store user prefs in a localstorage string ?
|
||||||
var renderingOptions = {
|
var renderingOptions = {
|
||||||
"dpi": this.calculateDPI_(),
|
"dpi": this.calculateDPI_(),
|
||||||
"hasGrid" : true
|
"supportGridRendering" : true
|
||||||
};
|
};
|
||||||
|
|
||||||
this.renderer = new pskl.rendering.FrameRenderer(this.container, renderingOptions, "drawing-canvas");
|
this.renderer = new pskl.rendering.FrameRenderer(this.container, renderingOptions, "drawing-canvas");
|
||||||
|
|
|
@ -2,27 +2,26 @@
|
||||||
var ns = $.namespace("pskl.rendering");
|
var ns = $.namespace("pskl.rendering");
|
||||||
|
|
||||||
ns.FrameRenderer = function (container, renderingOptions, className) {
|
ns.FrameRenderer = function (container, renderingOptions, className) {
|
||||||
|
|
||||||
this.defaultRenderingOptions = {
|
this.defaultRenderingOptions = {
|
||||||
"hasGrid" : false
|
'supportGridRendering' : false
|
||||||
};
|
};
|
||||||
renderingOptions = $.extend(true, {}, this.defaultRenderingOptions, renderingOptions);
|
renderingOptions = $.extend(true, {}, this.defaultRenderingOptions, renderingOptions);
|
||||||
|
|
||||||
if(container === undefined) {
|
if(container === undefined) {
|
||||||
throw "Bad FrameRenderer initialization. <container> undefined.";
|
throw 'Bad FrameRenderer initialization. <container> undefined.';
|
||||||
}
|
}
|
||||||
|
|
||||||
if(isNaN(renderingOptions.dpi)) {
|
if(isNaN(renderingOptions.dpi)) {
|
||||||
throw "Bad FrameRenderer initialization. <dpi> not well defined.";
|
throw 'Bad FrameRenderer initialization. <dpi> not well defined.';
|
||||||
}
|
}
|
||||||
|
|
||||||
this.container = container;
|
this.container = container;
|
||||||
this.dpi = renderingOptions.dpi;
|
this.dpi = renderingOptions.dpi;
|
||||||
this.className = className;
|
this.className = className;
|
||||||
this.canvas = null;
|
this.canvas = null;
|
||||||
this.hasGrid = renderingOptions.hasGrid;
|
this.supportGridRendering = renderingOptions.supportGridRendering;
|
||||||
|
|
||||||
this.gridStrokeWidth = pskl.UserSettings.get(pskl.UserSettings.SHOW_GRID) ? Constants.GRID_STROKE_WIDTH : 0;
|
this.enableGrid(pskl.UserSettings.get(pskl.UserSettings.SHOW_GRID));
|
||||||
|
|
||||||
// Flag to know if the config was altered
|
// Flag to know if the config was altered
|
||||||
this.canvasConfigDirty = true;
|
this.canvasConfigDirty = true;
|
||||||
|
@ -59,6 +58,8 @@
|
||||||
this.gridStrokeWidth = Constants.GRID_STROKE_WIDTH;
|
this.gridStrokeWidth = Constants.GRID_STROKE_WIDTH;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
ns.FrameRenderer.prototype.enableGrid = function (flag) {
|
||||||
|
this.gridStrokeWidth = (flag && this.supportGridRendering) ? Constants.GRID_STROKE_WIDTH : 0;
|
||||||
this.canvasConfigDirty = true;
|
this.canvasConfigDirty = true;
|
||||||
};
|
};
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue
Block a user