Clean KeyManager.js (private semantics)

This commit is contained in:
Vince 2012-09-16 13:11:10 +02:00
parent 7d529aeaaa
commit d6f1496763

View File

@ -5,17 +5,10 @@
$(document.body).keydown($.proxy(this.onKeyUp_, this)); $(document.body).keydown($.proxy(this.onKeyUp_, this));
}; };
// Kind of object that make you want to stop front-end _engineering_: /**
ns.KeyManager.prototype.CharCodeToKeyCodeMap = { * @private
*/
90 : "z", ns.KeyManager.prototype.KeyboardActions_ = {
89 : "y",
88 : "x",
67 : "c",
86 : "v"
};
ns.KeyManager.prototype.KeyboardActions = {
"ctrl" : { "ctrl" : {
"z" : Events.UNDO, "z" : Events.UNDO,
@ -26,8 +19,21 @@
} }
}; };
/**
* @private
*/
ns.KeyManager.prototype.CharCodeToKeyCodeMap_ = {
90 : "z",
89 : "y",
88 : "x",
67 : "c",
86 : "v"
};
/**
* @private
*/
ns.KeyManager.prototype.onKeyUp_ = function(evt) { ns.KeyManager.prototype.onKeyUp_ = function(evt) {
var isMac = false; var isMac = false;
if (navigator.appVersion.indexOf("Mac")!=-1) { if (navigator.appVersion.indexOf("Mac")!=-1) {
@ -37,9 +43,9 @@
if (isMac ? evt.metaKey : evt.ctrlKey) { if (isMac ? evt.metaKey : evt.ctrlKey) {
// Get key pressed: // Get key pressed:
var letter = this.CharCodeToKeyCodeMap[evt.which]; var letter = this.CharCodeToKeyCodeMap_[evt.which];
if(letter) { if(letter) {
var eventToTrigger = this.KeyboardActions.ctrl[letter]; var eventToTrigger = this.KeyboardActions_.ctrl[letter];
if(eventToTrigger) { if(eventToTrigger) {
$.publish(eventToTrigger); $.publish(eventToTrigger);
} }