Make jshint quiet now

This commit is contained in:
grosbouddha
2013-05-27 23:42:53 +02:00
parent 32d4f1c377
commit fba6693426
17 changed files with 506 additions and 502 deletions

View File

@@ -57,5 +57,5 @@
ns.AnimatedPreviewController.prototype.updateDPI_ = function () { ns.AnimatedPreviewController.prototype.updateDPI_ = function () {
this.dpi = this.calculateDPI_(); this.dpi = this.calculateDPI_();
this.renderer.updateDPI(this.dpi); this.renderer.updateDPI(this.dpi);
} };
})(); })();

View File

@@ -173,7 +173,7 @@
*/ */
ns.DrawingController.prototype.wrapEvtInfo_ = function (event) { ns.DrawingController.prototype.wrapEvtInfo_ = function (event) {
var evtInfo = {}; var evtInfo = {};
if (event.button == 0) { if (event.button === 0) {
evtInfo.button = Constants.LEFT_BUTTON; evtInfo.button = Constants.LEFT_BUTTON;
} else if (event.button == 2) { } else if (event.button == 2) {
evtInfo.button = Constants.RIGHT_BUTTON; evtInfo.button = Constants.RIGHT_BUTTON;

View File

@@ -53,7 +53,7 @@
} }
this.container.append(this.createInterstitialTile_(frameCount)); this.container.append(this.createInterstitialTile_(frameCount));
var needDragndropBehavior = !!(frameCount > 1); var needDragndropBehavior = (frameCount > 1) ? true : false;
if(needDragndropBehavior) { if(needDragndropBehavior) {
this.initDragndropBehavior_(); this.initDragndropBehavior_();
} }
@@ -64,7 +64,7 @@
*/ */
ns.PreviewFilmController.prototype.createInterstitialTile_ = function (tileNumber) { ns.PreviewFilmController.prototype.createInterstitialTile_ = function (tileNumber) {
var interstitialTile = document.createElement("div"); var interstitialTile = document.createElement("div");
interstitialTile.className = "interstitial-tile" interstitialTile.className = "interstitial-tile";
interstitialTile.setAttribute("data-tile-type", "interstitial"); interstitialTile.setAttribute("data-tile-type", "interstitial");
interstitialTile.setAttribute("data-inject-drop-tile-at", tileNumber); interstitialTile.setAttribute("data-inject-drop-tile-at", tileNumber);
@@ -206,7 +206,7 @@
canvasPreviewDeleteAction.setAttribute('rel', 'tooltip'); canvasPreviewDeleteAction.setAttribute('rel', 'tooltip');
canvasPreviewDeleteAction.setAttribute('data-placement', 'right'); canvasPreviewDeleteAction.setAttribute('data-placement', 'right');
canvasPreviewDeleteAction.setAttribute('title', 'Delete this frame'); canvasPreviewDeleteAction.setAttribute('title', 'Delete this frame');
canvasPreviewDeleteAction.className = "tile-action delete-frame-action" canvasPreviewDeleteAction.className = "tile-action delete-frame-action";
canvasPreviewDeleteAction.addEventListener('click', this.onDeleteButtonClick_.bind(this, tileNumber)); canvasPreviewDeleteAction.addEventListener('click', this.onDeleteButtonClick_.bind(this, tileNumber));
previewTileRoot.appendChild(canvasPreviewDeleteAction); previewTileRoot.appendChild(canvasPreviewDeleteAction);
actionContainer.appendChild(canvasPreviewDeleteAction); actionContainer.appendChild(canvasPreviewDeleteAction);

View File

@@ -7,7 +7,7 @@
var ns = $.namespace("pskl.drawingtools"); var ns = $.namespace("pskl.drawingtools");
ns.Move = function() { ns.Move = function() {
this.toolId = "tool-move" this.toolId = "tool-move";
this.helpText = "Move tool"; this.helpText = "Move tool";
// Stroke's first point coordinates (set in applyToolAt) // Stroke's first point coordinates (set in applyToolAt)
@@ -40,7 +40,7 @@
} else { } else {
color = Constants.TRANSPARENT_COLOR; color = Constants.TRANSPARENT_COLOR;
} }
frame.setPixel(col, row, color) frame.setPixel(col, row, color);
} }
} }
}; };

View File

@@ -5,7 +5,7 @@
this.toolId = "tool-vertical-mirror-pen"; this.toolId = "tool-vertical-mirror-pen";
this.helpText = "vertical mirror pen tool"; this.helpText = "vertical mirror pen tool";
this.swap = null this.swap = null;
this.mirroredPreviousCol = null; this.mirroredPreviousCol = null;
this.mirroredPreviousRow = null; this.mirroredPreviousRow = null;
}; };

View File

@@ -103,7 +103,7 @@
} else { } else {
color = Constants.TRANSPARENT_COLOR; color = Constants.TRANSPARENT_COLOR;
} }
overlayFrame.setPixel(col, row, color) overlayFrame.setPixel(col, row, color);
} }
} }
}; };

View File

@@ -45,7 +45,7 @@
* @override * @override
*/ */
ns.RectangleSelect.prototype.onSelectEnd_ = function (col, row, color, frame, overlay) { ns.RectangleSelect.prototype.onSelectEnd_ = function (col, row, color, frame, overlay) {
this.onSelect_(col, row, color, frame, overlay) this.onSelect_(col, row, color, frame, overlay);
}; };
})(); })();

View File

@@ -36,7 +36,7 @@
* Returns a copy of the pixels used by the frame * Returns a copy of the pixels used by the frame
*/ */
ns.Frame.prototype.getPixels = function () { ns.Frame.prototype.getPixels = function () {
return this.clonePixels_(this.pixels) return this.clonePixels_(this.pixels);
}; };
/** /**

View File

@@ -72,7 +72,7 @@
try { try {
this.load(JSON.parse(serialized)); this.load(JSON.parse(serialized));
} catch (e) { } catch (e) {
throw "Could not load serialized framesheet : " + e.message throw "Could not load serialized framesheet : " + e.message;
} }
}; };

View File

@@ -33,4 +33,4 @@
var height = this.frame.getHeight() * this.dpi; var height = this.frame.getHeight() * this.dpi;
return pskl.CanvasUtils.createCanvas(width, height); return pskl.CanvasUtils.createCanvas(width, height);
}; };
})() })();

View File

@@ -50,9 +50,12 @@
}; };
ns.DrawingLoop.prototype.getRequestAnimationFrameShim_ = function () { ns.DrawingLoop.prototype.getRequestAnimationFrameShim_ = function () {
var requestAnimationFrame = window.requestAnimationFrame || window.mozRequestAnimationFrame || var requestAnimationFrame = window.requestAnimationFrame ||
window.webkitRequestAnimationFrame || window.msRequestAnimationFrame || function (callback) {window.setTimeout(callback, 1000/60)}; window.mozRequestAnimationFrame ||
window.webkitRequestAnimationFrame ||
window.msRequestAnimationFrame ||
function (callback) { window.setTimeout(callback, 1000/60); };
return requestAnimationFrame; return requestAnimationFrame;
} };
})() })();

View File

@@ -8,7 +8,7 @@
}; };
renderingOptions = $.extend(true, {}, this.defaultRenderingOptions, renderingOptions); renderingOptions = $.extend(true, {}, this.defaultRenderingOptions, renderingOptions);
if(container == undefined) { if(container === undefined) {
throw "Bad FrameRenderer initialization. <container> undefined."; throw "Bad FrameRenderer initialization. <container> undefined.";
} }

View File

@@ -19,7 +19,7 @@
}; };
/** /**
* TODO : (Julz) Mutualize with code already present in FrameRenderer * TODO(juliandescottes): Mutualize with code already present in FrameRenderer
*/ */
ns.SpritesheetRenderer.prototype.drawFrameInCanvas_ = function (frame, canvas, offsetWidth, offsetHeight) { ns.SpritesheetRenderer.prototype.drawFrameInCanvas_ = function (frame, canvas, offsetWidth, offsetHeight) {
var context = canvas.getContext('2d'); var context = canvas.getContext('2d');
@@ -41,7 +41,7 @@
var height = this.framesheet.getHeight(); var height = this.framesheet.getHeight();
return pskl.CanvasUtils.createCanvas(width, height); return pskl.CanvasUtils.createCanvas(width, height);
} else { } else {
throw "Cannot render empty Spritesheet" throw "Cannot render empty Spritesheet";
} }
}; };

View File

@@ -17,7 +17,7 @@
movedPixel = this.pixels[i]; movedPixel = this.pixels[i];
movedPixel.col += colDiff; movedPixel.col += colDiff;
movedPixel.row += rowDiff; movedPixel.row += rowDiff;
movedPixels.push(movedPixel) movedPixels.push(movedPixel);
} }
this.pixels = movedPixels; this.pixels = movedPixels;
}; };

View File

@@ -101,8 +101,9 @@
var queue = []; var queue = [];
var dy = [-1, 0, 1, 0]; var dy = [-1, 0, 1, 0];
var dx = [0, 1, 0, -1]; var dx = [0, 1, 0, -1];
var targetColor;
try { try {
var targetColor = frame.getPixel(col, row); targetColor = frame.getPixel(col, row);
} catch(e) { } catch(e) {
// Frame out of bound exception. // Frame out of bound exception.
} }
@@ -123,8 +124,8 @@
paintedPixels.push({"col": currentItem.col, "row": currentItem.row }); paintedPixels.push({"col": currentItem.col, "row": currentItem.row });
for (var i = 0; i < 4; i++) { for (var i = 0; i < 4; i++) {
var nextCol = currentItem.col + dx[i] var nextCol = currentItem.col + dx[i];
var nextRow = currentItem.row + dy[i] var nextRow = currentItem.row + dy[i];
try { try {
if (frame.containsPixel(nextCol, nextRow) && frame.getPixel(nextCol, nextRow) == targetColor) { if (frame.containsPixel(nextCol, nextRow) && frame.getPixel(nextCol, nextRow) == targetColor) {
queue.push({"col": nextCol, "row": nextRow }); queue.push({"col": nextCol, "row": nextRow });
@@ -136,7 +137,7 @@
// Security loop breaker: // Security loop breaker:
if(loopCount > 10 * cellCount) { if(loopCount > 10 * cellCount) {
console.log("loop breaker called") console.log("loop breaker called");
break; break;
} }
} }