Commit Graph

360 Commits

Author SHA1 Message Date
jdescottes
cac1fa8ed5 UX : Primary/Secondary colors usability
- Added swap colors icon
- Created SVG icon, source is in resources (Inkscape)
2014-03-03 22:50:08 +01:00
jdescottes
5d4ba0b79f Added comment 2014-02-12 00:08:52 +01:00
jdescottes
aae994b3d5 Feature : Saved status and warning msg
Added saved status (*) next to title when a Piskel is updated.
Upon saving, the * disappears.

If the workspace contains an unsaved piskel when leaving the application a
message will be displayed to the user, using onbeforeunload.

This logic should also be used everywhere we display a confirm message
before a navigation.
2014-02-11 23:42:38 +01:00
jdescottes
bd0adda73f Various bug fixes
- Added missing files from previous commit
- Fixed move cursor that would remain after using a Selection tool
- Switched to mousedown for Tool Selection to avoid missed clicks
2014-02-11 22:04:44 +01:00
jdescottes
85084b8279 Added localstorage save + read 2014-02-10 01:00:16 +01:00
jdescottes
676bf1c7fd Fix : Settings drawer close usability bug
+ Settings drawer could not be closed when clicking above or below its
container. This has been fixed by changin the logic used for determining
if the click was inside/outside of the Settings drawer.

+ Added DOM utility to compensate for the limitations of JQuery
contains...
2014-02-09 21:49:08 +01:00
jdescottes
0dc5b2bc31 Merge branch 'feature-save-panel' into feature-resize-panel 2014-02-09 21:12:32 +01:00
jdescottes
a31e3570f3 Merge branch 'feature-save-panel' of https://github.com/juliandescottes/piskel into feature-save-panel 2014-02-09 21:10:09 +01:00
jdescottes
e8d96bf73f Fix : added missing Method on BaseSelect
- TODO : Review usage of hideHighlightedPixel in Tools
2014-02-09 20:56:45 +01:00
juliandescottes
9fc971f40b Added resize canvas panel 2013-12-24 12:57:03 +01:00
juliandescottes
fc19695a4a Misc : start frame index at 1 in PreviewFilm 2013-12-24 11:51:41 +01:00
juliandescottes
fbdf1aaf9a added loading over + fixed bug with highlighted pixel removal 2013-12-23 15:04:13 +01:00
jdescottes
f98c2d2cf5 Issue#148:JSError when deleting first frame + preview speed accuracy 2013-12-19 00:15:40 +01:00
jdescottes
4056142b97 Issue#145 : Hide highlighted pixel
+ BaseTool : added new method hideHighlightedPixel
+ DrawingController : mousemove event plugged on mousenter
  and unplugged on mouseleave
+ DrawingController : tool.hideHighlightPixel called on mouseleave and
  when switching the current tool to active (i.e. when user starts
  clicking)
2013-12-18 23:37:17 +01:00
jdescottes
e4cf2ac40b Merged 2013-12-18 23:22:25 +01:00
juliandescottes
b77f7057d7 save-panel : added piskel descriptor 2013-12-10 21:25:36 +01:00
jdescottes
b11b16b427 initial 2013-12-06 18:04:04 +01:00
jdescottes
e4c14e234e ok this one is chaos 2013-12-05 22:12:48 +01:00
jdescottes
167adaceb0 spectrum modification : add position information top container 2013-11-28 07:24:08 +01:00
jdescottes
8cf588b26d Design attempt 2013-11-27 23:46:07 +01:00
jdescottes
75dc1c5944 Design attempt 2013-11-27 23:43:59 +01:00
jdescottes
42862e188d Design attempt 2013-11-27 23:24:03 +01:00
jdescottes
c04a645991 Design attempt 2013-11-26 23:49:55 +01:00
jdescottes
5bbbdf64d9 Merge from master 2013-11-26 21:40:43 +01:00
jdescottes
569f42b7e2 Fix : fire resize event after loading piskel 2013-11-25 22:24:55 +01:00
grosbouddha
46b267c2a4 Merge pull request #143 from juliandescottes/add-keyboard-shortcuts
Add keyboard shortcuts
2013-11-24 06:23:47 -08:00
juliandescottes
11a3155e38 Merge branch 'master' into improve-color-selection-ux 2013-11-23 19:51:47 +01:00
juliandescottes
e852fb7c57 Merge with master after PR zoom-level 2013-11-23 19:50:53 +01:00
juliandescottes
3de3c3542e Post merge fixes 2013-11-23 19:33:00 +01:00
juliandescottes
ce111be5c8 Merging from master after PR zoom level 2013-11-23 19:25:51 +01:00
jdescottes
f26b1d4ebc improve : color picker : initial implementation using spectrum 2013-11-21 00:44:46 +01:00
jdescottes
2d3bbc73f1 Forgot to add duplicate frame shortcut to cheatsheet 2013-11-20 23:00:47 +01:00
jdescottes
0a05374af5 feature : add keyboard shortcuts
+ added shortcut to create new frames (n)
+ added shortcut to duplicate frame (shift+n)
2013-11-20 22:58:20 +01:00
jdescottes
6eabf01ffc feature : add keyboard shortcuts
+ decentralized shortcut declaration
+ each service/controller is now responsible for declaring its shorcuts
- documentation (cheatsheet) is still to be maintained manually
- init order matters (shortcutService has to be instanciated before
  everyone else) => should have a standalone KeyboardService singleton
  which is ready as soon as it is loaded
2013-11-19 23:46:33 +01:00
Julian Descottes
9d0f41362b Fix : typo 2013-11-19 08:15:37 +01:00
Julian Descottes
7d296f3dc3 Fix : add keyboard shortcuts : forgot misc keys 2013-11-19 08:13:16 +01:00
jdescottes
a0273edb3e feature : add keyboard shortcuts
+ cleanup of color management
+ colors are now stored in palette controller
+ drawing controller has a dependency on palette controller
+ UPDATE COLOR events have been removed (they were used only for
synchronizing palette and drawing controller)
2013-11-19 07:40:35 +01:00
jdescottes
e0b76f5329 feature : add keyboard shortcuts : added help panel displayed on shift+? 2013-11-18 23:53:12 +01:00
jdescottes
c033d65cde fix : tool icon not selected when using shortcut 2013-11-17 22:47:21 +01:00
jdescottes
f0ef016309 feature : add keyboard shortcuts : initial impl
+ added shortcuts for all tools in ToolController
+ modified structure of tools in Controller to Array of descriptors to
allow to declare shortcuts directly when setting up the tool controller
2013-11-17 22:07:26 +01:00
jdescottes
25e6470499 feature : add keyboard shortcuts : keycodes
+ moved keycode translation to KeycodeTranslator
+ made KeycodeTranslator more generic to handle 0-9 and a-z keys
+ small refactor in KeyboardEventService
2013-11-17 21:15:53 +01:00
jdescottes
5d83a39cf0 feature : add keyboard shortcuts : Events cleanup
+ Removed unused events
2013-11-17 20:20:27 +01:00
jdescottes
e68ae7f31d feature : zoom level : code review
+ Switched from BITWISE OR 0 (x | 0) to Math.floor for readability
2013-11-15 00:39:43 +01:00
jdescottes
3af64d3f45 feature : zoom level : code review
+ added explanatory comment for CanvasUtils.disableImageSmoothing
+ detect browser for chosing wheel/mousewheel event in DrawingController
+ create ABSTRACT_FUNCTION constant to be reused forabstract methods
2013-11-15 00:32:18 +01:00
jdescottes
86cd1cdeaa fix : reduce piskel model size
+ moved Serializer and Deserializer to utils.serialization package
+ put all backward code in utils.serialization.backward
+ added static method on Deserializer to make its usage similar to other
  utils in the package
- still not happy with the names used in Deserializer classes
  (deserializer.deserialize ...)
2013-11-15 00:03:05 +01:00
jdescottes
4a1a7b6c2b fix : reduce piskel model size : ImportController
+ ImportController is no longer relying on the deserializer to build a
  piskel instance
+ Static builders have been added to Piskel and Layer to help easily
  create new instances from existing elements
2013-11-14 23:03:29 +01:00
jdescottes
e9a2ccfd1d fix : reduce piskel model size : fix import feature 2013-11-13 23:51:27 +01:00
jdescottes
df4978f6af fix : reduce piskel model size
+ piskel deserialization is now clearly asynchronous
+ added utils.Deserializer (not a singleton though, more a builder/loader)
+ utils.Deserializer constructor expects a callback
+ when all layers are loaded and piskel is ready, the callback provided by
  the client is called with piskel as the first argument
- Deserializer doesn't fit in the utils package, which should be reserved
  to singletons : can move it to service as a PiskelLoaderService, and
  Deserializer could remain with only the purely static methods
- ImportController is realying on the Deserializer to build a Piskel but
  it shouldn't. Find a way to mutualize the code necessary to create a
  Piskel from an array of pskl.model.Frame
- still cleanup to do in app.js
- comments to add as well
2013-11-13 23:39:43 +01:00
jdescottes
781abb735b fix : reduce piskel model size
- added backward compatible implementation for v1 models
2013-11-13 22:57:07 +01:00
jdescottes
4f54715f70 fix : reduce piskel model size
- Initial implementation : working but ...
- MODEL_VERSION has been bumped to 2
- The loading process is now theoretically asynchronous (loading images to
  read the content of the layers), but for now, the asynchronous behaviour
  is hidden behind a nasty hack, which is somehow similar to lazy loading.
  When loading the piskel, a Piskel is created synchronously, with fake
  empty frames, and as the images will get loaded, the fake frames will be
  replaced by the actual frames.

  I really don't like this, and the asynchronous nature of the loading
  should be clearly expressed
- There is no backward compatible deserializer for the previous version of
  the model (1)
- The Serializer utils is just badly designed. Serialization and
  deserialization should be splitted into two different classes
- Saving & loading are still done in app.js and should be moved to
  services

BUT : the size of the piskels is now pretty small. A piskel which was
using 890kB previously is now using only 10kB. Although it should be
noted, that after gzip there is no significant difference between this
version and the existing one. The only gains we can really expect with
this are : less disk space used on appengine, ability to reuse the
layers' pngs directly on piskel-website (but to be honest I can't see any
valid use case for this)
2013-11-08 00:44:24 +01:00