2020-01-22 23:32:41 +03:00
|
|
|
|
|
|
|
|
|
|
|
<!--
|
2019-09-05 11:11:23 +03:00
|
|
|
|
2019-12-01 12:50:13 +03:00
|
|
|
Please title your PR as follows: `time: fix foo bar`.
|
|
|
|
Always start with the thing you are fixing, then describe the fix.
|
2019-06-26 16:54:58 +03:00
|
|
|
Don't use past tense (e.g. "fixed foo bar").
|
2019-06-26 14:42:56 +03:00
|
|
|
|
|
|
|
Explain what your PR does and why.
|
2019-06-26 14:39:38 +03:00
|
|
|
|
2019-06-29 17:50:13 +03:00
|
|
|
If you are adding a new function, please document it and add tests:
|
|
|
|
|
|
|
|
```
|
|
|
|
// foo does foo and bar
|
|
|
|
fn foo() {
|
|
|
|
|
|
|
|
// file_test.v
|
|
|
|
fn test_foo() {
|
|
|
|
assert foo() == ...
|
|
|
|
...
|
|
|
|
}
|
|
|
|
```
|
|
|
|
|
2019-09-29 04:28:57 +03:00
|
|
|
If you are fixing a bug, please add a test that covers it.
|
|
|
|
|
2019-12-01 12:50:13 +03:00
|
|
|
Before submitting a PR, please:
|
|
|
|
A) run the tests with `v test-compiler` .
|
|
|
|
B) make sure, that V can still compile itself:
|
|
|
|
```shell
|
2019-10-22 23:04:36 +03:00
|
|
|
./v -o v v.v
|
|
|
|
./v -o v v.v
|
2019-12-01 12:50:13 +03:00
|
|
|
```
|
2019-06-26 14:39:38 +03:00
|
|
|
|
2019-06-26 14:53:42 +03:00
|
|
|
I try to process PRs as soon as possible. They should be handled within 24 hours.
|
|
|
|
|
2019-06-26 17:43:12 +03:00
|
|
|
Applying labels to PRs is not needed.
|
|
|
|
|
2019-06-26 14:39:38 +03:00
|
|
|
Thanks a lot for your contribution!
|
2020-01-22 23:32:41 +03:00
|
|
|
|
|
|
|
->
|