1
0
mirror of https://github.com/vlang/v.git synced 2023-08-10 21:13:21 +03:00
v/.github/PULL_REQUEST_TEMPLATE

33 lines
812 B
Plaintext
Raw Normal View History

**Please delete this information after reading it.*
2019-06-26 14:53:42 +03:00
Please title your PR as follows: `time: fix foo bar`. Always start with the thing you are fixing, then describe the fix.
2019-06-26 16:54:58 +03:00
Don't use past tense (e.g. "fixed foo bar").
2019-06-26 14:42:56 +03:00
Explain what your PR does and why.
2019-06-26 14:39:38 +03:00
2019-06-29 17:50:13 +03:00
If you are adding a new function, please document it and add tests:
```
// foo does foo and bar
fn foo() {
// file_test.v
fn test_foo() {
assert foo() == ...
...
}
```
If you are fixing a bug, please add a test that covers it.
2019-06-26 14:42:56 +03:00
Before submitting a PR, please run the tests with `make test`, and make sure V can still compile itself. Run this twice:
2019-06-26 14:39:38 +03:00
./v -o v compiler
./v -o v compiler
2019-06-26 14:39:38 +03:00
2019-06-26 14:53:42 +03:00
I try to process PRs as soon as possible. They should be handled within 24 hours.
2019-06-26 17:43:12 +03:00
Applying labels to PRs is not needed.
2019-06-26 14:39:38 +03:00
Thanks a lot for your contribution!