mirror/v
1
0
Fork 0
mirror of https://github.com/vlang/v.git synced 2023-08-10 21:13:21 +03:00
Code Issues Projects Releases Wiki Activity

PR template: ask for fn docs and tests

Browse Source
This commit is contained in:
Alexander Medvednikov 2019-06-29 16:50:13 +02:00 committed by GitHub
parent 4b3b69ab15
commit 0bb3acef87
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
.github/PULL_REQUEST_TEMPLATE vendored
View File

@ -3,6 +3,19 @@ Don't use past tense (e.g. "fixed foo bar").
Explain what your PR does and why. Explain what your PR does and why.
If you are adding a new function, please document it and add tests:
```
// foo does foo and bar
fn foo() {
// file_test.v
fn test_foo() {
assert foo() == ...
...
}
```
Before submitting a PR, please run the tests with `make test`, and make sure V can still compile itself. Run this twice: Before submitting a PR, please run the tests with `make test`, and make sure V can still compile itself. Run this twice:
./v -o v ./v -o v