mirror of
https://github.com/vlang/v.git
synced 2023-08-10 21:13:21 +03:00
checker: check generic type indexing error (#10345)
This commit is contained in:
parent
665c386771
commit
103c777ad6
|
@ -6492,32 +6492,23 @@ fn (mut c Checker) check_index(typ_sym &ast.TypeSymbol, index ast.Expr, index_ty
|
||||||
|
|
||||||
pub fn (mut c Checker) index_expr(mut node ast.IndexExpr) ast.Type {
|
pub fn (mut c Checker) index_expr(mut node ast.IndexExpr) ast.Type {
|
||||||
mut typ := c.expr(node.left)
|
mut typ := c.expr(node.left)
|
||||||
mut typ_sym := c.table.get_final_type_symbol(typ)
|
typ_sym := c.table.get_final_type_symbol(typ)
|
||||||
node.left_type = typ
|
node.left_type = typ
|
||||||
for {
|
|
||||||
match typ_sym.kind {
|
match typ_sym.kind {
|
||||||
.map {
|
.map {
|
||||||
node.is_map = true
|
node.is_map = true
|
||||||
break
|
|
||||||
}
|
}
|
||||||
.array {
|
.array {
|
||||||
node.is_array = true
|
node.is_array = true
|
||||||
break
|
|
||||||
}
|
}
|
||||||
.array_fixed {
|
.array_fixed {
|
||||||
node.is_farray = true
|
node.is_farray = true
|
||||||
break
|
|
||||||
}
|
}
|
||||||
.any {
|
.any {
|
||||||
typ = c.unwrap_generic(typ)
|
c.error('generic type `$typ_sym.name` does not support indexing, please use compound type, e.g. `[]$typ_sym.name`',
|
||||||
node.left_type = typ
|
node.pos)
|
||||||
typ_sym = c.table.get_final_type_symbol(typ)
|
|
||||||
continue
|
|
||||||
}
|
|
||||||
else {
|
|
||||||
break
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
else {}
|
||||||
}
|
}
|
||||||
if typ_sym.kind !in [.array, .array_fixed, .string, .map] && !typ.is_ptr()
|
if typ_sym.kind !in [.array, .array_fixed, .string, .map] && !typ.is_ptr()
|
||||||
&& typ !in [ast.byteptr_type, ast.charptr_type] && !typ.has_flag(.variadic) {
|
&& typ !in [ast.byteptr_type, ast.charptr_type] && !typ.has_flag(.variadic) {
|
||||||
|
|
6
vlib/v/checker/tests/generics_type_para_index_err.out
Normal file
6
vlib/v/checker/tests/generics_type_para_index_err.out
Normal file
|
@ -0,0 +1,6 @@
|
||||||
|
vlib/v/checker/tests/generics_type_para_index_err.vv:2:24: error: generic type `T` does not support indexing, please use compound type, e.g. `[]T`
|
||||||
|
1 | fn show_element<T>(arr &T) string {
|
||||||
|
2 | return unsafe { '${arr[1]}' }
|
||||||
|
| ~~~
|
||||||
|
3 | }
|
||||||
|
4 |
|
|
@ -2,9 +2,8 @@ fn show_element<T>(arr &T) string {
|
||||||
return unsafe { '${arr[1]}' }
|
return unsafe { '${arr[1]}' }
|
||||||
}
|
}
|
||||||
|
|
||||||
fn test_generic_with_fixed_array_type() {
|
fn main() {
|
||||||
a := [1, 2, 3]!
|
a := [1, 2, 3]!
|
||||||
ret := show_element(a)
|
ret := show_element(a)
|
||||||
println(ret)
|
println(ret)
|
||||||
assert ret == '2'
|
|
||||||
}
|
}
|
Loading…
Reference in New Issue
Block a user