From 3af12271fb6808319b70ac5f096833b4262dc796 Mon Sep 17 00:00:00 2001
From: Subhomoy Haldar <hungrybluedev@gmail.com>
Date: Fri, 26 Aug 2022 09:39:48 +0530
Subject: [PATCH] log: add target_from_label and unit tests (#15538)

---
 vlib/log/log.v      | 12 +++++++++++-
 vlib/log/log_test.v | 30 ++++++++++++++++++++++++++++++
 2 files changed, 41 insertions(+), 1 deletion(-)

diff --git a/vlib/log/log.v b/vlib/log/log.v
index aafbdf0ee0..b2aba65734 100644
--- a/vlib/log/log.v
+++ b/vlib/log/log.v
@@ -48,7 +48,7 @@ fn tag_to_file(l Level) string {
 	}
 }
 
-// level_from_tag returns the log level from the given string if matches.
+// level_from_tag returns the log level from the given string if it matches.
 pub fn level_from_tag(tag string) ?Level {
 	return match tag {
 		'DISABLED' { Level.disabled }
@@ -61,6 +61,16 @@ pub fn level_from_tag(tag string) ?Level {
 	}
 }
 
+// target_from_label returns the log target from the given string if it matches.
+pub fn target_from_label(label string) ?LogTarget {
+	return match label {
+		'console' { LogTarget.console }
+		'file' { LogTarget.file }
+		'both' { LogTarget.both }
+		else { none }
+	}
+}
+
 // Logger is an interface that describes a generic Logger
 pub interface Logger {
 mut:
diff --git a/vlib/log/log_test.v b/vlib/log/log_test.v
index de1f345540..92160a64b1 100644
--- a/vlib/log/log_test.v
+++ b/vlib/log/log_test.v
@@ -80,3 +80,33 @@ fn test_logger_mutable_reference() {
 	assert true
 	println(@FN + ' end')
 }
+
+fn test_level_from_tag() ? {
+	assert level_from_tag('INFO')? == .info
+	assert level_from_tag('FATAL')? == .fatal
+	assert level_from_tag('WARN')? == .warn
+	assert level_from_tag('ERROR')? == .error
+	assert level_from_tag('DEBUG')? == .debug
+
+	invalid := ['', 'FOO', 'nope']
+
+	for value in invalid {
+		mut passed := false
+		level_from_tag(value) or { passed = true }
+		assert passed
+	}
+}
+
+fn test_target_from_label() ? {
+	assert target_from_label('console')? == .console
+	assert target_from_label('file')? == .file
+	assert target_from_label('both')? == .both
+
+	invalid := ['', 'FOO', 'nope']
+
+	for value in invalid {
+		mut passed := false
+		target_from_label(value) or { passed = true }
+		assert passed
+	}
+}