mirror/v
1
0
Fork 0
mirror of https://github.com/vlang/v.git synced 2023-08-10 21:13:21 +03:00
Code Issues Projects Releases Wiki Activity

checker: do not allow extra () in if conditions

Browse Source
This commit is contained in:
Alexander Medvednikov
2020-03-27 14:57:19 +01:00
parent 1a751208ca
commit 473d9fef55
11 changed files with 33 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
vlib/compiler/gen_c.v
View File

@ -64,10 +64,10 @@ fn (p mut Parser) gen_fn_decl(f Fn, typ, str_args string) {
// blank identifer assignment `_ = 111`
fn (p mut Parser) gen_blank_identifier_assign() {
assign_error_tok_idx := p.token_idx
//assign_error_tok_idx := p.token_idx
p.check_name()
p.check_space(.assign)
is_indexer := p.peek() == .lsbr
//is_indexer := p.peek() == .lsbr
is_fn_call,next_expr := p.is_expr_fn_call(p.token_idx)
pos := p.cgen.add_placeholder()
expr_tok := p.cur_tok_index()
@ -77,9 +77,9 @@ fn (p mut Parser) gen_blank_identifier_assign() {
p.error_with_token_index('${next_expr}() $err_used_as_value', expr_tok)
}
p.is_var_decl = false
if !is_indexer && !is_fn_call {
p.error_with_token_index('assigning `$next_expr` to `_` is redundant', assign_error_tok_idx)
}
//if !is_indexer && !is_fn_call {
//p.error_with_token_index('assigning `$next_expr` to `_` is redundant', assign_error_tok_idx)
//}
// handle or
if p.tok == .key_orelse {
p.gen_handle_option_or_else(typ, '', pos)

4
vlib/compiler/live.v
View File

@ -9,10 +9,10 @@ fn (v &V) generate_hotcode_reloading_compiler_flags() []string {
mut a := []string
if v.pref.is_live || v.pref.is_so {
// See 'man dlopen', and test running a GUI program compiled with -live
if (v.pref.os == .linux || os.user_os() == 'linux') {
if v.pref.os == .linux || os.user_os() == 'linux' {
a << '-rdynamic'
}
if (v.pref.os == .mac || os.user_os() == 'mac') {
if v.pref.os == .mac || os.user_os() == 'mac' {
a << '-flat_namespace'
}
}

2
vlib/compiler/table.v
View File

@ -388,7 +388,7 @@ fn (p &Parser) known_fn_in_mod(name string) bool {
existing_fn := p.table.find_fn(name) or {
return false
}
if (existing_fn.mod == p.mod || existing_fn.mod == 'builtin') {
if existing_fn.mod == p.mod || existing_fn.mod == 'builtin' {
return true
}
return false