mirror/v
1
0
Fork 0
mirror of https://github.com/vlang/v.git synced 2023-08-10 21:13:21 +03:00
Code Issues Projects Releases Wiki Activity

checker: fix references for alias type, that could still be uninitalized (fix #15935) (#15940)

Browse Source
This commit is contained in:
shove 2022-10-01 19:40:55 +08:00 committed by GitHub
parent 17b07273aa
commit 5dae5b2a92
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 35 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
vlib/v/checker/struct.v
View File

@ -522,6 +522,12 @@ pub fn (mut c Checker) struct_init(mut node ast.StructInit) ast.Type {
if sym.kind == .struct_ && !(sym.info as ast.Struct).is_typedef {
c.check_ref_fields_initialized(sym, mut checked_structs, '${type_sym.name}.$field.name',
node)
} else if sym.kind == .alias {
parent_sym := c.table.sym((sym.info as ast.Alias).parent_type)
if parent_sym.kind == .struct_ {
c.check_ref_fields_initialized(parent_sym, mut checked_structs,
'${type_sym.name}.$field.name', node)
}
}
// Do not allow empty uninitialized interfaces
mut has_noinit := false
@ -608,6 +614,13 @@ fn (mut c Checker) check_ref_fields_initialized(struct_sym &ast.TypeSymbol, mut
checked_structs << field.typ
c.check_ref_fields_initialized(sym, mut checked_structs, '${linked_name}.$field.name',
node)
} else if sym.kind == .alias {
parent_sym := c.table.sym((sym.info as ast.Alias).parent_type)
if parent_sym.kind == .struct_ {
checked_structs << field.typ
c.check_ref_fields_initialized(parent_sym, mut checked_structs, '${linked_name}.$field.name',
node)
}
}
}
}

29
vlib/v/checker/tests/struct_ref_fields_uninitialized_err.out
View File

@ -1,13 +1,20 @@
vlib/v/checker/tests/struct_ref_fields_uninitialized_err.vv:22:7: warning: reference field `Outer.c.b` must be initialized
20 |
21 | fn main() {
22 | _ := Outer{}
vlib/v/checker/tests/struct_ref_fields_uninitialized_err.vv:25:7: warning: reference field `Outer.c1.b` must be initialized
23 |
24 | fn main() {
25 | _ := Outer{}
| ~~~~~~~
23 | _ := Struct{}
24 | }
vlib/v/checker/tests/struct_ref_fields_uninitialized_err.vv:23:7: warning: reference field `Struct.ref2` must be initialized
21 | fn main() {
22 | _ := Outer{}
23 | _ := Struct{}
26 | _ := Struct{}
27 | }
vlib/v/checker/tests/struct_ref_fields_uninitialized_err.vv:25:7: warning: reference field `Outer.c2.b` must be initialized
23 |
24 | fn main() {
25 | _ := Outer{}
| ~~~~~~~
26 | _ := Struct{}
27 | }
vlib/v/checker/tests/struct_ref_fields_uninitialized_err.vv:26:7: warning: reference field `Struct.ref2` must be initialized
24 | fn main() {
25 | _ := Outer{}
26 | _ := Struct{}
| ~~~~~~~~
24 | }
27 | }

5
vlib/v/checker/tests/struct_ref_fields_uninitialized_err.vv
View File

@ -3,8 +3,11 @@ struct ContainsRef {
b &int
}
type TypeForContainsRef = ContainsRef
struct Outer {
c ContainsRef
c1 ContainsRef
c2 TypeForContainsRef
}
struct Ref {}