mirror/v
1
0
Fork 0
mirror of https://github.com/vlang/v.git synced 2023-08-10 21:13:21 +03:00
Code Issues Projects Releases Wiki Activity

parser: add a warning for only else branch in match (#8185)

Browse Source
This commit is contained in:
Swastik Baranwal
2021-01-18 22:01:36 +05:30
committed by GitHub
parent f375418847
commit 6f1ae65811
2 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
vlib/v/checker/tests/return_missing_match_simple.out
View File

@@ -1,3 +1,10 @@
vlib/v/checker/tests/return_missing_match_simple.vv:4:3: warning: `match` must have at least one non `else` branch
2 | a := 1
3 | match a {
4 | else { println('abc') }
| ~~~~
5 | }
6 | println('hello')
vlib/v/checker/tests/return_missing_match_simple.vv:1:1: error: missing return at end of function `h` vlib/v/checker/tests/return_missing_match_simple.vv:1:1: error: missing return at end of function `h`
1 | fn h() int { 1 | fn h() int {
| ~~~~~~~~~~ | ~~~~~~~~~~

3
vlib/v/parser/if_match.v
View File

@@ -247,6 +247,9 @@ fn (mut p Parser) match_expr() ast.MatchExpr {
post_comments: post_comments post_comments: post_comments
scope: branch_scope scope: branch_scope
} }
if is_else && branches.len == 1 {
p.warn_with_pos('`match` must have at least one non `else` branch', pos)
}
if p.tok.kind == .rcbr || (is_else && no_lcbr) { if p.tok.kind == .rcbr || (is_else && no_lcbr) {
break break
} }