mirror/v
1
0
Fork 0
mirror of https://github.com/vlang/v.git synced 2023-08-10 21:13:21 +03:00
Code Issues Projects Releases Wiki Activity

checker: add a check for str[i] = a (#6107)

Browse Source
This commit is contained in:
Swastik Baranwal 2020-08-11 21:11:54 +05:30 committed by GitHub
parent 99798b83b4
commit 9fdb1701e0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
vlib/v/checker/checker.v
View File

@ -3076,6 +3076,9 @@ pub fn (mut c Checker) index_expr(mut node ast.IndexExpr) table.Type {
typ_sym.name.ends_with('ptr')) && !typ.has_flag(.variadic) { // byteptr, charptr etc typ_sym.name.ends_with('ptr')) && !typ.has_flag(.variadic) { // byteptr, charptr etc
c.error('type `$typ_sym.name` does not support indexing', node.pos) c.error('type `$typ_sym.name` does not support indexing', node.pos)
} }
if typ_sym.kind == .string && !typ.is_ptr() && node.is_setter {
c.error('cannot assign to s[i] (strings are immutable)', node.pos)
}
if !c.inside_unsafe && (typ.is_ptr() || typ.is_pointer()) { if !c.inside_unsafe && (typ.is_ptr() || typ.is_pointer()) {
mut is_ok := false mut is_ok := false
if node.left is ast.Ident { if node.left is ast.Ident {

6
vlib/v/checker/tests/string_index_assign_error.out Normal file
View File

@ -0,0 +1,6 @@
vlib/v/checker/tests/string_index_assign_error.v:3:6: error: cannot assign to s[i] (strings are immutable)
1 | fn main() {
2 | mut a := 'V is great!!'
3 | a[0] = `R`
| ~~~
4 | }

4
vlib/v/checker/tests/string_index_assign_error.vv Normal file
View File

@ -0,0 +1,4 @@
fn main() {
mut a := 'V is great!!'
a[0] = `R`
}