1
0
mirror of https://github.com/vlang/v.git synced 2023-08-10 21:13:21 +03:00

parser: prevent too deep recursions in p.check_undefined_variables

This commit is contained in:
Delyan Angelov 2021-12-27 12:30:17 +02:00
parent 35418b8413
commit a2eb90ee4e
No known key found for this signature in database
GPG Key ID: 66886C0F12D595ED
4 changed files with 19 additions and 3 deletions

View File

@ -18,7 +18,16 @@ fn (mut p Parser) assign_stmt() ast.Stmt {
return p.partial_assign_stmt(exprs, comments)
}
const max_expr_level = 2500
fn (mut p Parser) check_undefined_variables(exprs []ast.Expr, val ast.Expr) ? {
p.expr_level++
defer {
p.expr_level--
}
if p.expr_level > parser.max_expr_level {
return error('expr level > $parser.max_expr_level')
}
match val {
ast.Ident {
for expr in exprs {
@ -138,9 +147,7 @@ fn (mut p Parser) partial_assign_stmt(left []ast.Expr, left_comments []ast.Comme
if op == .decl_assign {
// a, b := a + 1, b
for r in right {
p.check_undefined_variables(left, r) or {
return p.error('check_undefined_variables failed')
}
p.check_undefined_variables(left, r) or { return p.error_with_pos(err.msg, pos) }
}
} else if left.len > 1 {
// a, b = b, a

View File

@ -32,6 +32,7 @@ mut:
table &ast.Table
language ast.Language
fn_language ast.Language // .c for `fn C.abcd()` declarations
expr_level int // prevent too deep recursions for pathological programs
inside_vlib_file bool // true for all vlib/ files
inside_test_file bool // when inside _test.v or _test.vv file
inside_if bool

File diff suppressed because one or more lines are too long

File diff suppressed because one or more lines are too long