mirror/v
1
0
Fork 0
mirror of https://github.com/vlang/v.git synced 2023-08-10 21:13:21 +03:00
Code Issues Projects Releases Wiki Activity

net.http: make the errors that parse_status_line returns more informative to make diagnosing problems easier

Browse Source
This commit is contained in:
Delyan Angelov 2023-01-31 15:11:21 +02:00
parent 8009bc3a98
commit a932a8b1ea
No known key found for this signature in database
GPG Key ID: 66886C0F12D595ED
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
vlib/net/http/response.v
View File

@ -58,20 +58,22 @@ pub fn parse_response(resp string) !Response {
// version, status code, and reason phrase // version, status code, and reason phrase
fn parse_status_line(line string) !(string, int, string) { fn parse_status_line(line string) !(string, int, string) {
if line.len < 5 || line[..5].to_lower() != 'http/' { if line.len < 5 || line[..5].to_lower() != 'http/' {
return error('response does not start with HTTP/') return error('response does not start with HTTP/, line: `${line}`')
} }
data := line.split_nth(' ', 3) data := line.split_nth(' ', 3)
if data.len != 3 { if data.len != 3 {
return error('expected at least 3 tokens') return error('expected at least 3 tokens, but found: ${data.len}')
} }
version := data[0].substr(5, data[0].len) version := data[0].substr(5, data[0].len)
// validate version is 1*DIGIT "." 1*DIGIT // validate version is 1*DIGIT "." 1*DIGIT
digits := version.split_nth('.', 3) digits := version.split_nth('.', 3)
if digits.len != 2 { if digits.len != 2 {
return error('HTTP version malformed') return error('HTTP version malformed, found: `${digits}`')
} }
for digit in digits { for digit in digits {
strconv.atoi(digit) or { return error('HTTP version must contain only integers') } strconv.atoi(digit) or {
return error('HTTP version must contain only integers, found: `${digit}`')
}
} }
return version, strconv.atoi(data[1])!, data[2] return version, strconv.atoi(data[1])!, data[2]
} }