diff --git a/vlib/v/checker/check_types.v b/vlib/v/checker/check_types.v index b6877e90e6..fad58f7766 100644 --- a/vlib/v/checker/check_types.v +++ b/vlib/v/checker/check_types.v @@ -484,3 +484,75 @@ pub fn (mut c Checker) infer_fn_types(f table.Fn, mut call_expr ast.CallExpr) { } c.table.register_fn_gen_type(f.name, inferred_types) } + +// resolve_generic_type resolves generics to real types T => int. +// Even map[string]map[string]T can be resolved. +// This is used for resolving the generic return type of CallExpr white `unwrap_generic` is used to resolve generic usage in FnDecl. +fn (mut c Checker) resolve_generic_type(generic_type table.Type, generic_names []string, call_expr ast.CallExpr) ?table.Type { + mut sym := c.table.get_type_symbol(generic_type) + if sym.name in generic_names { + index := generic_names.index(sym.name) + mut typ := call_expr.generic_types[index] + typ = typ.set_nr_muls(generic_type.nr_muls()) + if generic_type.has_flag(.optional) { + typ = typ.set_flag(.optional) + } + return typ + } else if sym.kind == .array { + info := sym.info as table.Array + mut elem_type := info.elem_type + mut elem_sym := c.table.get_type_symbol(elem_type) + mut dims := 1 + for mut elem_sym.info is table.Array { + elem_type = elem_sym.info.elem_type + elem_sym = c.table.get_type_symbol(elem_type) + dims++ + } + if typ := c.resolve_generic_type(elem_type, generic_names, call_expr) { + idx := c.table.find_or_register_array_with_dims(typ, dims) + array_typ := table.new_type(idx) + return array_typ + } + } else if sym.kind == .chan { + info := sym.info as table.Chan + if typ := c.resolve_generic_type(info.elem_type, generic_names, call_expr) { + idx := c.table.find_or_register_chan(typ, typ.nr_muls() > 0) + chan_typ := table.new_type(idx) + return chan_typ + } + } else if mut sym.info is table.MultiReturn { + mut types := []table.Type{} + mut type_changed := false + for ret_type in sym.info.types { + if typ := c.resolve_generic_type(ret_type, generic_names, call_expr) { + types << typ + type_changed = true + } else { + types << ret_type + } + } + if type_changed { + idx := c.table.find_or_register_multi_return(types) + typ := table.new_type(idx) + return typ + } + } else if mut sym.info is table.Map { + mut type_changed := false + mut unwrapped_key_type := sym.info.key_type + mut unwrapped_value_type := sym.info.value_type + if typ := c.resolve_generic_type(sym.info.key_type, generic_names, call_expr) { + unwrapped_key_type = typ + type_changed = true + } + if typ := c.resolve_generic_type(sym.info.value_type, generic_names, call_expr) { + unwrapped_value_type = typ + type_changed = true + } + if type_changed { + idx := c.table.find_or_register_map(unwrapped_key_type, unwrapped_value_type) + typ := table.new_type(idx) + return typ + } + } + return none +} diff --git a/vlib/v/checker/checker.v b/vlib/v/checker/checker.v index a0709bed36..9fbbf785c4 100644 --- a/vlib/v/checker/checker.v +++ b/vlib/v/checker/checker.v @@ -1918,84 +1918,9 @@ pub fn (mut c Checker) call_fn(mut call_expr ast.CallExpr) table.Type { c.infer_fn_types(f, mut call_expr) } if call_expr.generic_types.len > 0 && f.return_type != 0 { - // TODO: this logic needs to be cleaned up; maybe make it reusable? - // Handle `foo() T` => `foo() int` => return int - mut return_sym := c.table.get_type_symbol(f.return_type) - if return_sym.name in f.generic_names { - index := f.generic_names.index(return_sym.name) - mut typ := call_expr.generic_types[index] - typ = typ.set_nr_muls(f.return_type.nr_muls()) - if f.return_type.has_flag(.optional) { - typ = typ.set_flag(.optional) - } + if typ := c.resolve_generic_type(f.return_type, f.generic_names, call_expr) { call_expr.return_type = typ return typ - } else if return_sym.kind == .array { - return_info := return_sym.info as table.Array - mut sym := c.table.get_type_symbol(return_info.elem_type) - mut dims := 1 - for { - if mut sym.info is table.Array { - sym = c.table.get_type_symbol(sym.info.elem_type) - dims++ - } else { - break - } - } - if sym.name in f.generic_names { - generic_index := f.generic_names.index(sym.name) - generic_type := call_expr.generic_types[generic_index] - idx := c.table.find_or_register_array_with_dims(generic_type, dims) - typ := table.new_type(idx) - call_expr.return_type = typ - return typ - } - } else if return_sym.kind == .chan { - return_info := return_sym.info as table.Chan - elem_sym := c.table.get_type_symbol(return_info.elem_type) - if elem_sym.name in f.generic_names { - generic_index := f.generic_names.index(elem_sym.name) - generic_type := call_expr.generic_types[generic_index] - idx := c.table.find_or_register_chan(generic_type, generic_type.nr_muls() > 0) - typ := table.new_type(idx) - call_expr.return_type = typ - return typ - } - } else if mut return_sym.info is table.MultiReturn { - mut types := []table.Type{} - for return_type in return_sym.info.types { - multi_return_sym := c.table.get_type_symbol(return_type) - if multi_return_sym.name in f.generic_names { - generic_index := f.generic_names.index(multi_return_sym.name) - types << call_expr.generic_types[generic_index] - } - } - idx := c.table.find_or_register_multi_return(types) - typ := table.new_type(idx) - call_expr.return_type = typ - return typ - } else if mut return_sym.info is table.Map { - mut type_changed := false - mut unwrapped_key_type := return_sym.info.key_type - mut unwrapped_value_type := return_sym.info.value_type - if return_sym.info.key_type.has_flag(.generic) { - key_sym := c.table.get_type_symbol(return_sym.info.key_type) - index := f.generic_names.index(key_sym.name) - unwrapped_key_type = call_expr.generic_types[index] - type_changed = true - } - if return_sym.info.value_type.has_flag(.generic) { - value_sym := c.table.get_type_symbol(return_sym.info.value_type) - index := f.generic_names.index(value_sym.name) - unwrapped_value_type = call_expr.generic_types[index] - type_changed = true - } - if type_changed { - idx := c.table.find_or_register_map(unwrapped_key_type, unwrapped_value_type) - typ := table.new_type(idx) - call_expr.return_type = typ - return typ - } } } if call_expr.generic_types.len > 0 && f.generic_names.len == 0 { diff --git a/vlib/v/tests/generics_test.v b/vlib/v/tests/generics_test.v index 41b3b9c1bd..567c9d71d8 100644 --- a/vlib/v/tests/generics_test.v +++ b/vlib/v/tests/generics_test.v @@ -354,14 +354,14 @@ fn generic_return_map() map[string]M { fn test_generic_return_map() { assert typeof(generic_return_map()).name == 'map[string]string' } -/* + fn generic_return_nested_map() map[string]map[string]M { return {'': {'': M{}}} } fn test_generic_return_nested_map() { assert typeof(generic_return_nested_map()).name == 'map[string]map[string]string' -}*/ +} /* fn multi_return() (A, B) {