From 158835f12fc22641167c4114914f8edf659b619a Mon Sep 17 00:00:00 2001 From: Felipe Pena Date: Sat, 1 Jul 2023 11:21:36 -0300 Subject: [PATCH 1/2] fix --- vlib/v/checker/struct.v | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/vlib/v/checker/struct.v b/vlib/v/checker/struct.v index 25d5893dae..54e303cf0b 100644 --- a/vlib/v/checker/struct.v +++ b/vlib/v/checker/struct.v @@ -661,8 +661,7 @@ fn (mut c Checker) struct_init(mut node ast.StructInit, is_field_zero_struct_ini } if !field.typ.has_flag(.option) && sym.kind == .interface_ && (!has_noinit && sym.language != .js) && !node.has_update_expr { - // TODO: should be an error instead, but first `ui` needs updating. - c.note('interface field `${type_sym.name}.${field.name}` must be initialized', + c.error('interface field `${type_sym.name}.${field.name}` must be initialized', node.pos) } // Do not allow empty uninitialized sum types From ffb5c7504f442f88124f934d36d3f645ddd0c45a Mon Sep 17 00:00:00 2001 From: Felipe Pena Date: Sun, 30 Jul 2023 00:20:19 -0300 Subject: [PATCH 2/2] fix test --- vlib/v/checker/tests/interface_init_err.out | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vlib/v/checker/tests/interface_init_err.out b/vlib/v/checker/tests/interface_init_err.out index 2a5e6ad2e5..238395c279 100644 --- a/vlib/v/checker/tests/interface_init_err.out +++ b/vlib/v/checker/tests/interface_init_err.out @@ -1,4 +1,4 @@ -vlib/v/checker/tests/interface_init_err.vv:15:7: notice: interface field `Server.handler` must be initialized +vlib/v/checker/tests/interface_init_err.vv:15:7: error: interface field `Server.handler` must be initialized 13 | 14 | fn main() { 15 | _ := Server{}