mirror/v
1
0
Fork 0
mirror of https://github.com/vlang/v.git synced 2023-08-10 21:13:21 +03:00
Code Issues Projects Releases Wiki Activity

PR template: add a test if you fixed a bug

Browse Source
This commit is contained in:
Alexander Medvednikov 2019-09-29 04:28:57 +03:00 committed by GitHub
parent d68e31a863
commit cbf5de7c8f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
.github/PULL_REQUEST_TEMPLATE vendored
View File

@ -1,4 +1,4 @@
Please, delete this in your PR, after reading it. **Please delete this information after reading it.*
Please title your PR as follows: `time: fix foo bar`. Always start with the thing you are fixing, then describe the fix. Please title your PR as follows: `time: fix foo bar`. Always start with the thing you are fixing, then describe the fix.
Don't use past tense (e.g. "fixed foo bar"). Don't use past tense (e.g. "fixed foo bar").
@ -18,6 +18,8 @@ fn test_foo() {
} }
``` ```
If you are fixing a bug, please add a test that covers it.
Before submitting a PR, please run the tests with `make test`, and make sure V can still compile itself. Run this twice: Before submitting a PR, please run the tests with `make test`, and make sure V can still compile itself. Run this twice:
./v -o v compiler ./v -o v compiler