mirror/v
1
0
Fork 0
mirror of https://github.com/vlang/v.git synced 2023-08-10 21:13:21 +03:00
Code Issues Projects Releases Wiki Activity

math.big: allow bitwise ops on negative signum (#18912)

Browse Source
This commit is contained in:
phoebe 2023-07-20 12:52:28 +02:00 committed by GitHub
parent f9906f3a9e
commit ef1f5d7725
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
vlib/math/big/integer.v
View File

@ -590,16 +590,9 @@ pub fn (a Integer) < (b Integer) bool {
return if signum < 0 { cmp > 0 } else { cmp < 0 } return if signum < 0 { cmp > 0 } else { cmp < 0 }
} }
fn check_sign(a Integer) {
if a.signum < 0 {
panic('Bitwise operations are only supported for nonnegative integers')
}
}
// get_bit checks whether the bit at the given index is set. // get_bit checks whether the bit at the given index is set.
[direct_array_access] [direct_array_access]
pub fn (a Integer) get_bit(i u32) bool { pub fn (a Integer) get_bit(i u32) bool {
check_sign(a)
target_index := i / 32 target_index := i / 32
offset := i % 32 offset := i % 32
if target_index >= a.digits.len { if target_index >= a.digits.len {
@ -610,7 +603,6 @@ pub fn (a Integer) get_bit(i u32) bool {
// set_bit sets the bit at the given index to the given value. // set_bit sets the bit at the given index to the given value.
pub fn (mut a Integer) set_bit(i u32, value bool) { pub fn (mut a Integer) set_bit(i u32, value bool) {
check_sign(a)
target_index := i / 32 target_index := i / 32
offset := i % 32 offset := i % 32
@ -635,10 +627,10 @@ pub fn (mut a Integer) set_bit(i u32, value bool) {
} }
} }
// bitwise_or returns the "bitwise or" of the integers `a` and `b`. // bitwise_or returns the "bitwise or" of the integers `|a|` and `|b|`.
//
// Note: both operands are treated as absolute values.
pub fn (a Integer) bitwise_or(b Integer) Integer { pub fn (a Integer) bitwise_or(b Integer) Integer {
check_sign(a)
check_sign(b)
mut result := []u32{len: imax(a.digits.len, b.digits.len)} mut result := []u32{len: imax(a.digits.len, b.digits.len)}
bitwise_or_digit_array(a.digits, b.digits, mut result) bitwise_or_digit_array(a.digits, b.digits, mut result)
return Integer{ return Integer{
@ -647,10 +639,10 @@ pub fn (a Integer) bitwise_or(b Integer) Integer {
} }
} }
// bitwise_and returns the "bitwise and" of the integers `a` and `b`. // bitwise_and returns the "bitwise and" of the integers `|a|` and `|b|`.
//
// Note: both operands are treated as absolute values.
pub fn (a Integer) bitwise_and(b Integer) Integer { pub fn (a Integer) bitwise_and(b Integer) Integer {
check_sign(a)
check_sign(b)
mut result := []u32{len: imax(a.digits.len, b.digits.len)} mut result := []u32{len: imax(a.digits.len, b.digits.len)}
bitwise_and_digit_array(a.digits, b.digits, mut result) bitwise_and_digit_array(a.digits, b.digits, mut result)
return Integer{ return Integer{
@ -659,9 +651,10 @@ pub fn (a Integer) bitwise_and(b Integer) Integer {
} }
} }
// bitwise_not returns the "bitwise not" of the integer `a`. // bitwise_not returns the "bitwise not" of the integer `|a|`.
//
// Note: the integer is treated as an absolute value.
pub fn (a Integer) bitwise_not() Integer { pub fn (a Integer) bitwise_not() Integer {
check_sign(a)
mut result := []u32{len: a.digits.len} mut result := []u32{len: a.digits.len}
bitwise_not_digit_array(a.digits, mut result) bitwise_not_digit_array(a.digits, mut result)
return Integer{ return Integer{
@ -670,10 +663,10 @@ pub fn (a Integer) bitwise_not() Integer {
} }
} }
// bitwise_xor returns the "bitwise exclusive or" of the integers `a` and `b`. // bitwise_xor returns the "bitwise exclusive or" of the integers `|a|` and `|b|`.
//
// Note: both operands are treated as absolute values.
pub fn (a Integer) bitwise_xor(b Integer) Integer { pub fn (a Integer) bitwise_xor(b Integer) Integer {
check_sign(a)
check_sign(b)
mut result := []u32{len: imax(a.digits.len, b.digits.len)} mut result := []u32{len: imax(a.digits.len, b.digits.len)}
bitwise_xor_digit_array(a.digits, b.digits, mut result) bitwise_xor_digit_array(a.digits, b.digits, mut result)
return Integer{ return Integer{