1
0
mirror of https://github.com/vlang/v.git synced 2023-08-10 21:13:21 +03:00
v/.github/PULL_REQUEST_TEMPLATE
Delyan Angelov 818bea34a4 Update PULL_REQUEST_TEMPLATE
Ask people to delete the PR boilerplate text.
2019-09-05 12:07:28 +03:00

31 lines
750 B
Plaintext

Please, delete this in your PR, after reading it.
Please title your PR as follows: `time: fix foo bar`. Always start with the thing you are fixing, then describe the fix.
Don't use past tense (e.g. "fixed foo bar").
Explain what your PR does and why.
If you are adding a new function, please document it and add tests:
```
// foo does foo and bar
fn foo() {
// file_test.v
fn test_foo() {
assert foo() == ...
...
}
```
Before submitting a PR, please run the tests with `make test`, and make sure V can still compile itself. Run this twice:
./v -o v compiler
./v -o v compiler
I try to process PRs as soon as possible. They should be handled within 24 hours.
Applying labels to PRs is not needed.
Thanks a lot for your contribution!