mirror/wakapi
1
0
Fork 0
mirror of https://github.com/muety/wakapi.git synced 2023-08-10 21:12:56 +03:00
Code Issues Projects Releases Wiki Activity

chore: add more filtering unit tests

Browse Source
This commit is contained in:
Ferdinand Mütsch
2021-12-26 18:47:16 +01:00
parent fe3ba79d54
commit bf82935849
3 changed files with 799 additions and 676 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
services/summary_test.go
View File

@ -79,8 +79,8 @@ func (suite *SummaryServiceTestSuite) SetupSuite() {
{
ID: uint(rand.Uint32()),
UserID: TestUserId,
ProjectKey: TestProjectLabel3,
Label: "blaahh",
ProjectKey: TestProject3,
Label: TestProjectLabel3,
},
}
}
@ -386,7 +386,7 @@ func (suite *SummaryServiceTestSuite) TestSummaryService_Aliased() {
Duration: 0, // not relevant here
})
suite.DurationService.On("Get", from, to, suite.TestUser, mock.Anything).Return(models.Durations(durations), nil)
suite.DurationService.On("Get", from, to, suite.TestUser, mock.Anything).Return(durations, nil)
suite.AliasService.On("InitializeUser", TestUserId).Return(nil)
suite.AliasService.On("GetAliasOrDefault", TestUserId, mock.Anything, TestProject1).Return(TestProject2, nil)
suite.AliasService.On("GetAliasOrDefault", TestUserId, mock.Anything, TestProject2).Return(TestProject2, nil)
@ -441,6 +441,38 @@ func (suite *SummaryServiceTestSuite) TestSummaryService_Aliased_ProjectLabels()
assert.Equal(suite.T(), 6, result.NumHeartbeats)
}
func (suite *SummaryServiceTestSuite) TestSummaryService_Filters() {
sut := NewSummaryService(suite.SummaryRepository, suite.DurationService, suite.AliasService, suite.ProjectLabelService)
suite.AliasService.On("InitializeUser", suite.TestUser.ID).Return(nil)
suite.ProjectLabelService.On("GetByUser", suite.TestUser.ID).Return([]*models.ProjectLabel{}, nil)
from, to := suite.TestStartTime, suite.TestStartTime.Add(1*time.Hour)
filters := models.NewFiltersWith(models.SummaryProject, TestProject1).With(models.SummaryLabel, TestProjectLabel3)
suite.DurationService.On("Get", from, to, suite.TestUser, mock.Anything).Return(models.Durations{}, nil)
suite.AliasService.On("InitializeUser", TestUserId).Return(nil)
suite.AliasService.On("GetByUserAndKeyAndType", TestUserId, TestProject1, models.SummaryProject).Return([]*models.Alias{
{
Type: models.SummaryProject,
Key: TestProject1,
Value: TestProject2,
},
}, nil)
suite.ProjectLabelService.On("GetByUserGroupedInverted", suite.TestUser.ID).Return(map[string][]*models.ProjectLabel{
suite.TestLabels[0].Label: suite.TestLabels[0:1],
suite.TestLabels[1].Label: suite.TestLabels[1:2],
}, nil).Once()
sut.Aliased(from, to, suite.TestUser, sut.Summarize, filters, false)
effectiveFilters := suite.DurationService.Calls[0].Arguments[3].(*models.Filters)
assert.Contains(suite.T(), effectiveFilters.Project, TestProject1) // because actually requested
assert.Contains(suite.T(), effectiveFilters.Project, TestProject2) // because of alias
assert.Contains(suite.T(), effectiveFilters.Project, TestProject3) // because of label
assert.Contains(suite.T(), effectiveFilters.Label, TestProjectLabel3)
}
func filterDurations(from, to time.Time, durations models.Durations) models.Durations {
filtered := make([]*models.Duration, 0, len(durations))
for _, d := range durations {