iiiypuk/cantata
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Use command list when adding songs to playlist.

Browse Source
This commit is contained in:
craig.p.drummond
2012-07-12 17:57:52 +00:00
committed by craig.p.drummond
parent 0c6ae40474
commit d47747127a
2 changed files with 27 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
ChangeLog
View File

@@ -1,23 +1,24 @@
0.8.1
-----
1. Detect when this is the first time a user has run Cantata. If so, don't
place the play queue in the sidebar.
2. Dont attempt to rename a playlist to its current name - otherwise it is
deleted!
3. When applying updates in tag editor, track organizer, or replay gain dialog
show a progress bar to indicate activity.
4. Display version number in Qt-only about dialog.
5. When expanding interface, set max size to INT_MAX. Otherwise, on windows at
least, the maximise button can get disabled.
6. If 'Music folder' in settings dialog is a http folder (path starts with
http://), then attempt to download cover-art from the http server.
7. Dont update MPD volume just after we receive a status update - as MPD already
has that setting! Fixes an issue with pulseaudio setups - where MPD
disconnects from pulse audio, tells cantata that volume is -1, and cantata
attempts to set volume to 0.
8. When fading on stop, reset original volume immediately before sending stop.
9. Fix saving of library to XML cache when multiple artist albums are grouped
under 'Various Artists' (only save artist attribute once!!)
1. Detect when this is the first time a user has run Cantata. If so, don't
place the play queue in the sidebar.
2. Dont attempt to rename a playlist to its current name - otherwise it is
deleted!
3. When applying updates in tag editor, track organizer, or replay gain dialog
show a progress bar to indicate activity.
4. Display version number in Qt-only about dialog.
5. When expanding interface, set max size to INT_MAX. Otherwise, on windows at
least, the maximise button can get disabled.
6. If 'Music folder' in settings dialog is a http folder (path starts with
http://), then attempt to download cover-art from the http server.
7. Dont update MPD volume just after we receive a status update - as MPD already
has that setting! Fixes an issue with pulseaudio setups - where MPD
disconnects from pulse audio, tells cantata that volume is -1, and cantata
attempts to set volume to 0.
8. When fading on stop, reset original volume immediately before sending stop.
9. Fix saving of library to XML cache when multiple artist albums are grouped
under 'Various Artists' (only save artist attribute once!!)
10. Use command list when adding songs to playlist.
0.8.0
-----

24
mpd/mpdconnection.cpp
View File

@@ -1044,31 +1044,23 @@ void MPDConnection::addToPlaylist(const QString &name, const QStringList &songs,
}
QByteArray encodedName=encodeName(name);
QStringList added;
QByteArray send = "command_list_begin\n";
foreach (const QString &s, songs) {
QByteArray data = "playlistadd ";
data += encodedName;
data += " ";
data += encodeName(s);
if (sendCommand(data).ok) {
added << s;
} else {
break;
}
send += "playlistadd "+encodedName+" "+encodeName(s)+"\n";
}
send += "command_list_end";
if (!added.isEmpty()) {
if (sendCommand(send).ok) {
if (size>0) {
QList<quint32> items;
for(int i=0; i<added.count(); ++i) {
for(int i=0; i<songs.count(); ++i) {
items.append(size+i);
}
doMoveInPlaylist(name, items, pos, size+added.count());
doMoveInPlaylist(name, items, pos, size+songs.count());
}
} else {
playlistInfo(name);
}
// playlistInfo(name);
}
void MPDConnection::removeFromPlaylist(const QString &name, const QList<quint32> &positions)