Release v1.5.8

This reverts commit ee1eb455f4.

bower.json

@@ -1,6 +1,6 @@
 {
   "name": "clipboard",
-  "version": "1.5.5",
+  "version": "1.5.8",
   "description": "Modern copy to clipboard. No Flash. Just 2kb",
   "license": "MIT",
   "main": "dist/clipboard.js",

dist/clipboard.js

@@ -1,5 +1,5 @@
 /*!
- * clipboard.js v1.5.5
+ * clipboard.js v1.5.8
  * https://zenorocha.github.io/clipboard.js
  *
  * Licensed MIT © Zeno Rocha
@@ -16,48 +16,7 @@ module.exports = function (element, selector, checkYoSelf) {
   }
 }
 
-},{"matches-selector":2}],2:[function(require,module,exports){
-
-/**
- * Element prototype.
- */
-
-var proto = Element.prototype;
-
-/**
- * Vendor function.
- */
-
-var vendor = proto.matchesSelector
-  || proto.webkitMatchesSelector
-  || proto.mozMatchesSelector
-  || proto.msMatchesSelector
-  || proto.oMatchesSelector;
-
-/**
- * Expose `match()`.
- */
-
-module.exports = match;
-
-/**
- * Match `el` to `selector`.
- *
- * @param {Element} el
- * @param {String} selector
- * @return {Boolean}
- * @api public
- */
-
-function match(el, selector) {
-  if (vendor) return vendor.call(el, selector);
-  var nodes = el.parentNode.querySelectorAll(selector);
-  for (var i = 0; i < nodes.length; ++i) {
-    if (nodes[i] == el) return true;
-  }
-  return false;
-}
-},{}],3:[function(require,module,exports){
+},{"matches-selector":5}],2:[function(require,module,exports){
 var closest = require('closest');
 
 /**
@@ -67,16 +26,17 @@ var closest = require('closest');
  * @param {String} selector
  * @param {String} type
  * @param {Function} callback
+ * @param {Boolean} useCapture
  * @return {Object}
  */
-function delegate(element, selector, type, callback) {
+function delegate(element, selector, type, callback, useCapture) {
     var listenerFn = listener.apply(this, arguments);
 
-    element.addEventListener(type, listenerFn);
+    element.addEventListener(type, listenerFn, useCapture);
 
     return {
         destroy: function() {
-            element.removeEventListener(type, listenerFn);
+            element.removeEventListener(type, listenerFn, useCapture);
         }
     }
 }
@@ -102,7 +62,7 @@ function listener(element, selector, type, callback) {
 
 module.exports = delegate;
 
-},{"closest":1}],4:[function(require,module,exports){
+},{"closest":1}],3:[function(require,module,exports){
 /**
  * Check if argument is a HTML element.
  *
@@ -147,13 +107,13 @@ exports.string = function(value) {
  * @param {Object} value
  * @return {Boolean}
  */
-exports.function = function(value) {
+exports.fn = function(value) {
     var type = Object.prototype.toString.call(value);
 
     return type === '[object Function]';
 };
 
-},{}],5:[function(require,module,exports){
+},{}],4:[function(require,module,exports){
 var is = require('./is');
 var delegate = require('delegate');
 
@@ -175,7 +135,7 @@ function listen(target, type, callback) {
         throw new TypeError('Second argument must be a String');
     }
 
-    if (!is.function(callback)) {
+    if (!is.fn(callback)) {
         throw new TypeError('Third argument must be a Function');
     }
 
@@ -250,7 +210,48 @@ function listenSelector(selector, type, callback) {
 
 module.exports = listen;
 
-},{"./is":4,"delegate":3}],6:[function(require,module,exports){
+},{"./is":3,"delegate":2}],5:[function(require,module,exports){
+
+/**
+ * Element prototype.
+ */
+
+var proto = Element.prototype;
+
+/**
+ * Vendor function.
+ */
+
+var vendor = proto.matchesSelector
+  || proto.webkitMatchesSelector
+  || proto.mozMatchesSelector
+  || proto.msMatchesSelector
+  || proto.oMatchesSelector;
+
+/**
+ * Expose `match()`.
+ */
+
+module.exports = match;
+
+/**
+ * Match `el` to `selector`.
+ *
+ * @param {Element} el
+ * @param {String} selector
+ * @return {Boolean}
+ * @api public
+ */
+
+function match(el, selector) {
+  if (vendor) return vendor.call(el, selector);
+  var nodes = el.parentNode.querySelectorAll(selector);
+  for (var i = 0; i < nodes.length; ++i) {
+    if (nodes[i] == el) return true;
+  }
+  return false;
+}
+},{}],6:[function(require,module,exports){
 function select(element) {
     var selectedText;
 
@@ -422,6 +423,8 @@ var ClipboardAction = (function () {
     ClipboardAction.prototype.selectFake = function selectFake() {
         var _this = this;
 
+        var isRTL = document.documentElement.getAttribute('dir') == 'rtl';
+
         this.removeFake();
 
         this.fakeHandler = document.body.addEventListener('click', function () {
@@ -429,8 +432,16 @@ var ClipboardAction = (function () {
         });
 
         this.fakeElem = document.createElement('textarea');
+        // Prevent zooming on iOS
+        this.fakeElem.style.fontSize = '12pt';
+        // Reset box model
+        this.fakeElem.style.border = '0';
+        this.fakeElem.style.padding = '0';
+        this.fakeElem.style.margin = '0';
+        // Move element out of screen horizontally
         this.fakeElem.style.position = 'absolute';
-        this.fakeElem.style.left = '-9999px';
+        this.fakeElem.style[isRTL ? 'right' : 'left'] = '-9999px';
+        // Move element to the same position vertically
         this.fakeElem.style.top = (window.pageYOffset || document.documentElement.scrollTop) + 'px';
         this.fakeElem.setAttribute('readonly', '');
         this.fakeElem.value = this.text;
@@ -728,6 +739,7 @@ var Clipboard = (function (_Emitter) {
     return Clipboard;
 })(_tinyEmitter2['default']);
 
+exports['default'] = Clipboard;
 function getAttributeValue(suffix, element) {
     var attribute = 'data-clipboard-' + suffix;
 
@@ -737,9 +749,7 @@ function getAttributeValue(suffix, element) {
 
     return element.getAttribute(attribute);
 }
-
-exports['default'] = Clipboard;
 module.exports = exports['default'];
 
-},{"./clipboard-action":8,"good-listener":5,"tiny-emitter":7}]},{},[9])(9)
+},{"./clipboard-action":8,"good-listener":4,"tiny-emitter":7}]},{},[9])(9)
 });

package.js

@@ -3,10 +3,10 @@
 Package.describe({
   name: "zenorocha:clipboard",
   summary: "Modern copy to clipboard. No Flash. Just 2kb.",
-  version: "1.5.5",
+  version: "1.5.8",
   git: "https://github.com/zenorocha/clipboard.js"
 });
 
 Package.onUse(function(api) {
-  api.addFiles("dist/clipboard.min.js", "client");
+  api.addFiles("dist/clipboard.js", "client");
 });

package.json

@@ -1,6 +1,6 @@
 {
   "name": "clipboard",
-  "version": "1.5.5",
+  "version": "1.5.8",
   "description": "Modern copy to clipboard. No Flash. Just 2kb",
   "repository": "zenorocha/clipboard.js",
   "license": "MIT",
@@ -11,14 +11,16 @@
     "cut"
   ],
   "dependencies": {
-    "good-listener": "^1.1.4",
+    "good-listener": "^1.1.6",
     "select": "^1.0.6",
     "tiny-emitter": "^1.0.0"
   },
   "devDependencies": {
     "babel": "^5.8.29",
     "babelify": "^6.3.0",
+    "bannerify": "Vekat/bannerify#feature-option",
     "browserify": "^11.2.0",
+    "chai": "^3.4.1",
     "karma": "^0.13.10",
     "karma-browserify": "^4.4.0",
     "karma-chai": "^0.1.0",
@@ -26,10 +28,11 @@
     "karma-phantomjs-launcher": "^0.2.1",
     "karma-sinon": "^1.0.4",
     "mocha": "^2.3.3",
+    "phantomjs": "^1.9.18",
     "phantomjs-polyfill": "0.0.1",
+    "sinon": "^1.17.2",
     "uglify-js": "^2.4.24",
-    "watchify": "^3.4.0",
-    "bannerify": "Vekat/bannerify#feature-option"
+    "watchify": "^3.4.0"
   },
   "scripts": {
     "build": "npm run build-debug && npm run build-min",

readme.md

@@ -151,7 +151,7 @@ new Clipboard('.btn', {
 });
 ```
 
-Also, with are working with single page apps, you may want to manage the lifecycle of the DOM more precisely. Here's how you clean up the events and objects that we create.
+Also, if you are working with single page apps, you may want to manage the lifecycle of the DOM more precisely. Here's how you clean up the events and objects that we create.
 
 ```js
 var clipboard = new Clipboard('.btn');

src/clipboard-action.js

@@ -4,7 +4,7 @@ import select from 'select';
  * Inner class which performs selection from either `text` or `target`
  * properties and then executes copy or cut operations.
  */
-class ClipboardAction {
+export default class ClipboardAction {
     /**
      * @param {Object} options
      */
@@ -51,13 +51,23 @@ class ClipboardAction {
      * and makes a selection on it.
      */
     selectFake() {
+        let isRTL = document.documentElement.getAttribute('dir') == 'rtl';
+
         this.removeFake();
 
         this.fakeHandler = document.body.addEventListener('click', () => this.removeFake());
 
         this.fakeElem = document.createElement('textarea');
+        // Prevent zooming on iOS
+        this.fakeElem.style.fontSize = '12pt';
+        // Reset box model
+        this.fakeElem.style.border = '0';
+        this.fakeElem.style.padding = '0';
+        this.fakeElem.style.margin = '0';
+        // Move element out of screen horizontally
         this.fakeElem.style.position = 'absolute';
-        this.fakeElem.style.left = '-9999px';
+        this.fakeElem.style[ isRTL ? 'right' : 'left' ] = '-9999px';
+        // Move element to the same position vertically
         this.fakeElem.style.top = (window.pageYOffset || document.documentElement.scrollTop) + 'px';
         this.fakeElem.setAttribute('readonly', '');
         this.fakeElem.value = this.text;
@@ -192,5 +202,3 @@ class ClipboardAction {
         this.removeFake();
     }
 }
-
-export default ClipboardAction;

src/clipboard.js

@@ -6,7 +6,7 @@ import listen from 'good-listener';
  * Base class which takes one or more elements, adds event listeners to them,
  * and instantiates a new `ClipboardAction` on each click.
  */
-class Clipboard extends Emitter {
+export default class Clipboard extends Emitter {
     /**
      * @param {String|HTMLElement|HTMLCollection|NodeList} trigger
      * @param {Object} options
@@ -42,7 +42,7 @@ class Clipboard extends Emitter {
      * @param {Event} e
      */
     onClick(e) {
-        var trigger = e.delegateTarget || e.currentTarget;
+        let trigger = e.delegateTarget || e.currentTarget;
 
         if (this.clipboardAction) {
             this.clipboardAction = null;
@@ -113,5 +113,3 @@ function getAttributeValue(suffix, element) {
 
     return element.getAttribute(attribute);
 }
-
-export default Clipboard;

test/clipboard-action.js

@@ -57,6 +57,19 @@ describe('ClipboardAction', () => {
                 done();
             }
         });
+
+        it('should set the position right style property', done => {
+            // Set document direction
+            document.documentElement.setAttribute('dir', 'rtl');
+
+            let clip = new ClipboardAction({
+                    emitter: new Emitter(),
+                    text: 'foo'
+                });
+
+            assert.equal(clip.fakeElem.style.right, '-9999px');
+            done();
+        });
     });
 
     describe('#set action', () => {

test/clipboard.js

@@ -77,7 +77,7 @@ describe('Clipboard', () => {
             assert.instanceOf(clipboard.clipboardAction, ClipboardAction);
         });
 
-        it('should throws exception target', done => {
+        it('should throw an exception when target is invalid', done => {
             try {
                 var clipboard = new Clipboard('.btn', {
                     target: function() {