Replace a few leftover calls to strdup and calloc with xstrdup and xcalloc

respectively.

ok okan.
This commit is contained in:
oga 2008-04-16 13:38:09 +00:00
parent f67772be65
commit f473dc3d12
5 changed files with 11 additions and 16 deletions

View File

@ -409,11 +409,11 @@ void grab_label(struct client_ctx *);
void xfree(void *);
void *xmalloc(size_t);
void *xcalloc(size_t);
void *xcalloc(size_t, size_t);
char *xstrdup(const char *);
#define XMALLOC(p, t) ((p) = (t *)xmalloc(sizeof * (p)))
#define XCALLOC(p, t) ((p) = (t *)xcalloc(sizeof * (p)))
#define XCALLOC(p, t) ((p) = (t *)xcalloc(1, sizeof * (p)))
void screen_init(void);
struct screen_ctx *screen_fromroot(Window);

2
conf.c
View File

@ -360,7 +360,7 @@ conf_bindname(struct conf *c, char *name, char *binding)
return;
current_binding->callback = kbfunc_cmdexec;
current_binding->argument = strdup(binding);
current_binding->argument = xstrdup(binding);
current_binding->flags = 0;
TAILQ_INSERT_TAIL(&c->keybindingq, current_binding, entry);
return;

View File

@ -85,7 +85,7 @@ _group_show(struct group_ctx *gc)
u_int i;
int lastempty = -1;
winlist = (Window *) xcalloc(sizeof(*winlist) * (gc->highstack + 1));
winlist = (Window *) xcalloc(sizeof(*winlist), (gc->highstack + 1));
/*
* Invert the stacking order as XRestackWindows() expects them

15
parse.y
View File

@ -359,9 +359,7 @@ yylex(void)
}
*p++ = (char)c;
}
yylval.v.string = strdup(buf);
if (yylval.v.string == NULL)
err(1, "yylex: strdup");
yylval.v.string = xstrdup(buf);
return (STRING);
}
@ -418,8 +416,7 @@ nodigits:
lungetc(c);
*p = '\0';
if ((token = lookup(buf)) == STRING)
if ((yylval.v.string = strdup(buf)) == NULL)
err(1, "yylex: strdup");
yylval.v.string = xstrdup(buf);
return (token);
}
if (c == '\n') {
@ -436,11 +433,9 @@ pushfile(const char *name)
{
struct file *nfile;
if ((nfile = calloc(1, sizeof(struct file))) == NULL ||
(nfile->name = strdup(name)) == NULL) {
warn("malloc");
return (NULL);
}
nfile = xcalloc(1, sizeof(struct file));
nfile->name = xstrdup(name);
if ((nfile->stream = fopen(nfile->name, "r")) == NULL) {
warn("%s", nfile->name);
free(nfile->name);

View File

@ -33,11 +33,11 @@ xmalloc(size_t siz)
}
void *
xcalloc(size_t siz)
xcalloc(size_t no, size_t siz)
{
void *p;
if ((p = calloc(1, siz)) == NULL)
if ((p = calloc(no, siz)) == NULL)
err(1, "calloc");
return (p);