Turned _settings.js into an IIFE

This commit is contained in:
unsettledgames 2021-07-23 18:45:23 +02:00
parent 526177c6fe
commit 366c2d9e2a
4 changed files with 64 additions and 54 deletions

View File

@ -264,8 +264,6 @@ const LayerList = (() => {
closeOptionsMenu();
}
// TODO: Can't select the first layer
function merge(saveHistory = true) {
// Saving the layer that should be merged
let toMerge = currentLayer;

63
js/Settings.js Normal file
View File

@ -0,0 +1,63 @@
// REFACTOR: convert to IIFE
const Settings = (() => {
let settings;
let settingsFromCookie;
//on clicking the save button in the settings dialog
Events.on('click', 'save-settings', saveSettings);
init();
function init() {
if (!Cookies.enabled) {
document.getElementById('cookies-disabled-warning').style.display = 'block';
}
settingsFromCookie = Cookies.get('pixelEditorSettings');
if(!settingsFromCookie) {
console.log('settings cookie not found');
settings = {
switchToChangedColor: true,
enableDynamicCursorOutline: true, //unused - performance
enableBrushPreview: true, //unused - performance
enableEyedropperPreview: true, //unused - performance
numberOfHistoryStates: 20,
maxColorsOnImportedImage: 128,
pixelGridColour: '#000000'
};
}
else{
console.log('settings cookie found');
console.log(settingsFromCookie);
settings = JSON.parse(settingsFromCookie);
}
}
function saveSettings() {
//check if values are valid
if (isNaN(Util.getValue('setting-numberOfHistoryStates'))) {
alert('Invalid value for numberOfHistoryStates');
return;
}
//save new settings to settings object
settings.numberOfHistoryStates = Util.getValue('setting-numberOfHistoryStates');
settings.pixelGridColour = Util.getValue('setting-pixelGridColour');
// Filling pixel grid again if colour changed
fillPixelGrid();
//save settings object to cookie
var cookieValue = JSON.stringify(settings);
Cookies.set('pixelEditorSettings', cookieValue, { expires: Infinity });
//close window
Dialogue.closeDialogue();
}
return {
}
})();

View File

@ -1,51 +0,0 @@
// REFACTOR: convert to IIFE
var settings;
if (!Cookies.enabled) {
document.getElementById('cookies-disabled-warning').style.display = 'block';
}
//try to load settings from cookie
var settingsFromCookie = Cookies.get('pixelEditorSettings');
if(!settingsFromCookie) {
console.log('settings cookie not found');
settings = {
switchToChangedColor: true,
enableDynamicCursorOutline: true, //unused - performance
enableBrushPreview: true, //unused - performance
enableEyedropperPreview: true, //unused - performance
numberOfHistoryStates: 20,
maxColorsOnImportedImage: 128,
pixelGridColour: '#000000'
};
}
else{
console.log('settings cookie found');
console.log(settingsFromCookie);
var settings = JSON.parse(settingsFromCookie);
}
console.log(settings);
//on clicking the save button in the settings dialog
Events.on('click', 'save-settings', saveSettings);
function saveSettings() {
//check if values are valid
if (isNaN(Util.getValue('setting-numberOfHistoryStates'))) {
alert('Invalid value for numberOfHistoryStates');
return;
}
//save new settings to settings object
settings.numberOfHistoryStates = Util.getValue('setting-numberOfHistoryStates');
settings.pixelGridColour = Util.getValue('setting-pixelGridColour');
// Filling pixel grid again if colour changed
fillPixelGrid();
//save settings object to cookie
var cookieValue = JSON.stringify(settings);
Cookies.set('pixelEditorSettings', cookieValue, { expires: Infinity });
//close window
Dialogue.closeDialogue();
}

View File

@ -12,7 +12,7 @@
/**init**/
//=include _consts.js
//=include _settings.js
//=include Settings.js
//=include LayerList.js
//=include Layer.js
//=include Startup.js