mirror/v
1
0
Fork 0
mirror of https://github.com/vlang/v.git synced 2023-08-10 21:13:21 +03:00
Code Issues Projects Releases Wiki Activity

ast.table: cache the returned values of Table.type_to_str_using_aliases/2

Browse Source 
This results in 9% speedup of the checker stage for V itself.
This commit is contained in:
Delyan Angelov 2022-06-02 17:27:49 +03:00
parent ed759b2ec9
commit aae5b9fb95
No known key found for this signature in database
GPG Key ID: 66886C0F12D595ED
2 changed files with 21 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
vlib/v/ast/table.v
View File

@ -45,6 +45,8 @@ pub mut:
mdeprecated_after map[string]time.Time // module deprecation date
builtin_pub_fns map[string]bool
pointer_size int
// cache for type_to_str_using_aliases
cached_type_to_str map[u64]string
}
// used by vls to avoid leaks

24
vlib/v/ast/types.v
View File

@ -1127,8 +1127,17 @@ pub fn (t &Table) clean_generics_type_str(typ Type) string {
// import_aliases is a map of imported symbol aliases 'module.Type' => 'Type'
pub fn (t &Table) type_to_str_using_aliases(typ Type, import_aliases map[string]string) string {
cache_key := (u64(import_aliases.len) << 32) | u64(typ)
if cached_res := t.cached_type_to_str[cache_key] {
return cached_res
}
sym := t.sym(typ)
mut res := sym.name
mut mt := unsafe { &Table(t) }
defer {
// Note, that this relies on `res = value return res` if you want to return early!
mt.cached_type_to_str[cache_key] = res
}
// Note, that the duplication of code in some of the match branches here
// is VERY deliberate. DO NOT be tempted to use `else {}` instead, because
// that strongly reduces the usefullness of the exhaustive checking that
@ -1147,7 +1156,8 @@ pub fn (t &Table) type_to_str_using_aliases(typ Type, import_aliases map[string]
}
.array {
if typ == ast.array_type {
return 'array'
res = 'array'
return res
}
if typ.has_flag(.variadic) {
res = t.type_to_str_using_aliases(t.value_type(typ), import_aliases)
@ -1202,7 +1212,8 @@ pub fn (t &Table) type_to_str_using_aliases(typ Type, import_aliases map[string]
}
.map {
if int(typ) == ast.map_type_idx {
return 'map'
res = 'map'
return res
}
info := sym.info as Map
key_str := t.type_to_str_using_aliases(info.key_type, import_aliases)
@ -1257,12 +1268,15 @@ pub fn (t &Table) type_to_str_using_aliases(typ Type, import_aliases map[string]
}
.void {
if typ.has_flag(.optional) {
return '?'
res = '?'
return res
}
if typ.has_flag(.result) {
return '!'
res = '!'
return res
}
return 'void'
res = 'void'
return res
}
.thread {
rtype := sym.thread_info().return_type