mirror/v
1
0
Fork 0
mirror of https://github.com/vlang/v.git synced 2023-08-10 21:13:21 +03:00
Code Issues Projects Releases Wiki Activity

checker: make the "reference field must be initialised" warning more informative, fix clipboard (used by ui)

Browse Source
This commit is contained in:
Delyan Angelov 2022-10-02 16:24:15 +03:00
parent b158da398b
commit b83d0281e4
No known key found for this signature in database
GPG Key ID: 66886C0F12D595ED
4 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
vlib/clipboard/x11/clipboard.c.v
View File

@ -140,12 +140,12 @@ enum AtomType {
[heap]
pub struct Clipboard {
display &C.Display
display &C.Display = unsafe { nil }
mut:
selection Atom // the selection atom
window Window
atoms []Atom
mutex &sync.Mutex
mutex &sync.Mutex = unsafe { nil }
text string // text data sent or received
got_text bool // used to confirm that we have got the text
is_owner bool // to save selection owner state

2
vlib/v/checker/struct.v
View File

@ -608,7 +608,7 @@ fn (mut c Checker) check_ref_fields_initialized(struct_sym &ast.TypeSymbol, mut
continue
}
if field.typ.is_ptr() && !field.typ.has_flag(.shared_f) && !field.has_default_expr {
c.warn('reference field `${linked_name}.$field.name` must be initialized',
c.warn('reference field `${linked_name}.$field.name` must be initialized (part of struct `$struct_sym.name`)',
node.pos)
continue
}

2
vlib/v/checker/tests/struct_field_reference_type_err.out
View File

@ -1,4 +1,4 @@
vlib/v/checker/tests/struct_field_reference_type_err.vv:12:16: warning: reference field `Animal.duck.age` must be initialized
vlib/v/checker/tests/struct_field_reference_type_err.vv:12:16: warning: reference field `Animal.duck.age` must be initialized (part of struct `Duck`)
10 |
11 | fn main() {
12 | mut animal := Animal{

4
vlib/v/checker/tests/struct_ref_fields_uninitialized_err.out
View File

@ -1,11 +1,11 @@
vlib/v/checker/tests/struct_ref_fields_uninitialized_err.vv:25:7: warning: reference field `Outer.c1.b` must be initialized
vlib/v/checker/tests/struct_ref_fields_uninitialized_err.vv:25:7: warning: reference field `Outer.c1.b` must be initialized (part of struct `ContainsRef`)
23 |
24 | fn main() {
25 | _ := Outer{}
| ~~~~~~~
26 | _ := Struct{}
27 | }
vlib/v/checker/tests/struct_ref_fields_uninitialized_err.vv:25:7: warning: reference field `Outer.c2.b` must be initialized
vlib/v/checker/tests/struct_ref_fields_uninitialized_err.vv:25:7: warning: reference field `Outer.c2.b` must be initialized (part of struct `ContainsRef`)
23 |
24 | fn main() {
25 | _ := Outer{}