mirror of
https://github.com/vlang/v.git
synced 2023-08-10 21:13:21 +03:00
checker: check fn call with argument mismatch (#14519)
This commit is contained in:
parent
79a75c5ac0
commit
e19ac0c4a7
@ -897,15 +897,6 @@ pub fn (mut c Checker) fn_call(mut node ast.CallExpr, mut continue_check &bool)
|
||||
}
|
||||
c.check_expected_call_arg(arg_typ, c.unwrap_generic(param.typ), node.language,
|
||||
call_arg) or {
|
||||
// str method, allow type with str method if fn arg is string
|
||||
// Passing an int or a string array produces a c error here
|
||||
// Deleting this condition results in propper V error messages
|
||||
// if arg_typ_sym.kind == .string && typ_sym.has_method('str') {
|
||||
// continue
|
||||
// }
|
||||
if arg_typ_sym.kind == .void && param_typ_sym.kind == .string {
|
||||
continue
|
||||
}
|
||||
if param.typ.has_flag(.generic) {
|
||||
continue
|
||||
}
|
||||
@ -990,7 +981,6 @@ pub fn (mut c Checker) fn_call(mut node ast.CallExpr, mut continue_check &bool)
|
||||
if func.language != .c && !c.inside_unsafe && arg_typ.nr_muls() != param.typ.nr_muls()
|
||||
&& !(call_arg.is_mut && param.is_mut) && !(!call_arg.is_mut && !param.is_mut)
|
||||
&& param.typ !in [ast.byteptr_type, ast.charptr_type, ast.voidptr_type] {
|
||||
// sym := c.table.sym(typ)
|
||||
c.warn('automatic referencing/dereferencing is deprecated and will be removed soon (got: $arg_typ.nr_muls() references, expected: $param.typ.nr_muls() references)',
|
||||
call_arg.pos)
|
||||
}
|
||||
|
7
vlib/v/checker/tests/fn_call_arg_mismatch_err_c.out
Normal file
7
vlib/v/checker/tests/fn_call_arg_mismatch_err_c.out
Normal file
@ -0,0 +1,7 @@
|
||||
vlib/v/checker/tests/fn_call_arg_mismatch_err_c.vv:13:18: error: `os.chdir(files) ?` (no value) used as value in argument 1 to `os.ls`
|
||||
11 | println(files)
|
||||
12 | } else {
|
||||
13 | println(os.ls(os.chdir(files)?)?)
|
||||
| ~~~~~~~~~~~~~~~~
|
||||
14 | }
|
||||
15 | println(files)
|
29
vlib/v/checker/tests/fn_call_arg_mismatch_err_c.vv
Normal file
29
vlib/v/checker/tests/fn_call_arg_mismatch_err_c.vv
Normal file
@ -0,0 +1,29 @@
|
||||
module main
|
||||
|
||||
import os
|
||||
|
||||
fn list_files() ?[][]string {
|
||||
mut unchecked_files := os.ls('utilities/modules')?
|
||||
println(unchecked_files)
|
||||
for files in unchecked_files {
|
||||
println(files)
|
||||
if os.is_file(files) == true {
|
||||
println(files)
|
||||
} else {
|
||||
println(os.ls(os.chdir(files)?)?)
|
||||
}
|
||||
println(files)
|
||||
}
|
||||
mut modules := [['Module:', 'Path:', 'Description']]
|
||||
return modules
|
||||
}
|
||||
|
||||
fn main() {
|
||||
mut data := [
|
||||
['Module:', 'Path:', 'Description'],
|
||||
]
|
||||
mods := list_files() or { [['null', 'null', 'null']] }
|
||||
for _, mod in mods {
|
||||
data << mod
|
||||
}
|
||||
}
|
Loading…
Reference in New Issue
Block a user