fix: include missing mail headers (resolve #472)

This commit is contained in:
Ferdinand Mütsch 2023-03-06 20:31:31 +01:00
parent ce077f2efc
commit fde45a5138
3 changed files with 42 additions and 6 deletions

View File

@ -2,18 +2,22 @@ package models
import ( import (
"fmt" "fmt"
uuid "github.com/satori/go.uuid"
"strings" "strings"
"time"
) )
const HtmlType = "text/html; charset=UTF-8" const HtmlType = "text/html; charset=UTF-8"
const PlainType = "text/html; charset=UTF-8" const PlainType = "text/html; charset=UTF-8"
type Mail struct { type Mail struct {
From MailAddress From MailAddress
To MailAddresses To MailAddresses
Subject string Subject string
Body string Body string
Type string Type string
Date time.Time
MessageID string
} }
func (m *Mail) WithText(text string) *Mail { func (m *Mail) WithText(text string) *Mail {
@ -28,17 +32,36 @@ func (m *Mail) WithHTML(html string) *Mail {
return m return m
} }
func (m *Mail) Sanitized() *Mail {
if m.Type == "" {
m.Type = PlainType
}
if m.Date.IsZero() {
m.Date = time.Now()
}
if m.MessageID == "" {
m.MessageID = fmt.Sprintf("<%s@%s>", uuid.NewV4().String(), m.From.Domain())
}
return m
}
func (m *Mail) String() string { func (m *Mail) String() string {
return fmt.Sprintf("To: %s\r\n"+ return fmt.Sprintf("To: %s\r\n"+
"From: %s\r\n"+ "From: %s\r\n"+
"Subject: %s\r\n"+ "Subject: %s\r\n"+
"Message-ID: %s\r\n"+
"MIME-Version: 1.0\r\n"+
"Content-Type: %s\r\n"+ "Content-Type: %s\r\n"+
"Content-Transfer-Encoding: 8bit\r\n"+
"Date: %s\r\n"+
"\r\n"+ "\r\n"+
"%s\r\n", "%s\r\n",
strings.Join(m.To.RawStrings(), ", "), strings.Join(m.To.RawStrings(), ", "),
m.From.String(), m.From.String(),
m.Subject, m.Subject,
m.MessageID,
m.Type, m.Type,
m.Date.Format(time.RFC1123Z),
m.Body, m.Body,
) )
} }

View File

@ -1,6 +1,9 @@
package models package models
import "regexp" import (
"regexp"
"strings"
)
const ( const (
MailPattern = "[a-zA-Z0-9_.+-]+@[a-zA-Z0-9-]+\\.[a-zA-Z0-9-.]+" MailPattern = "[a-zA-Z0-9_.+-]+@[a-zA-Z0-9-]+\\.[a-zA-Z0-9-.]+"
@ -36,6 +39,14 @@ func (m MailAddress) Raw() string {
return "" return ""
} }
func (m MailAddress) Domain() string {
split := strings.Split(m.Raw(), "@")
if len(split) != 2 {
return ""
}
return split[1]
}
func (m MailAddress) Valid() bool { func (m MailAddress) Valid() bool {
return emailAddrRegex.Match([]byte(m)) return emailAddrRegex.Match([]byte(m))
} }

View File

@ -26,6 +26,8 @@ func NewSMTPSendingService(config conf.SMTPMailConfig) *SMTPSendingService {
} }
func (s *SMTPSendingService) Send(mail *models.Mail) error { func (s *SMTPSendingService) Send(mail *models.Mail) error {
mail = mail.Sanitized()
dial := smtp.Dial dial := smtp.Dial
if s.config.TLS { if s.config.TLS {
dial = func(addr string) (*smtp.Client, error) { dial = func(addr string) (*smtp.Client, error) {