Release v1.4.1

Merge pull request #74 from calvincorreli/patch-1
Fix for scrolling to top in unsupported firefox
2023-08-10 21:12:48 +03:00 · 2015-10-09 09:08:02 +02:00 · 2015-10-09 09:01:19 +02:00 · 2015-10-07 22:06:00 +02:00 · 2015-10-06 15:55:21 +02:00 · 2015-10-05 11:54:20 -04:00
5 changed files with 6 additions and 6 deletions
--- a/bower.json
+++ b/bower.json
@@ -1,6 +1,6 @@
 {
  "name": "clipboard",
-  "version": "1.4.0",
+  "version": "1.4.1",
  "description": "Modern copy to clipboard. No Flash. Just 2kb",
  "license": "MIT",
  "main": "dist/clipboard.js",
--- a/dist/clipboard.js
+++ b/dist/clipboard.js
@@ -281,7 +281,7 @@ var ClipboardAction = (function () {
        this.fakeElem = document.createElement('textarea');
        this.fakeElem.style.position = 'absolute';
        this.fakeElem.style.left = '-9999px';
-        this.fakeElem.style.top = document.body.scrollTop + 'px';
+        this.fakeElem.style.top = (window.pageYOffset || document.documentElement.scrollTop) + 'px';
        this.fakeElem.setAttribute('readonly', '');
        this.fakeElem.value = this.text;
        this.selectedText = this.text;
--- a/dist/clipboard.min.js
+++ b/dist/clipboard.min.js
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
  "name": "clipboard",
-  "version": "1.4.0",
+  "version": "1.4.1",
  "description": "Modern copy to clipboard. No Flash. Just 2kb",
  "repository": "zenorocha/clipboard.js",
  "license": "MIT",
@@ -43,7 +43,7 @@
    "build": "npm run build-debug && npm run build-min",
    "build-debug": "browserify src/clipboard.js -s Clipboard -o dist/clipboard.js",
    "build-min": "uglify -s dist/clipboard.js -o dist/clipboard.min.js",
-    "build-watch": "watchify src/clipboard.js -o dist/clipboard.js -v",
+    "build-watch": "watchify src/clipboard.js -s Clipboard -o dist/clipboard.js -v",
    "test": "npm run test-browser && npm run test-server",
    "test-browser": "karma start --single-run",
    "test-server": "mocha test/module-systems.js"
--- a/src/clipboard-action.js
+++ b/src/clipboard-action.js
@@ -56,7 +56,7 @@ class ClipboardAction {
        this.fakeElem = document.createElement('textarea');
        this.fakeElem.style.position = 'absolute';
        this.fakeElem.style.left = '-9999px';
-        this.fakeElem.style.top = document.body.scrollTop + 'px';
+        this.fakeElem.style.top = (window.pageYOffset || document.documentElement.scrollTop) + 'px';
        this.fakeElem.setAttribute('readonly', '');
        this.fakeElem.value = this.text;
        this.selectedText = this.text;
Author	SHA1	Message	Date
Zeno Rocha	b3ad81570e	Release v1.4.1	2015-10-09 09:08:02 +02:00
Zeno Rocha	17aedf5221	Merge pull request #74 from calvincorreli/patch-1 Fix for scrolling to top in unsupported firefox	2015-10-09 09:01:19 +02:00
Zeno Rocha	e14d92e2f4	Merge pull request #78 from arve0/watch_standalone script build-watch should build standalone like build-debug	2015-10-07 22:06:00 +02:00
arve0	b7b2259dfb	script build-watch should build standalone like build-debug	2015-10-06 15:55:21 +02:00
Calvin Correli	c5b416b108	Fix for scrolling to top in unsupported firefox My previous fix didn't actually work. Instead of scrolling to the bottom it would scroll to the top, because it turns out document.body.scrollTop always returns 0 in Firefox. This should work in most browsers. See here: http://help.dottoro.com/ljnvjiow.php	2015-10-05 11:54:20 -04:00