Release v1.5.11

Fix fake element position from "fixed" to "absolute" #194 #250
Press Ctrl+C to copy -> Press Command+C to copy (#252 )
2023-08-10 21:12:48 +03:00 · 2016-06-08 21:46:20 -07:00 · 2016-06-08 21:44:54 -07:00 · 2016-06-02 15:28:16 -07:00 · 2016-05-26 11:35:18 -07:00 · 2016-05-01 16:14:51 -07:00
26 changed files with 1001 additions and 631 deletions
--- a/.babelrc
+++ b/.babelrc
@@ -0,0 +1,4 @@
+{
+  "presets": ["es2015-loose"],
+  "plugins": ["transform-es2015-modules-umd"]
+}
--- a/.banner
+++ b/.banner
@@ -0,0 +1,6 @@
+/*!
+ * clipboard.js v<%= pkg.version %>
+ * https://zenorocha.github.io/clipboard.js
+ *
+ * Licensed MIT © Zeno Rocha
+ */
--- a/.editorconfig
+++ b/.editorconfig
@@ -17,3 +17,6 @@ insert_final_newline = true

 [*.md]
 trim_trailing_whitespace = false
+
+[{package.json,bower.json}]
+indent_size = 2
--- a/.github/issue_template.md
+++ b/.github/issue_template.md
@@ -0,0 +1,15 @@
+### Minimal example
+
+> Fork this [JSFiddle](https://jsfiddle.net/zenorocha/5kk0eysw/) and reproduce your issue.
+
+### Expected behaviour
+
+I thought that by going to the page '...' and pressing the button '...' then '...' would happen.
+
+### Actual behaviour
+
+Instead of '...', what I saw was that '...' happened instead.
+
+### Browsers affected
+
+I tested on all major browsers and only IE 11 does not work.
--- a/.gitignore
+++ b/.gitignore
@@ -1,3 +1,4 @@
+lib
 npm-debug.log
 bower_components
 node_modules
--- a/.npmignore
+++ b/.npmignore
@@ -0,0 +1,7 @@
+/.*/
+/demo/
+/test/
+/.*
+/bower.json
+/karma.conf.js
+/src
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,3 +1,4 @@
+sudo: false
 language: node_js
 node_js:
-  - 0.12
+  - stable
--- a/bower.json
+++ b/bower.json
@@ -1,9 +1,19 @@
 {
  "name": "clipboard",
-  "version": "1.4.0",
+  "version": "1.5.11",
  "description": "Modern copy to clipboard. No Flash. Just 2kb",
  "license": "MIT",
  "main": "dist/clipboard.js",
+  "ignore": [
+    "/.*/",
+    "/demo/",
+    "/test/",
+    "/.*",
+    "/bower.json",
+    "/karma.conf.js",
+    "/src",
+    "/lib"
+  ],
  "keywords": [
    "clipboard",
    "copy",
--- a/demo/constructor-node.html
+++ b/demo/constructor-node.html
@@ -0,0 +1,30 @@
+<!DOCTYPE html>
+<html lang="en">
+<head>
+    <meta charset="UTF-8">
+    <title>constructor-node</title>
+</head>
+<body>
+    <!-- 1. Define some markup -->
+    <div id="btn" data-clipboard-text="1">
+        <span>Copy</span>
+    </div>
+
+    <!-- 2. Include library -->
+    <script src="../dist/clipboard.min.js"></script>
+
+    <!-- 3. Instantiate clipboard by passing a HTML element -->
+    <script>
+    var btn = document.getElementById('btn');
+    var clipboard = new Clipboard(btn);
+
+    clipboard.on('success', function(e) {
+        console.log(e);
+    });
+
+    clipboard.on('error', function(e) {
+        console.log(e);
+    });
+    </script>
+</body>
+</html>
--- a/demo/constructor-nodelist.html
+++ b/demo/constructor-nodelist.html
@@ -0,0 +1,30 @@
+<!DOCTYPE html>
+<html lang="en">
+<head>
+    <meta charset="UTF-8">
+    <title>constructor-nodelist</title>
+</head>
+<body>
+    <!-- 1. Define some markup -->
+    <button data-clipboard-text="1">Copy</button>
+    <button data-clipboard-text="2">Copy</button>
+    <button data-clipboard-text="3">Copy</button>
+
+    <!-- 2. Include library -->
+    <script src="../dist/clipboard.min.js"></script>
+
+    <!-- 3. Instantiate clipboard by passing a list of HTML elements -->
+    <script>
+    var btns = document.querySelectorAll('button');
+    var clipboard = new Clipboard(btns);
+
+    clipboard.on('success', function(e) {
+        console.log(e);
+    });
+
+    clipboard.on('error', function(e) {
+        console.log(e);
+    });
+    </script>
+</body>
+</html>
--- a/demo/constructor-selector.html
+++ b/demo/constructor-selector.html
@@ -0,0 +1,29 @@
+<!DOCTYPE html>
+<html lang="en">
+<head>
+    <meta charset="UTF-8">
+    <title>constructor-selector</title>
+</head>
+<body>
+    <!-- 1. Define some markup -->
+    <button class="btn" data-clipboard-text="1">Copy</button>
+    <button class="btn" data-clipboard-text="2">Copy</button>
+    <button class="btn" data-clipboard-text="3">Copy</button>
+
+    <!-- 2. Include library -->
+    <script src="../dist/clipboard.min.js"></script>
+
+    <!-- 3. Instantiate clipboard by passing a string selector -->
+    <script>
+    var clipboard = new Clipboard('.btn');
+
+    clipboard.on('success', function(e) {
+        console.log(e);
+    });
+
+    clipboard.on('error', function(e) {
+        console.log(e);
+    });
+    </script>
+</body>
+</html>
--- a/demo/function-target.html
+++ b/demo/function-target.html
@@ -0,0 +1,32 @@
+<!DOCTYPE html>
+<html lang="en">
+<head>
+    <meta charset="UTF-8">
+    <title>function-target</title>
+</head>
+<body>
+    <!-- 1. Define some markup -->
+    <button class="btn">Copy</button>
+    <div>hello</div>
+
+    <!-- 2. Include library -->
+    <script src="../dist/clipboard.min.js"></script>
+
+    <!-- 3. Instantiate clipboard -->
+    <script>
+    var clipboard = new Clipboard('.btn', {
+        target: function() {
+            return document.querySelector('div');
+        }
+    });
+
+    clipboard.on('success', function(e) {
+        console.log(e);
+    });
+
+    clipboard.on('error', function(e) {
+        console.log(e);
+    });
+    </script>
+</body>
+</html>
--- a/demo/function-text.html
+++ b/demo/function-text.html
@@ -0,0 +1,31 @@
+<!DOCTYPE html>
+<html lang="en">
+<head>
+    <meta charset="UTF-8">
+    <title>function-text</title>
+</head>
+<body>
+    <!-- 1. Define some markup -->
+    <button class="btn">Copy</button>
+
+    <!-- 2. Include library -->
+    <script src="../dist/clipboard.min.js"></script>
+
+    <!-- 3. Instantiate clipboard -->
+    <script>
+    var clipboard = new Clipboard('.btn', {
+        text: function() {
+            return 'to be or not to be';
+        }
+    });
+
+    clipboard.on('success', function(e) {
+        console.log(e);
+    });
+
+    clipboard.on('error', function(e) {
+        console.log(e);
+    });
+    </script>
+</body>
+</html>
--- a/demo/target-div.html
+++ b/demo/target-div.html
@@ -0,0 +1,28 @@
+<!DOCTYPE html>
+<html lang="en">
+<head>
+    <meta charset="UTF-8">
+    <title>target-div</title>
+</head>
+<body>
+    <!-- 1. Define some markup -->
+    <div>hello</div>
+    <button class="btn" data-clipboard-action="copy" data-clipboard-target="div">Copy</button>
+
+    <!-- 2. Include library -->
+    <script src="../dist/clipboard.min.js"></script>
+
+    <!-- 3. Instantiate clipboard -->
+    <script>
+    var clipboard = new Clipboard('.btn');
+
+    clipboard.on('success', function(e) {
+        console.log(e);
+    });
+
+    clipboard.on('error', function(e) {
+        console.log(e);
+    });
+    </script>
+</body>
+</html>
--- a/demo/target-input.html
+++ b/demo/target-input.html
@@ -0,0 +1,28 @@
+<!DOCTYPE html>
+<html lang="en">
+<head>
+    <meta charset="UTF-8">
+    <title>target-input</title>
+</head>
+<body>
+    <!-- 1. Define some markup -->
+    <input id="foo" type="text" value="hello">
+    <button class="btn" data-clipboard-action="copy" data-clipboard-target="#foo">Copy</button>
+
+    <!-- 2. Include library -->
+    <script src="../dist/clipboard.min.js"></script>
+
+    <!-- 3. Instantiate clipboard -->
+    <script>
+    var clipboard = new Clipboard('.btn');
+
+    clipboard.on('success', function(e) {
+        console.log(e);
+    });
+
+    clipboard.on('error', function(e) {
+        console.log(e);
+    });
+    </script>
+</body>
+</html>
--- a/demo/target-textarea.html
+++ b/demo/target-textarea.html
@@ -0,0 +1,28 @@
+<!DOCTYPE html>
+<html lang="en">
+<head>
+    <meta charset="UTF-8">
+    <title>target-textarea</title>
+</head>
+<body>
+    <!-- 1. Define some markup -->
+    <textarea id="bar">hello</textarea>
+    <button class="btn" data-clipboard-action="cut" data-clipboard-target="#bar">Cut</button>
+
+    <!-- 2. Include library -->
+    <script src="../dist/clipboard.min.js"></script>
+
+    <!-- 3. Instantiate clipboard -->
+    <script>
+    var clipboard = new Clipboard('.btn');
+
+    clipboard.on('success', function(e) {
+        console.log(e);
+    });
+
+    clipboard.on('error', function(e) {
+        console.log(e);
+    });
+    </script>
+</body>
+</html>
--- a/dist/clipboard.js
+++ b/dist/clipboard.js
--- a/dist/clipboard.min.js
+++ b/dist/clipboard.min.js
--- a/package.js
+++ b/package.js
@@ -0,0 +1,12 @@
+// Package metadata for Meteor.js.
+
+Package.describe({
+  name: "zenorocha:clipboard",
+  summary: "Modern copy to clipboard. No Flash. Just 2kb.",
+  version: "1.5.11",
+  git: "https://github.com/zenorocha/clipboard.js"
+});
+
+Package.onUse(function(api) {
+  api.addFiles("dist/clipboard.js", "client");
+});
--- a/package.json
+++ b/package.json
@@ -1,51 +1,49 @@
 {
  "name": "clipboard",
-  "version": "1.4.0",
+  "version": "1.5.11",
  "description": "Modern copy to clipboard. No Flash. Just 2kb",
  "repository": "zenorocha/clipboard.js",
  "license": "MIT",
-  "main": "dist/clipboard.js",
-  "browser": "src/clipboard.js",
-  "browserify": {
-    "transform": [
-      [
-        "babelify",
-        {
-          "loose": "all"
-        }
-      ]
-    ]
-  },
+  "main": "lib/clipboard.js",
  "keywords": [
    "clipboard",
    "copy",
    "cut"
  ],
  "dependencies": {
-    "babelify": "^6.3.0",
-    "browserify": "^11.2.0",
-    "delegate-events": "^1.1.1",
+    "good-listener": "^1.1.6",
+    "select": "^1.0.6",
    "tiny-emitter": "^1.0.0"
  },
  "devDependencies": {
+    "babel-cli": "^6.5.1",
+    "babel-core": "^6.5.2",
+    "babel-plugin-transform-es2015-modules-umd": "^6.5.0",
+    "babel-preset-es2015": "^6.5.0",
+    "babel-preset-es2015-loose": "^7.0.0",
+    "babelify": "^7.2.0",
+    "bannerify": "Vekat/bannerify#feature-option",
+    "browserify": "^13.0.0",
+    "chai": "^3.4.1",
+    "install": "^0.4.4",
    "karma": "^0.13.10",
-    "karma-browserify": "^4.4.0",
+    "karma-browserify": "^5.0.1",
    "karma-chai": "^0.1.0",
    "karma-mocha": "^0.2.0",
-    "karma-phantomjs-launcher": "^0.2.1",
+    "karma-phantomjs-launcher": "^1.0.0",
    "karma-sinon": "^1.0.4",
    "mocha": "^2.3.3",
-    "phantomjs-polyfill": "0.0.1",
-    "uglify": "^0.1.5",
+    "phantomjs-prebuilt": "^2.1.4",
+    "sinon": "^1.17.2",
+    "uglify-js": "^2.4.24",
    "watchify": "^3.4.0"
  },
  "scripts": {
    "build": "npm run build-debug && npm run build-min",
-    "build-debug": "browserify src/clipboard.js -s Clipboard -o dist/clipboard.js",
-    "build-min": "uglify -s dist/clipboard.js -o dist/clipboard.min.js",
-    "build-watch": "watchify src/clipboard.js -o dist/clipboard.js -v",
-    "test": "npm run test-browser && npm run test-server",
-    "test-browser": "karma start --single-run",
-    "test-server": "mocha test/module-systems.js"
+    "build-debug": "browserify src/clipboard.js -s Clipboard -t [babelify] -p [bannerify --file .banner ] -o dist/clipboard.js",
+    "build-min": "uglifyjs dist/clipboard.js --comments '/!/' -m screw_ie8=true -c screw_ie8=true,unused=false -o dist/clipboard.min.js",
+    "build-watch": "watchify src/clipboard.js -s Clipboard -t [babelify] -o dist/clipboard.js -v",
+    "test": "karma start --single-run",
+    "prepublish": "babel src --out-dir lib --loose all"
  }
 }
--- a/readme.md
+++ b/readme.md
@@ -1,10 +1,11 @@
 # clipboard.js

 [![Build Status](http://img.shields.io/travis/zenorocha/clipboard.js/master.svg?style=flat)](https://travis-ci.org/zenorocha/clipboard.js)
+![Killing Flash](https://img.shields.io/badge/killing-flash-brightgreen.svg?style=flat)

-> Modern copy to clipboard. No Flash. Just 2kb
+> Modern copy to clipboard. No Flash. Just 3kb gzipped.

-<a href="https://zenorocha.github.io/clipboard.js/"><img width="728" src="https://cloud.githubusercontent.com/assets/398893/9983535/5ab0a950-5fb4-11e5-9602-e73c0b661883.jpg" alt="Demo"></a>
+<a href="http://clipboardjs.com/"><img width="728" src="https://cloud.githubusercontent.com/assets/398893/9983535/5ab0a950-5fb4-11e5-9602-e73c0b661883.jpg" alt="Demo"></a>

 ## Why

@@ -30,19 +31,13 @@ If you're not into package management, just [download a ZIP](https://github.com/

 ## Setup

-First, include the script located on the `dist` folder.
+First, include the script located on the `dist` folder or load it from [a third-party CDN provider](https://github.com/zenorocha/clipboard.js/wiki/CDN-Providers).

 ```html
 <script src="dist/clipboard.min.js"></script>
 ```

-Or load it from a CDN.
-
-```html
-<script src="https://cdn.rawgit.com/zenorocha/clipboard.js/master/dist/clipboard.min.js"></script>
-```
-
-Now, you need to instantiate it using a DOM selector. This selector corresponds to the trigger element(s), for example `<button class="btn">`.
+Now, you need to instantiate it by [passing a DOM selector](https://github.com/zenorocha/clipboard.js/blob/master/demo/constructor-selector.html#L18), [HTML element](https://github.com/zenorocha/clipboard.js/blob/master/demo/constructor-node.html#L16-L17), or [list of HTML elements](https://github.com/zenorocha/clipboard.js/blob/master/demo/constructor-nodelist.html#L18-L19).

 ```js
 new Clipboard('.btn');
@@ -62,7 +57,7 @@ A pretty common use case is to copy content from another element. You can do tha

 The value you include on this attribute needs to match another's element selector.

-<a href="https://zenorocha.github.io/clipboard.js/#example-target"><img width="473" alt="example-2" src="https://cloud.githubusercontent.com/assets/398893/9983467/a4946aaa-5fb1-11e5-9780-f09fcd7ca6c8.png"></a>
+<a href="http://clipboardjs.com/#example-target"><img width="473" alt="example-2" src="https://cloud.githubusercontent.com/assets/398893/9983467/a4946aaa-5fb1-11e5-9780-f09fcd7ca6c8.png"></a>

 ```html
 <!-- Target -->
@@ -80,7 +75,7 @@ Additionally, you can define a `data-clipboard-action` attribute to specify if y

 If you omit this attribute, `copy` will be used by default.

-<a href="https://zenorocha.github.io/clipboard.js/#example-action"><img width="473" alt="example-3" src="https://cloud.githubusercontent.com/assets/398893/10000358/7df57b9c-6050-11e5-9cd1-fbc51d2fd0a7.png"></a>
+<a href="http://clipboardjs.com/#example-action"><img width="473" alt="example-3" src="https://cloud.githubusercontent.com/assets/398893/10000358/7df57b9c-6050-11e5-9cd1-fbc51d2fd0a7.png"></a>

 ```html
 <!-- Target -->
@@ -98,7 +93,7 @@ As you may expect, the `cut` action only works on `<input>` or `<textarea>` elem

 Truth is, you don't even need another element to copy its content from. You can just include a `data-clipboard-text` attribute in your trigger element.

-<a href="https://zenorocha.github.io/clipboard.js/#example-text"><img width="147" alt="example-1" src="https://cloud.githubusercontent.com/assets/398893/10000347/6e16cf8c-6050-11e5-9883-1c5681f9ec45.png"></a>
+<a href="http://clipboardjs.com/#example-text"><img width="147" alt="example-1" src="https://cloud.githubusercontent.com/assets/398893/10000347/6e16cf8c-6050-11e5-9883-1c5681f9ec45.png"></a>

 ```html
 <!-- Trigger -->
@@ -130,7 +125,7 @@ clipboard.on('error', function(e) {
 });
 ```

-For a live demonstration, open this [site](https://zenorocha.github.io/clipboard.js/) and just your console :)
+For a live demonstration, open this [site](http://clipboardjs.com/) and just your console :)

 ## Advanced Options

@@ -156,7 +151,7 @@ new Clipboard('.btn', {
 });
 ```

-Also, with are working with single page apps, you may want to manage the lifecycle of the DOM more precisely. Here's how you clean up the events and objects that we create.
+Also, if you are working with single page apps, you may want to manage the lifecycle of the DOM more precisely. Here's how you clean up the events and objects that we create.

 ```js
 var clipboard = new Clipboard('.btn');
@@ -167,15 +162,15 @@ clipboard.destroy();

 This library relies on both [Selection](https://developer.mozilla.org/en-US/docs/Web/API/Selection) and [execCommand](https://developer.mozilla.org/en-US/docs/Web/API/Document/execCommand) APIs. The second one is supported in the following browsers.

-| <img src="https://zenorocha.github.io/clipboard.js/assets/images/chrome.png" width="48px" height="48px" alt="Chrome logo"> | <img src="https://zenorocha.github.io/clipboard.js/assets/images/firefox.png" width="48px" height="48px" alt="Firefox logo"> | <img src="https://zenorocha.github.io/clipboard.js/assets/images/ie.png" width="48px" height="48px" alt="Internet Explorer logo"> | <img src="https://zenorocha.github.io/clipboard.js/assets/images/opera.png" width="48px" height="48px" alt="Opera logo"> | <img src="https://zenorocha.github.io/clipboard.js/assets/images/safari.png" width="48px" height="48px" alt="Safari logo"> |
+| <img src="http://clipboardjs.com/assets/images/chrome.png" width="48px" height="48px" alt="Chrome logo"> | <img src="http://clipboardjs.com/assets/images/firefox.png" width="48px" height="48px" alt="Firefox logo"> | <img src="http://clipboardjs.com/assets/images/ie.png" width="48px" height="48px" alt="Internet Explorer logo"> | <img src="http://clipboardjs.com/assets/images/opera.png" width="48px" height="48px" alt="Opera logo"> | <img src="http://clipboardjs.com/assets/images/safari.png" width="48px" height="48px" alt="Safari logo"> |
 |:---:|:---:|:---:|:---:|:---:|
 | 42+ ✔ | 41+ ✔ | 9+ ✔ | 29+ ✔ | Nope ✘ |

 Although copy/cut operations with [execCommand](https://developer.mozilla.org/en-US/docs/Web/API/Document/execCommand) aren't supported on Safari yet (including mobile), it gracefully degrades because [Selection](https://developer.mozilla.org/en-US/docs/Web/API/Selection) is supported.

-That means you can show a tooltip saying `Copied!` when `success` event is called and `Press Ctrl+C to copy` when `error` event is called because the text is already selected.
+That means you can show a tooltip saying `Copied!` when `success` event is called and `Press Command+C to copy` when `error` event is called because the text is already selected.

-For a live demonstration, open this [site](https://zenorocha.github.io/clipboard.js/) on Safari.
+For a live demonstration, open this [site](http://clipboardjs.com) on Safari.

 ## License

--- a/src/clipboard-action.js
+++ b/src/clipboard-action.js
@@ -1,3 +1,5 @@
+import select from 'select';
+
 /**
 * Inner class which performs selection from either `text` or `target`
 * properties and then executes copy or cut operations.
@@ -30,18 +32,12 @@ class ClipboardAction {
     * on the existence of `text` and `target` properties.
     */
    initSelection() {
-        if (this.text && this.target) {
-            throw new Error('Multiple attributes declared, use either "target" or "text"');
-        }
-        else if (this.text) {
+        if (this.text) {
            this.selectFake();
        }
        else if (this.target) {
            this.selectTarget();
        }
-        else {
-            throw new Error('Missing required attributes, use either "target" or "text"');
-        }
    }

    /**
@@ -49,27 +45,36 @@ class ClipboardAction {
     * and makes a selection on it.
     */
    selectFake() {
+        const isRTL = document.documentElement.getAttribute('dir') == 'rtl';
+
        this.removeFake();

-        this.fakeHandler = document.body.addEventListener('click', () => this.removeFake());
+        this.fakeHandler = document.body.addEventListener('click', () => this.removeFake()) || true;

        this.fakeElem = document.createElement('textarea');
+        // Prevent zooming on iOS
+        this.fakeElem.style.fontSize = '12pt';
+        // Reset box model
+        this.fakeElem.style.border = '0';
+        this.fakeElem.style.padding = '0';
+        this.fakeElem.style.margin = '0';
+        // Move element out of screen horizontally
        this.fakeElem.style.position = 'absolute';
-        this.fakeElem.style.left = '-9999px';
-        this.fakeElem.style.top = document.body.scrollTop + 'px';
+        this.fakeElem.style[ isRTL ? 'right' : 'left' ] = '-9999px';
+        // Move element to the same position vertically
+        this.fakeElem.style.top = (window.pageYOffset || document.documentElement.scrollTop) + 'px';
        this.fakeElem.setAttribute('readonly', '');
        this.fakeElem.value = this.text;
-        this.selectedText = this.text;

        document.body.appendChild(this.fakeElem);

-        this.fakeElem.select();
+        this.selectedText = select(this.fakeElem);
        this.copyText();
    }

    /**
     * Only removes the fake element after another click event, that way
-     * an user can hit `Ctrl+C` to copy because selection still exists.
+     * a user can hit `Ctrl+C` to copy because selection still exists.
     */
    removeFake() {
        if (this.fakeHandler) {
@@ -87,19 +92,7 @@ class ClipboardAction {
     * Selects the content from element passed on `target` property.
     */
    selectTarget() {
-        if (this.target.nodeName === 'INPUT' || this.target.nodeName === 'TEXTAREA') {
-            this.target.select();
-            this.selectedText = this.target.value;
-        }
-        else {
-            let range = document.createRange();
-            let selection = window.getSelection();
-
-            range.selectNodeContents(this.target);
-            selection.addRange(range);
-            this.selectedText = selection.toString();
-        }
-
+        this.selectedText = select(this.target);
        this.copyText();
    }

@@ -180,6 +173,14 @@ class ClipboardAction {
    set target(target) {
        if (target !== undefined) {
            if (target && typeof target === 'object' && target.nodeType === 1) {
+                if (this.action === 'copy' && target.hasAttribute('disabled')) {
+                    throw new Error('Invalid "target" attribute. Please use "readonly" instead of "disabled" attribute');
+                }
+
+                if (this.action === 'cut' && (target.hasAttribute('readonly') || target.hasAttribute('disabled'))) {
+                    throw new Error('Invalid "target" attribute. You can\'t cut text from elements with "readonly" or "disabled" attributes');
+                }
+
                this._target = target;
            }
            else {
@@ -204,4 +205,4 @@ class ClipboardAction {
    }
 }

-export default ClipboardAction;
+module.exports = ClipboardAction;
--- a/src/clipboard.js
+++ b/src/clipboard.js
@@ -1,21 +1,21 @@
 import ClipboardAction from './clipboard-action';
-import Delegate from 'delegate-events';
 import Emitter from 'tiny-emitter';
+import listen from 'good-listener';

 /**
- * Base class which takes a selector, delegates a click event to it,
+ * Base class which takes one or more elements, adds event listeners to them,
 * and instantiates a new `ClipboardAction` on each click.
 */
 class Clipboard extends Emitter {
    /**
-     * @param {String} selector
+     * @param {String|HTMLElement|HTMLCollection|NodeList} trigger
     * @param {Object} options
     */
-    constructor(selector, options) {
+    constructor(trigger, options) {
        super();

        this.resolveOptions(options);
-        this.delegateClick(selector);
+        this.listenClick(trigger);
    }

    /**
@@ -30,19 +30,11 @@ class Clipboard extends Emitter {
    }

    /**
-     * Delegates a click event on the passed selector.
-     * @param {String} selector
+     * Adds a click event listener to the passed trigger.
+     * @param {String|HTMLElement|HTMLCollection|NodeList} trigger
     */
-    delegateClick(selector) {
-        this.binding = Delegate.bind(document.body, selector, 'click', (e) => this.onClick(e));
-    }
-
-    /**
-     * Undelegates a click event on body.
-     * @param {String} selector
-     */
-    undelegateClick() {
-        Delegate.unbind(document.body, 'click', this.binding);
+    listenClick(trigger) {
+        this.listener = listen(trigger, 'click', (e) => this.onClick(e));
    }

    /**
@@ -50,15 +42,17 @@ class Clipboard extends Emitter {
     * @param {Event} e
     */
    onClick(e) {
+        const trigger = e.delegateTarget || e.currentTarget;
+
        if (this.clipboardAction) {
            this.clipboardAction = null;
        }

        this.clipboardAction = new ClipboardAction({
-            action  : this.action(e.delegateTarget),
-            target  : this.target(e.delegateTarget),
-            text    : this.text(e.delegateTarget),
-            trigger : e.delegateTarget,
+            action  : this.action(trigger),
+            target  : this.target(trigger),
+            text    : this.text(trigger),
+            trigger : trigger,
            emitter : this
        });
    }
@@ -76,7 +70,7 @@ class Clipboard extends Emitter {
     * @param {Element} trigger
     */
    defaultTarget(trigger) {
-        let selector = getAttributeValue('target', trigger);
+        const selector = getAttributeValue('target', trigger);

        if (selector) {
            return document.querySelector(selector);
@@ -95,7 +89,7 @@ class Clipboard extends Emitter {
     * Destroy lifecycle.
     */
    destroy() {
-        this.undelegateClick();
+        this.listener.destroy();

        if (this.clipboardAction) {
            this.clipboardAction.destroy();
@@ -111,7 +105,7 @@ class Clipboard extends Emitter {
 * @param {Element} element
 */
 function getAttributeValue(suffix, element) {
-    let attribute = `data-clipboard-${suffix}`;
+    const attribute = `data-clipboard-${suffix}`;

    if (!element.hasAttribute(attribute)) {
        return;
@@ -120,4 +114,4 @@ function getAttributeValue(suffix, element) {
    return element.getAttribute(attribute);
 }

-export default Clipboard;
+module.exports = Clipboard;
--- a/test/clipboard-action.js
+++ b/test/clipboard-action.js
@@ -35,27 +35,17 @@ describe('ClipboardAction', () => {
    });

    describe('#initSelection', () => {
-        it('should throw an error since both "text" and "target" were passed', done => {
-            try {
-                new ClipboardAction({
-                    text: 'foo',
-                    target: document.querySelector('#input')
-                });
-            }
-            catch(e) {
-                assert.equal(e.message, 'Multiple attributes declared, use either "target" or "text"');
-                done();
-            }
-        });
+        it('should set the position right style property', done => {
+            // Set document direction
+            document.documentElement.setAttribute('dir', 'rtl');

-        it('should throw an error since neither "text" nor "target" were passed', done => {
-            try {
-                new ClipboardAction();
-            }
-            catch(e) {
-                assert.equal(e.message, 'Missing required attributes, use either "target" or "text"');
-                done();
-            }
+            let clip = new ClipboardAction({
+                    emitter: new Emitter(),
+                    text: 'foo'
+                });
+
+            assert.equal(clip.fakeElem.style.right, '-9999px');
+            done();
        });
    });

--- a/test/clipboard.js
+++ b/test/clipboard.js
@@ -1,6 +1,6 @@
 import Clipboard from '../src/clipboard';
 import ClipboardAction from '../src/clipboard-action';
-import Delegate from 'delegate-events';
+import listen from 'good-listener';

 describe('Clipboard', () => {
    before(() => {
@@ -9,8 +9,14 @@ describe('Clipboard', () => {
        global.button.setAttribute('data-clipboard-text', 'foo');
        document.body.appendChild(global.button);

+        global.span = document.createElement('span');
+        global.span.innerHTML = 'bar';
+
+        global.button.appendChild(span);
+
        global.event = {
-            delegateTarget: global.button
+            target: global.button,
+            currentTarget: global.button
        };
    });

@@ -18,7 +24,7 @@ describe('Clipboard', () => {
        document.body.innerHTML = '';
    });

-    describe('#resolveOptions', function() {
+    describe('#resolveOptions', () => {
        before(() => {
            global.fn = function() {};
        });
@@ -48,45 +54,10 @@ describe('Clipboard', () => {
        });
    });

-    describe('#delegateClick', function() {
-        before(() => {
-            global.spy = sinon.spy(Delegate, 'bind');
-        });
-
-        after(() => {
-            global.spy.restore();
-        });
-
-        it('should delegate a click event to the passed selector', () => {
-            let element = document.body;
-            let selector = '.btn';
-            let event = 'click';
-
-            let clipboard = new Clipboard(selector);
-
-            assert.ok(global.spy.calledOnce);
-            assert.ok(global.spy.calledWith(element, selector, event));
-        });
-    });
-
-    describe('#undelegateClick', function() {
-        before(() => {
-            global.spy = sinon.spy(Delegate, 'unbind');
-        });
-
-        after(() => {
-            global.spy.restore();
-        });
-
-        it('should undelegate a click event', () => {
-            let element = document.body;
-            let event = 'click';
-
+    describe('#listenClick', () => {
+        it('should add a click event listener to the passed selector', () => {
            let clipboard = new Clipboard('.btn');
-            clipboard.undelegateClick();
-
-            assert.ok(global.spy.calledOnce);
-            assert.ok(global.spy.calledWith(element, event));
+            assert.isObject(clipboard.listener);
        });
    });

@@ -98,13 +69,22 @@ describe('Clipboard', () => {
            assert.instanceOf(clipboard.clipboardAction, ClipboardAction);
        });

-        it('should throws exception target', done => {
+        it('should use an event\'s currentTarget when not equal to target', () => {
+            let clipboard = new Clipboard('.btn');
+            let bubbledEvent = { target: global.span, currentTarget: global.button };
+
+            clipboard.onClick(bubbledEvent);
+            assert.instanceOf(clipboard.clipboardAction, ClipboardAction);
+        });
+
+        it('should throw an exception when target is invalid', done => {
            try {
                var clipboard = new Clipboard('.btn', {
                    target: function() {
                        return null;
                    }
                });
+
                clipboard.onClick(global.event);
            }
            catch(e) {
--- a/test/module-systems.js
+++ b/test/module-systems.js
@@ -1,15 +0,0 @@
-var assert = require('chai').assert;
-var browserify = require('browserify');
-
-describe('CommonJS', function() {
-    it('should import the lib in a commonjs env without babel', function(done) {
-        browserify('./dist/clipboard.js').bundle(function(err) {
-            assert.equal(err, null);
-            done();
-        });
-    });
-});
-
-describe('AMD', function() {
-    // TODO: Write test case
-});
Author	SHA1	Message	Date
Zeno Rocha	a4ab305297	Release v1.5.11	2016-06-08 21:46:20 -07:00
Zeno Rocha	294e9fcb5d	Fix fake element position from "fixed" to "absolute" #194 #250	2016-06-08 21:44:54 -07:00
Ali Bozorgkhan	79c3361ca4	Press Ctrl+C to copy -> Press Command+C to copy (#252 ) As Safari users are mostly using mac, coping a text needs Command+C instead of Ctrl+C	2016-06-02 15:28:16 -07:00
grabus	c3fefc1fc0	Fix memory leak because of fakeHandlers (#243 ) addEventListener always returns undefined by spec https://www.w3.org/TR/DOM-Level-2-Events/events.html#Events-EventTarget-addEventListener	2016-05-26 11:35:18 -07:00
Zeno Rocha	42bd266f0b	Adds basic JSFiddle to help people reproduce their bugs	2016-05-01 16:14:51 -07:00
Zeno Rocha	53a733fcb5	Release v1.5.10	2016-04-03 22:33:02 -07:00
Zeno Rocha	7a5a910bcd	Removes error message when target/text attributes are null, undefined, or false	2016-04-03 22:16:22 -07:00
Zeno Rocha	0163f7cb72	Merge pull request #216 from sebastianekstrom/master Use const instead of let when applicable	2016-04-01 08:48:49 -07:00
Sebastian Ekström	941bdbb16e	Use const instead of let when applicable	2016-04-01 13:17:12 +02:00
Zeno Rocha	00d5cc4e96	Updates tagline #210	2016-03-17 09:12:23 -07:00
Zeno Rocha	07a1f8456b	Throws error when disabled or readonly attributes are used on target element Fixes #41	2016-03-01 15:38:25 -08:00
Zeno Rocha	ff3cd2c722	Release v1.5.9	2016-02-26 10:26:32 -08:00
Zeno Rocha	d346f30e5d	Merge pull request #190 from heldr/master update modules and fix #176	2016-02-25 12:19:22 -08:00
Helder Santana	e5fe34c524	WTF?! npm	2016-02-25 15:17:07 -05:00
Zeno Rocha	0a6aace544	Merge pull request #194 from stepancar/patch-1 minor fix for fake elem	2016-02-25 12:06:38 -08:00
Stepan Mikhaylyuk	43d9c11aaf	minor fix for fake elem after call clipboard all page scrolls down. As i understand, its relates to fake element, cause its append to body. I just set position to 'fixed' and now it works right. I think 'fixed' is more css-style independence then 'absolute'	2016-02-25 15:20:13 +03:00
Helder Santana	90a52149ed	fix babel 6 export default behaviour	2016-02-20 01:41:40 -05:00
Helder Santana	83b9d6a84d	update modules and fix #176	2016-02-20 01:14:33 -05:00
Zeno Rocha	3d13baa385	Adds issue template	2016-02-18 11:40:00 -08:00
Zeno Rocha	7e37c95121	Release v1.5.8	2016-02-04 11:28:33 -08:00
Zeno Rocha	bc9bcdd678	Adds explanations on textarea styling #143 #179 #180	2016-02-04 11:25:00 -08:00
Zeno Rocha	4c9e29a0dc	Resets invisible textarea's paddings and margins #179	2016-02-04 11:09:10 -08:00
speedplane	bd6dc9eb9f	Prevent auto-zooming on an iphone by making the text area size appropriate size. Fixes Issue 180.	2016-02-04 11:12:04 -05:00
Zeno Rocha	a88bb77be4	Release v1.5.7	2016-02-03 08:31:41 -08:00
Zeno Rocha	e86dc2caa2	Revert "Upgrades to Babel 6" This reverts commit `ee1eb455f4`.	2016-02-03 08:22:35 -08:00
Zeno Rocha	8392a7ba1c	Release v1.5.6	2016-02-02 13:44:26 -08:00
RAFIE Younes	31e3622e17	Fixed RTL issue #161	2016-02-02 13:27:11 -08:00
Zeno Rocha	ee1eb455f4	Upgrades to Babel 6	2016-02-02 13:11:25 -08:00
Zeno Rocha	d50f2fb73f	Updates good-listener Fixes #170	2016-02-02 12:52:17 -08:00
Zeno Rocha	c8221c742d	Serves the unminified version for Meteor Fixes #167	2016-01-21 08:21:44 -08:00
Zeno Rocha	efc22cf651	Merge pull request #150 from nettofarah/patch-1 Add a bit more clarity to Invalid Target test	2015-12-17 10:48:14 -08:00
Netto Farah	4b27a72dce	Add a bit more clarity to Invalid Target test	2015-12-13 13:11:02 -08:00
Zeno Rocha	c12c610b22	Merge pull request #134 from hmln/minor-readme-change Fix typo in readme.	2015-11-19 07:21:32 -08:00
hmln	1d772a0cbe	Fix typo in readme.	2015-11-19 00:38:20 -03:00
Zeno Rocha	d9254459b7	Merge pull request #131 from oskarcieslik/es2015_minor_fixes Small ES2015 changes	2015-11-14 12:25:53 -06:00
Oskar Cieslik (rpawfuiml)	2aa163b1d0	Small ES2015 changes ;).	2015-11-13 22:01:59 +01:00
Zeno Rocha	783dc6f3cf	Adds devDependencies since peerDependencies does not work anymore	2015-11-13 01:39:19 -08:00
Zeno Rocha	3188ffbce3	Release v1.5.5	2015-11-13 01:20:15 -08:00
Zeno Rocha	5dba68634e	Fixes a bug where non-editable elements were being focused	2015-11-13 01:20:02 -08:00
Zeno Rocha	a12a056ef6	Release v1.5.4	2015-11-13 00:25:35 -08:00
Zeno Rocha	cb4301658c	Updates delegate package which now exposes e.delegateTarget property #120	2015-11-13 00:24:46 -08:00
Zeno Rocha	5efcdf2810	Merge pull request #120 from pawlufelice/fix_event_target use event's currentTarget instead of target	2015-11-13 00:20:20 -08:00
Zeno Rocha	72926580c3	Updates meteor version #123	2015-11-12 09:58:10 -08:00
Zeno Rocha	4967f118fe	Release v1.5.3	2015-11-12 09:57:35 -08:00
Zeno Rocha	44d59b34a2	Merge pull request #123 from alippai/patch-1 Bump npm version to match the bower version.	2015-11-12 09:57:29 -08:00
Ádám Lippai	9d6375d20e	Bump npm version to match the others.	2015-11-10 11:08:35 +01:00
Paul Felice	37136663df	use event's currentTarget instead of target	2015-11-06 15:49:21 +01:00
Zeno Rocha	db575bb4df	Removes babelify from being a dependency to a devDependency #15 #105	2015-10-28 13:06:14 -07:00
Zeno Rocha	bb6c4c0e7c	Release v1.5.2	2015-10-28 12:57:47 -07:00
Zeno Rocha	03ee9829e0	Removes browserify tests	2015-10-28 12:56:52 -07:00
Zeno Rocha	24f6e1f541	Moves babel to devDependencies	2015-10-28 12:56:38 -07:00
Zeno Rocha	5bdfff6375	Ignores unnecessary files on bower and npm	2015-10-28 12:56:21 -07:00
Zeno Rocha	4b73122f81	Provides a transpiled version to npm so browserify and webpack users do not have to transpile by themselves Fixes #15 #27 #105	2015-10-28 12:54:29 -07:00
Zeno Rocha	171f438f22	Release v1.5.1	2015-10-27 09:32:43 -07:00
Zeno Rocha	42a459402c	Release v1.5.0	2015-10-26 23:04:54 -07:00
Zeno Rocha	b26cdb3b41	Allows HTML elements to be passed in the constructor - Fixes #25	2015-10-26 23:02:29 -07:00
Zeno Rocha	57c7fcf9a4	Adds a bunch of demos	2015-10-26 22:53:03 -07:00
Zeno Rocha	6b1f6b22a6	Allows HTML elements to be passed in the constructor - Fixes #25	2015-10-26 01:06:29 -07:00
Zeno Rocha	705e2dbefd	Release v1.4.3	2015-10-24 11:41:53 -07:00
Zeno Rocha	fd66d6b51f	Fix missing character in readme #101	2015-10-23 09:11:45 -07:00
Zeno Rocha	e0263beb20	Merge pull request #101 from curtisgibby/patch-1 Fix missing character in readme	2015-10-23 09:09:11 -07:00
Curtis Gibby	4d734bc277	Fix missing character in readme	2015-10-23 10:08:09 -06:00
Zeno Rocha	d5015f6313	New home!	2015-10-21 22:35:13 -07:00
Zeno Rocha	7e5beb439a	⚡	2015-10-21 10:11:50 -07:00
Zeno Rocha	70b2548a80	Migrates to delegate fork	2015-10-20 12:35:25 -07:00
Zeno Rocha	c6dc01cc29	Moves selection code to a different package	2015-10-19 16:21:38 -07:00
Zeno Rocha	f0245ab701	Merge pull request #95 from rafaelfragosom/arrowfunctions Replacing anonymous functions with arrow functions to keep the pattern of the tests	2015-10-15 17:27:58 -07:00
Rafael Fragoso	c911ba0f53	Replacing anonymous functions with arrow functions to keep the pattern	2015-10-15 21:24:06 -03:00
Zeno Rocha	d166ff6d96	Adds banner - Fixes #88	2015-10-15 12:49:08 -07:00
Zeno Rocha	f7da00f0ba	Update meteor package version #82	2015-10-14 18:38:52 -07:00
Lucas N. Munhoz	c7c2d9fb4f	Add Package metadata for Meteor.js	2015-10-14 18:38:52 -07:00
Zeno Rocha	9fb666b365	Merge pull request #80 from heldr/fix_npm3_tree fix npm3 build updating uglifyjs to version 2	2015-10-13 11:47:38 -07:00
Helder Santana	9ddd3a8017	travis ci tweaks	2015-10-13 14:42:35 -04:00
Helder Santana	8d804fdd42	fix npm3 build updating uglifyjs to version 2	2015-10-13 14:37:26 -04:00
Zeno Rocha	54efeb68e6	Release v1.4.2	2015-10-13 11:12:56 -07:00
Nik Butenko	f56825bf73	Add .npmignore	2015-10-13 09:45:51 -07:00
Zeno Rocha	9377659c9c	Fixes discontiguous selection #17	2015-10-13 09:28:11 -07:00
Zeno Rocha	5e43e84d91	Merge pull request #86 from whitj00/patch-1 replace 'an user' with 'a user'	2015-10-10 08:59:47 -07:00
Whit Jackson	6ca2ba514c	replace 'an user' with 'a user'	2015-10-09 17:17:37 -07:00
Zeno Rocha	b3ad81570e	Release v1.4.1	2015-10-09 09:08:02 +02:00
Zeno Rocha	17aedf5221	Merge pull request #74 from calvincorreli/patch-1 Fix for scrolling to top in unsupported firefox	2015-10-09 09:01:19 +02:00
Zeno Rocha	e14d92e2f4	Merge pull request #78 from arve0/watch_standalone script build-watch should build standalone like build-debug	2015-10-07 22:06:00 +02:00
arve0	b7b2259dfb	script build-watch should build standalone like build-debug	2015-10-06 15:55:21 +02:00
Calvin Correli	c5b416b108	Fix for scrolling to top in unsupported firefox My previous fix didn't actually work. Instead of scrolling to the bottom it would scroll to the top, because it turns out document.body.scrollTop always returns 0 in Firefox. This should work in most browsers. See here: http://help.dottoro.com/ljnvjiow.php	2015-10-05 11:54:20 -04:00